diff options
| author | user <user@clank> | 2026-08-07 08:01:25 +0200 |
|---|---|---|
| committer | user <user@clank> | 2026-08-07 08:01:25 +0200 |
| commit | 16318e4bfd939666bc45fa6f5d2c17cb8f374f3b (patch) | |
| tree | e0395a59d86bb7a20899aa06b7569cf781fb1e93 /idatui/edit_ctl.py | |
| parent | Three redundancies in the heads walk: item flags were fetched three times per... (diff) | |
| download | ida-tui-16318e4bfd939666bc45fa6f5d2c17cb8f374f3b.tar.gz ida-tui-16318e4bfd939666bc45fa6f5d2c17cb8f374f3b.tar.xz ida-tui-16318e4bfd939666bc45fa6f5d2c17cb8f374f3b.zip | |
An item edit (c/d/u/p) keeps the listing's walk in front of it instead of discarding the model. bump_items now takes the edited address; rows before an edit keep their addresses and their row numbers, so only the pages from the edit onward are re-walked. Getting the listing back after undefining at the cursor on bash: 4890ms -> 19ms (257x). Adds .auto/check_edit.py to the gate. total_ms is flat — the bench has no item-edit phase, and the one I wrote hangs (reverted, cause recorded).
Result: {"status":"keep","total_ms":25783,"lg_boot_ms":777.9,"lg_decomp_ms":2381.9,"lg_graph_ms":1209.5,"lg_hex_ms":450,"lg_index_ms":68,"lg_listing_cold_ms":434.6,"lg_listing_warm_ms":405.2,"lg_nav_ms":6801.2,"lg_palette_ms":4.7,"lg_rename_ms":744.7,"lg_render_ms":222.4,"lg_search_ms":3885.6,"lg_split_ms":2261.4,"pure_graph_ms":216.4,"sm_boot_ms":463.6,"sm_decomp_ms":1304.6,"sm_graph_ms":740.9,"sm_hex_ms":438.4,"sm_index_ms":2.4,"sm_listing_cold_ms":270.3,"sm_listing_warm_ms":267.2,"sm_nav_ms":312.4,"sm_palette_ms":0.3,"sm_rename_ms":415.8,"sm_render_ms":257.7,"sm_search_ms":60.8,"sm_split_ms":1385.2,"fails":0}
Diffstat (limited to 'idatui/edit_ctl.py')
| -rw-r--r-- | idatui/edit_ctl.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/idatui/edit_ctl.py b/idatui/edit_ctl.py index 54f4d89..435fab9 100644 --- a/idatui/edit_ctl.py +++ b/idatui/edit_ctl.py @@ -288,7 +288,7 @@ class EditController: app.call_from_thread(app._status, err) return # The label shows in the listing's head rows -> invalidate + reopen. - app.program.bump_items() + app.program.bump_items(addr) # Naming the address *of a function start* is a function rename by any # other name. Without this the cached index kept the old name, so # `functions`/`names`/resolve/the palette all reported the rename had @@ -510,7 +510,7 @@ class EditController: diag.note(f"make_data({ea:#x}, {type_decl!r})", e) app.call_from_thread(app._status, f"make data: {e}") return - app.program.bump_items() + app.program.bump_items(ea) anchor = anchor or _M().ViewAnchor() anchor.flash = f"data ({type_decl}) @ {ea:#x} (Ctrl+S to save)" name = app.program.region_label(ea) @@ -707,8 +707,10 @@ class EditController: diag.note(f"edit_item({kind}, {ea:#x})", e) app.call_from_thread(app._status, f"{kind}: {e}") return - # Structure changed everywhere: drop all item/function/decomp caches. - app.program.bump_items() + # Structure changed: drop all item/function/decomp caches. The segment + # listing keeps its walk in front of `ea` -- rows before an edit keep + # their addresses and their row numbers. + app.program.bump_items(ea) # Re-resolve: a define_func upgrades the region to a real function view; # anything else re-reads the (still function-less) listing in place. anchor = anchor or _M().ViewAnchor() |