diff options
| author | blasty <peter@haxx.in> | 2026-07-24 20:31:50 +0200 |
|---|---|---|
| committer | blasty <peter@haxx.in> | 2026-07-24 20:31:50 +0200 |
| commit | 041c73c5b5c0b35a2e171bc94400d158e01581c4 (patch) | |
| tree | d99bf4db4d37218b9c8496fec02731bd094979f5 /idatui | |
| parent | decomp: prettier 'decompiling' overlay — animated braille spinner (diff) | |
| download | ida-tui-041c73c5b5c0b35a2e171bc94400d158e01581c4.tar.gz ida-tui-041c73c5b5c0b35a2e171bc94400d158e01581c4.tar.xz ida-tui-041c73c5b5c0b35a2e171bc94400d158e01581c4.zip | |
decomp: fix stuck 'decompiling' spinner when re-opening a loaded function
The F5-from-listing overlay fix raises dec.loading=True before _show_active, but
_show_active only clears it via _load_decomp when the function needs
(re)decompiling. F5 on a function already shown in the pseudocode pane
(dec.loaded_ea == cur.ea) took the else branch, which never cleared loading -> the
spinner stayed up forever. Clear dec.loading=False in that branch.
Pilot view_toggle gains a check: F5 the same cached function again and assert the
overlay clears (8/8).
Diffstat (limited to 'idatui')
| -rw-r--r-- | idatui/app.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/idatui/app.py b/idatui/app.py index 5a50683..f098b71 100644 --- a/idatui/app.py +++ b/idatui/app.py @@ -4365,6 +4365,10 @@ class IdaTui(App): dec.loading = True # gray out + 'decompiling…' overlay self._load_decomp(self._cur.ea, self._cur.name) else: + # Already showing this function: clear any overlay raised by the + # F5-from-listing path (no re-decompile happens here, so nothing + # else would). + dec.loading = False self._status_for_cur("pseudocode") # -- hex view ---------------------------------------------------------- # |