diff options
| author | blasty <peter@haxx.in> | 2026-08-01 15:50:11 +0200 |
|---|---|---|
| committer | blasty <peter@haxx.in> | 2026-08-01 15:50:11 +0200 |
| commit | eff11c6be7bd2a264c2c047bb60e145f5f43015a (patch) | |
| tree | cd975f1dbcb293dacda8e723a73e9ac71b5bf15d /pyproject.toml | |
| parent | rpc: a navigation that timed out reported success and corrupted the next edit (diff) | |
| download | ida-tui-eff11c6be7bd2a264c2c047bb60e145f5f43015a.tar.gz ida-tui-eff11c6be7bd2a264c2c047bb60e145f5f43015a.tar.xz ida-tui-eff11c6be7bd2a264c2c047bb60e145f5f43015a.zip | |
rpc: comments are instant and newlines no longer vanish
Two fixes to the comment verb:
Drop the per-character typing delay. Rename/retype/goto use a 35 ms delay for
the visual effect (the agent's keystrokes appear one by one on the livestream),
but comments can be long — a 200-char annotation blocked the driver for 7 s of
pure animation. Comments now type instantly (delay=0); the aesthetic delay is
kept for rename, retype and goto where values are short.
Escape literal newlines before injecting into the prompt. The Input widget is
single-line, so a real 0x0a sent as a keystroke was silently swallowed. The
app's _do_comment already converts the two-char sequence '\\n' into a real
newline for IDA, so the RPC layer now does text.replace('\\n', '\\\\n')
before typing — both literal newlines from the caller and explicit \\n in the
text reach IDA as multi-line comments (each line gets its own // prefix in the
decompiler).
Verified on a live pane: a comment with an embedded newline now renders as two
// lines in the pseudocode, and long comments appear without the multi-second
typing pause.
tests/test_scenarios.py: 212 passed, 0 failed.
Diffstat (limited to 'pyproject.toml')
0 files changed, 0 insertions, 0 deletions
