From ec6594e9d8b147df0aaff67752c5b85a55c0971d Mon Sep 17 00:00:00 2001 From: blasty Date: Sat, 25 Jul 2026 00:10:30 +0200 Subject: split: click a pane to drive it (not just Tab) + spell it out in the status MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The sync direction follows the FOCUSED pane, but that was only discoverable via Tab. Add on_descendant_focus: in split, focusing a pane (Tab or a mouse click) makes it the leading/driver pane and re-syncs — so clicking into the pseudocode and cursoring around now drives the listing, matching intuition (previously a click focused the widget but left _active — and thus the sync direction — pointing at the other pane). The split status now ends with "(Tab/click: drive )" so it's obvious. Pilot split_view: clicking the pseudocode pane makes it the driver (17/17). --- idatui/app.py | 19 +++++++++++++++++-- tests/test_scenarios.py | 7 +++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/idatui/app.py b/idatui/app.py index 0d4ae6a..66d1b44 100644 --- a/idatui/app.py +++ b/idatui/app.py @@ -4626,11 +4626,26 @@ class IdaTui(App): at = f" @ {ea:#x}" if ea is not None else "" rel = f" \u2194 {n} insn" if n else "" self._status(f"{self._cur.name}{at} " - f"[split \u00b7 pseudocode line {dec.cursor + 1}{rel}]") + f"[split \u00b7 pseudocode line {dec.cursor + 1}{rel}]" + f" (Tab/click: drive listing)") else: ea = self.query_one(ListingView)._cursor_ea() at = f" @ {ea:#x}" if ea is not None else "" - self._status(f"{self._cur.name}{at} [split \u00b7 listing]") + self._status(f"{self._cur.name}{at} [split \u00b7 listing]" + f" (Tab/click: drive pseudocode)") + + def on_descendant_focus(self, event) -> None: # type: ignore[no-untyped-def] + """In split, focusing a pane (Tab or a mouse click) makes it the leading/ + driver pane, so the sync direction follows where you're actually working.""" + if not self._split: + return + w = event.control + new = ("decomp" if isinstance(w, DecompView) + else "listing" if isinstance(w, ListingView) else None) + if new is not None and new != self._active: + self._active = new + self._sync_split(new) + self._split_status() @work(thread=True, group="split-map") def _load_split_map(self, ea: int) -> None: diff --git a/tests/test_scenarios.py b/tests/test_scenarios.py index 3401645..7d9f3b7 100644 --- a/tests/test_scenarios.py +++ b/tests/test_scenarios.py @@ -415,6 +415,13 @@ async def s_split_view(c: Ctx): await c.pause(0.1) c.check("Tab again focuses the listing pane", app._active == "listing", f"active={app._active}") + # a mouse click on the other pane also makes it the driver (not just Tab) + await c.pilot.click(DecompView, offset=(10, 5)) + await c.pause(0.15) + c.check("clicking the pseudocode pane makes it the driver", + app._active == "decomp", f"active={app._active}") + await c.press("tab") # restore listing as the driver + await c.pause(0.1) # navigation in split keeps BOTH panes on the (new) function nf = c.find_func(lambda f: f.addr != app._cur.ea and f.size > 80) if nf is not None: -- cgit v1.3.1-sl0p