From 3a28b97cb355822b2d380f9507b203b79cb0e4e9 Mon Sep 17 00:00:00 2001 From: blasty Date: Fri, 24 Jul 2026 14:53:56 +0200 Subject: mcp: delete the ida-pro-mcp transport, supervisor, and mcp-only tests The idalib worker is the only backend now, so remove the dead HTTP/supervisor surface entirely (~2200 lines): * deleted idatui/client.py (the IDAClient HTTP/JSON-RPC transport + session manager), idatui/tui.py (the old mcp TUI entry, superseded by launch.py), spawn.sh, and systemd/ (the supervisor unit). * deleted the mcp-only tests (stress_client, smoke_client, test_keepalive, stress_paging, rpc_smoke, serverctl.sh, pane_smoke, test_domain) -- the worker pilot (tests/test_scenarios.py) supersedes them. * migrated the tmux RPC harness (idatui/pane.py) to the worker: it spawns `idatui.launch --rpc ` instead of the mcp `idatui.tui`, drops the supervisor auto-start/ensure machinery, and reaps our own worker (idatui/worker.py) instead of ida_pro_mcp.idalib_server. --db/--url/--no- ensure-server are gone; --open is required. * __init__ / __main__ / domain no longer import client (exceptions come from errors.py, the domain client hint is WorkerClient); pyproject points both console scripts at idatui.launch; README + ida-tui header describe the worker-only flow. What stays (by design): the ida_pro_mcp *package* (the worker reuses its @tool functions in-process) and server/patch_server.py (the worker injects its custom tools on startup). Verified: whole package imports + IdaTui constructs + pilot lists 31 scenarios. The worker pilot (134 pass / 2 known flakes) is the E2E gate. --- ida-tui | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'ida-tui') diff --git a/ida-tui b/ida-tui index ed4db09..9ceb949 100755 --- a/ida-tui +++ b/ida-tui @@ -2,14 +2,11 @@ # Caveman launcher for the IDA TUI: # # ./ida-tui foo.elf # open a binary and drive it — that's it -# ./ida-tui # attach to the sole open session (mcp) -# ./ida-tui --db # attach to a specific session (mcp) # -# Opening a binary now spins up our own idalib worker (a unix-socket subprocess; -# no HTTP, no supervisor). --db/attach still use the deprecated ida-pro-mcp -# path; pass --backend mcp to force it. Uses the venv python that has textual -# (override with $IDATUI_PYTHON); the worker auto-picks the python that has -# ida_pro_mcp (override with $IDATUI_WORKER_PYTHON). +# Opening a binary spins up our own idalib worker (a unix-socket subprocess; +# no HTTP, no supervisor). Uses the venv python that has textual (override with +# $IDATUI_PYTHON); the worker auto-picks the python that has ida_pro_mcp +# (override with $IDATUI_WORKER_PYTHON). set -eu SCRIPT_DIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd) -- cgit v1.3.1-sl0p