From fa55e260c2a8be2e84c564cad2c180672c43113a Mon Sep 17 00:00:00 2001 From: blasty Date: Fri, 24 Jul 2026 14:41:23 +0200 Subject: refactor: extract shared error hierarchy + Session into idatui/errors.py The IDAError/IDAConnectionError/IDAToolError/... exceptions and the Session dataclass were defined in client.py (the ida-pro-mcp HTTP client), but the idalib worker path (worker_client/domain/app) needs them without the HTTP transport. Move them to a transport-agnostic errors.py; client.py re-exports them so the deprecated mcp tooling and stress tests are unchanged (verified: errors.IDAToolError IS client.IDAToolError, so cross-module `except` still works). worker_client, domain (TYPE_CHECKING-guarded IDAClient hint), app, and __init__ now import the shared types from errors.py. This decouples the worker path from client.py at runtime -- the prerequisite for deleting the mcp transport. --- idatui/app.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'idatui/app.py') diff --git a/idatui/app.py b/idatui/app.py index 1936153..712b4de 100644 --- a/idatui/app.py +++ b/idatui/app.py @@ -42,7 +42,8 @@ from textual.widgets.option_list import Option from .highlight import highlight_c -from .client import IDAClient, IDAToolError, IDAConnectionError +from .errors import IDAToolError, IDAConnectionError +from .client import IDAClient # deprecated mcp transport (worker path uses WorkerClient) from .domain import DisasmModel, Func, Head, ListingModel, Program, Struct # Styles for the disassembly listing. -- cgit v1.3.1-sl0p