From 3835eb2aa35362401fc6489900394e022baa6981 Mon Sep 17 00:00:00 2001 From: blasty Date: Fri, 24 Jul 2026 15:42:20 +0200 Subject: hex: click to place the byte cursor (hex + ascii panes) HexView subclasses ScrollView directly and had no mouse handler, so clicking never moved the byte cursor -- after a wheel-scroll the cursor was stuck off screen with no way to reposition it by mouse. Add on_click: map the content offset (scroll_offset + click, past the 1-col padding) to a row, and the x column to a byte 0..15 across both the hex cells (3 cols each, +1 gap before byte 8) and the ascii pane. Double-click jumps to code, mirroring Enter. Pilot scenario extends `hex`: scroll the viewport (cursor goes off-screen), then click in the hex pane and the ascii pane and assert the cursor lands on the exact clicked row+byte. 9/9 hex checks pass. --- tests/test_scenarios.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) (limited to 'tests') diff --git a/tests/test_scenarios.py b/tests/test_scenarios.py index 62f474d..92c6315 100644 --- a/tests/test_scenarios.py +++ b/tests/test_scenarios.py @@ -506,6 +506,28 @@ async def s_hex(c: Ctx): await c.wait(lambda: hx.cursor_va() == target_va, 15) c.check("'g' in the hex view jumps the cursor to an address", hx.cursor_va() == target_va, f"va={hx.cursor_va():#x} want={target_va:#x}") + # -- scroll the viewport, then click to move the byte cursor into it ---- + await c.press("g") + await c.type(hex(rng[0])) + await c.press("enter") + await c.wait(lambda: hx.cursor_va() == rng[0], 10) + hx.scroll_to(y=40, animate=False) # wheel-style scroll: viewport only + await c.pause(0.15) + top = round(hx.scroll_offset.y) + c.check("hex viewport scrolls without dragging the cursor along", + top >= 20 and (hx.cursor // 16) < top, + f"top={top} cursor_row={hx.cursor // 16}") + PAD = 1 # HexView { padding: 0 1 } -> content is inset one col + await c.pilot.click(HexView, offset=(PAD + 19 + 3 * 3, 5)) # hex byte 3, row 5 + await c.pause(0.1) + c.check("clicking the hex pane moves the cursor into the scrolled region", + hx.cursor == (top + 5) * 16 + 3, + f"cursor={hx.cursor} want={(top + 5) * 16 + 3} top={top}") + await c.pilot.click(HexView, offset=(PAD + 70 + 10, 7)) # ascii byte 10, row 7 + await c.pause(0.1) + c.check("clicking the ascii pane maps to the right byte", + hx.cursor == (top + 7) * 16 + 10, + f"cursor={hx.cursor} want={(top + 7) * 16 + 10}") await c.press("backslash") await c.wait(lambda: app._active != "hex", 10) c.check("backslash returns from hex to the code view", -- cgit v1.3.1-sl0p