From d237b01cfb241f417567c964e0df0658cf921570 Mon Sep 17 00:00:00 2001
From: Narishma-gb <194818981+Narishma-gb@users.noreply.github.com>
Date: Wed, 10 Sep 2025 06:31:11 +0200
Subject: Misc. naming and cleanup (#139)

* Name some printer/diploma routines

* Name `wd434`

* Name `NAME_LENGTH_JP`

* Rename `callabd`/`calladb` to `farcall`/`callfar`
---
 engine/events/hidden_objects/bench_guys.asm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

(limited to 'engine/events/hidden_objects')

diff --git a/engine/events/hidden_objects/bench_guys.asm b/engine/events/hidden_objects/bench_guys.asm
index e5a2a724..81519f2f 100644
--- a/engine/events/hidden_objects/bench_guys.asm
+++ b/engine/events/hidden_objects/bench_guys.asm
@@ -18,14 +18,10 @@ PrintBenchGuyText:
 	ld a, [wSpritePlayerStateData1FacingDirection]
 	cp b
 
-	; bug: an 'inc hl' instruction is needed before looping back. When trying to
-	; talk to a bench guy from above, this Sprite Facing test will fail, and the
-	; next loop iteration will be misaligned within BenchGuyTextPointers table.
-	; As a result, the routine will miss the terminator byte, and continue to
-	; process data beyond the table boundary.
-	; It seems that it will only return after starting to read data from VRAM
-	; (According to Pan Docs, during PPU mode 3, reads return garbage value,
-	; usually $FF).
+	; bug: an 'inc hl' instruction is needed before looping back.
+	; Due to Yellow's new Pokecenter layout, it's now impossible to talk to a
+	; bench guy from above. The bug is still present but will not be triggered
+	; in a regular play.
 	jr nz, .loop ; player isn't facing the bench guy
 	ld a, [hl]
 	jp PrintPredefTextID
-- 
cgit v1.3.1-sl0p