From f3326786259f4e53c06b7565369add7605bea8ba Mon Sep 17 00:00:00 2001
From: Narishma-gb <194818981+Narishma-gb@users.noreply.github.com>
Date: Tue, 18 Nov 2025 21:17:31 +0100
Subject: Use more hardware and graphics constants (#532)

- Use `OBJ_SIZE` and `TILE_SIZE` from hardware.inc.
- `SPRITESTATEDATA1_LENGTH`, `NUM_SPRITESTATEDATA_STRUCTS`
  and `TILE_1BPP_SIZE` are used in some places.
- Highlight an oversight in `OakSpeech` where several
  direct MBC bank switches are requested.
- Remove redundant comments in home/overworld.asm.
- Add unreferenced `FillBgMap` function to avoid a byte
  of dead code.
- Some constants added in wram.asm.
- Correctly separate the commented code in `SaveMainData`.
---
 engine/gfx/sprite_oam.asm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'engine/gfx/sprite_oam.asm')

diff --git a/engine/gfx/sprite_oam.asm b/engine/gfx/sprite_oam.asm
index 737443a6..649ab01e 100644
--- a/engine/gfx/sprite_oam.asm
+++ b/engine/gfx/sprite_oam.asm
@@ -148,16 +148,16 @@ PrepareOAMData::
 	ldh a, [hOAMBufferOffset]
 	ld l, a
 	ld h, HIGH(wShadowOAM)
-	ld de, $4
-	ld b, $a0
+	ld de, OBJ_SIZE
+	ld b, SCREEN_HEIGHT_PX + OAM_Y_OFS
 	ld a, [wMovementFlags]
 	bit BIT_LEDGE_OR_FISHING, a
-	ld a, $a0
+	ld a, LOW(wShadowOAMEnd)
 	jr z, .clear
 
 ; Don't clear the last 4 entries because they are used for the shadow in the
 ; jumping down ledge animation and the rod in the fishing animation.
-	ld a, $90
+	ld a, LOW(wShadowOAMSprite36)
 
 .clear
 	cp l
-- 
cgit v1.3.1-sl0p