| Commit message (Collapse) | Author |
|---|
|
Double-clicking a tab in the bar switches to it and drops into RenameTab mode,
matching the double-click-to-rename we added for panes in the sl0ppij zellij
fork. Enter commits, Esc cancels, exactly as the rename keybind does.
Widgets are held behind &self and cannot keep click state, so double-click
detection lives centrally in ModuleConfig::handle_mouse_action and is passed
to Widget::process_click as a flag.
THE TRAP, and the reason this is not a two-line change:
handle_mouse_action also runs for Mouse::Release. A single click therefore
arrives as LeftClick followed by Release at the SAME position. Counting
releases would make every single click register as a double click, and
resetting on release would mean a real double click never registers at all,
since the release falls between the two clicks. Only LeftClick participates;
Release neither counts nor resets.
A completed pair is consumed, so a triple click does not fire a second rename.
switch_tab_to() is called before switch_to_input_mode(), because RenameTab acts
on the ACTIVE tab - renaming without switching first would rename the wrong one.
Threshold is 400ms, the same one zellij uses for text-selection double clicks,
so the bar feels consistent with the panes.
Detection is extracted as register_click_for_double_click() so it can be tested
without constructing a ModuleConfig. Tests cover: a real double click, the
release-in-between regression, too-slow clicks, clicks at different positions,
and the triple-click case.
Upstream tests still pass: 25 total (20 upstream + 5 new).
Note: this repo's .cargo/config.toml targets wasm32-wasip1 and runs tests under
wasmtime, which is not installed here. Tests are run with
`cargo test --target x86_64-unknown-linux-gnu` instead.
|
|
|
|
* feat(command): add {focused_pane_cwd} to run commands in the focused pane's directory
Command widgets configured with command_<name>_cwd "{focused_pane_cwd}"
now execute in the current working directory of the focused terminal pane,
following it as the user changes directories.
This relies on zellij's CwdChanged event and get_pane_cwd API. The focused
terminal pane of the active tab is tracked via PaneUpdate (seeding the cwd
on focus change) and updated on CwdChanged. Affected command results are
invalidated so they re-run, and stale results from a previous cwd are
discarded to avoid showing the wrong directory.
Closes #92
* fix(command): release focused cwd command locks
Focused-cwd commands can be invalidated while their first run is still in flight. If that result is later discarded as stale, no command result is stored but the per-command lock remains, preventing future reruns.
Release the command lock when invalidating focused-cwd commands so the branch badge can recover on subsequent renders or cwd updates.
Add a regression test for rerunning a command with no stored result after its lock is released.
|
|
* chore(deps): bump cached from 1.1.0 to 2.0.2
Bumps [cached](https://github.com/jaemk/cached) from 1.1.0 to 2.0.2.
- [Release notes](https://github.com/jaemk/cached/releases)
- [Changelog](https://github.com/jaemk/cached/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jaemk/cached/commits)
---
updated-dependencies:
- dependency-name: cached
dependency-version: 2.0.2
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* chore: fix cached 1.x to 2.x breaking changes
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Jankowski <daniel.jankowski@rub.de>
|
|
|
|
|
|
* chore(deps): bump cached from 0.59.0 to 1.1.0
Bumps [cached](https://github.com/jaemk/cached) from 0.59.0 to 1.1.0.
- [Changelog](https://github.com/jaemk/cached/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jaemk/cached/commits)
---
updated-dependencies:
- dependency-name: cached
dependency-version: 1.1.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix: breaking changes from cached 1.0
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Jankowski <daniel.jankowski@rub.de>
|
|
|
|
|
|
* adds zero based tab index support
* update after comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* chore(deps): bump zellij-tile from 0.41.2 to 0.42.1
Bumps zellij-tile from 0.41.2 to 0.42.1.
---
updated-dependencies:
- dependency-name: zellij-tile
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix(config): implement missing trait member
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Jankowski <daniel.jankowski@rub.de>
|
|
|
|
fixes #120
|
|
fixes #116
|
|
fixes #117
|
|
|
|
|
|
fixes #109
|
|
|
|
Fixes #94
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
closes #75
|
|
|
|
|
|
|
|
fixes #67
|
|
fixes #70
|
|
|
|
fixes #69
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #58
|
