aboutsummaryrefslogtreecommitdiffstats
path: root/dmcub/hw (follow)
Commit message (Collapse)AuthorAge
* Reach the PSR-SU dirty-rect path by state injection; writes stay boundeduser2026-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The earlier user-reachability test was weak because the DMCUB was idle. PSR is an eDP feature and this is a desktop card, so a real panel session is not available. Driving the firmware's own ABI first, and reporting that it failed: PSR_SET_VERSION -> COPY_SETTINGS -> ENABLE are all consumed but the state never leaves 0, read back through GPINT 7 with GET_FW_VERSION (0x07003300) as the oracle's positive control. Command injection alone does not open a session without a link. The state word is instead located at ctx + 0x7b8*panel + 0x730 -- the address the GPINT handler reports from, and the value the dirty-rect handler compares against 0x30/0x31/0x44/0x60 -- and injected in host-owned CW6. Three write/read-back round trips through the firmware's own reporting path confirm it takes effect, so the session is injected but not merely assumed. With PSR_STATE3 set the same nine user-reachable coordinate cases produce much larger state writes (4-8 bytes idle, 20-122 bytes now), proving the deeper path executes. Dumping where the bytes change rather than how many shows the offsets never move with the input: two fixed 48-byte arrays at ctx+0x2cc and ctx+0x3ec, which are exactly 3 rects x 16 bytes, plus small fixed fields, all inside the fw_state window. No user-reachable OOB write. Caveat kept: the trace buffer gained no entries and no DCN register programming was monitored, so the final region->register stage, which needs a live OTG, probably still does not run.
* Scope the DMCUB findings by reachability, and test the user-influenced pathuser2026-09-28
| | | | | | | | | | | | | | | | | | | | | | | None of findings 1-10 is exploitable by an unprivileged user: they all need the DMUB inbox, which is kernel-only under amdgpu, and the hostile field is always driver-chosen. Record that plainly so the count is not mistaken for ten exploits, and keep the residual value where it actually is -- FINDING-10 crosses a PSP->host confidentiality boundary, FINDING-8 breaks rollback, 1/2/6 are vendor-fixable bugs in firmware meant to be isolated. There is a user-influenced surface, traced in the kernel rather than assumed: FB_DAMAGE_CLIPS is settable by any client with a DRM fd, DRM core validates only the blob's element size, and amdgpu uses the raw blob rather than the clipping iterator, computing x2 - x1 into a uint32_t. Arbitrary coordinates therefore reach UPDATE_DIRTY_RECT verbatim, while the count stays bounded to 3 and the instance fields stay driver-chosen. Tested on hardware inside exactly that envelope: nine hostile-coordinate cases, all consumed, firmware alive, no unexpected CW6 write, and input-dependent (8 vs 4 bytes changed) so the handler is not ignoring them. No user-reachable bug demonstrated. The DMCUB is idle with no PSR session, so the deep region programming likely never ran -- the same unlock FINDING-4 needs; type 68 is shown user-influenced but not yet tested.
* Audit DMCUB end to end: ISA, command surface, and ten findingsuser2026-09-28
DMCUB had been skipped for months. Identify it as Tensilica Xtensa (windowed ABI, with in-tree positive/negative controls), correct the load base to VA = 0x60000000 + file - 0x200 after finding the nested $PS1 header, and build the tooling to read it: parser, CFG, disassembler with capstone-6 gaps patched, register map, jump-table and copy-length auditors. All 24 implemented DMUB_CMD__* types get a verdict, plus the GPINT doorbell (114-entry table, 12 implemented, all bounded -- a clean negative). Hardware, via PSP load on the 7900 XTX: FINDING-1 [HW] ABM_INIT_CONFIG's unchecked u16 writes ~32 KB past a 712-byte slot FINDING-2 [HW] type 8 returns memory at an unbounded 16-bit panel_inst FINDING-5 [HW] CW0/CW1/SEC_CNTL are not host-writable; PSP signature enforced FINDING-6 [HW] one command wedges the inbox loop (display DoS) FINDING-7 [HW] no arbitrary write: writes follow the host-owned CW6 window FINDING-8 [HW] auth is neither version- nor ASIC-bound; rollback works FINDING-9 [ST] DCN4 LSDMA: host-programmed DMA with only a count != 0 check FINDING-10 [HW] REG_REG_WAIT is an arbitrary-address read oracle whose timing leaks PSP-protected memory; a full CW0 sweep shows the TMR image is byte-identical to public firmware, which bounds it FINDING-3 and -4 are downgraded to latent with the evidence that did not support them. Liveness must be measured by ring consumption, not SCRATCH0 -- that mistake silently voided ~120 negative measurements and is recorded in place.