aboutsummaryrefslogtreecommitdiffstats
path: root/idatui
diff options
context:
space:
mode:
authorblasty <blasty@local>2026-08-10 01:51:28 +0200
committerblasty <blasty@local>2026-08-10 01:51:28 +0200
commitaf1aa95b3a140988b101ee32a1ed9602f4645d56 (patch)
tree66ecdeca18f5831ae796f425c3961de167cb74d1 /idatui
parentBuild the listing index in one call: boot 9.3s -> 1.25s, 911 calls -> 4 (diff)
downloadida-tui-af1aa95b3a140988b101ee32a1ed9602f4645d56.tar.gz
ida-tui-af1aa95b3a140988b101ee32a1ed9602f4645d56.tar.xz
ida-tui-af1aa95b3a140988b101ee32a1ed9602f4645d56.zip
Fix: rebuilding the row index on every switch back to the listing
Reported as "decompiler -> listing feels slow", and it was: ~900ms per Tab. The listing view re-primes every time it is shown, and priming now builds the whole row index. build_from_index() had no idempotence, so each switch back re-ran segment_index over the entire segment. Measured on bash, going back to the listing away from the primed viewport: press Tab: 904ms -> 9.7ms, and 5 backend calls -> 0 The index is a pure function of the database and the model is thrown away and rebuilt whenever anything moves the walk (stale_structure), so a model that is already indexed can return immediately. Nothing caught this because the listing was CORRECT the whole time -- only slow. Every structural assertion passed, boot still measured fast, and the suite has no notion of "how many calls did that keystroke cost". The new scenario counts backend calls across three view switches and asserts segment_index is not among them; with the guard removed again it fails. Latent and NOT fixed here: materialising a page the viewport reaches for the first time still happens inside render_line, i.e. an RPC (~20ms) on the UI loop. That predates this change -- it is how skeleton pages have always worked -- and is small enough not to read as a stall, but it is the same shape of bug and wants prefetching onto the worker that already exists for pages. Full gate: 1064 passed.
Diffstat (limited to 'idatui')
-rw-r--r--idatui/domain.py7
1 files changed, 7 insertions, 0 deletions
diff --git a/idatui/domain.py b/idatui/domain.py
index ecc6a80..9690a65 100644
--- a/idatui/domain.py
+++ b/idatui/domain.py
@@ -820,7 +820,14 @@ class ListingModel:
Returns False if the backend cannot supply it, in which case the caller
should stream as before -- this is an optimisation, not a new contract.
+
+ IDEMPOTENT, and that is load-bearing: the view re-primes on every switch
+ back to the listing, so rebuilding here unconditionally put a ~900ms
+ segment_index in front of every Tab out of the decompiler.
"""
+ with self._lock:
+ if self._done and self._heads:
+ return True # already indexed; re-priming is a no-op
try:
idx = self._prog.client.invoke(
"segment_index", addr=hex(self.seg_start), end=hex(self.seg_end),