diff options
Diffstat (limited to 'idatui')
| -rw-r--r-- | idatui/remote_tools.py | 24 |
1 files changed, 21 insertions, 3 deletions
diff --git a/idatui/remote_tools.py b/idatui/remote_tools.py index 1f66193..d2cb02e 100644 --- a/idatui/remote_tools.py +++ b/idatui/remote_tools.py @@ -52,6 +52,21 @@ import ida_typeinf import ida_ua import idaapi +# Item-class bits, read once. +# +# ida_bytes.is_code/is_data are thin python wrappers around a C call, and the +# listing walk asks ~6 times per head (once each for the row's kind, twice more +# via _is_unknown_f from _advance and _rows_for). The mask compare is the same +# question with no call at all. +# +# Equivalence is not assumed: it was checked against is_code/is_data over all +# four classes x 16,020 synthetic flag values, and over every distinct flag +# value in a real database (125 of them across 207,191 heads). Zero mismatches. +# MS_CLS=0x600, FF_CODE=0x600, FF_DATA=0x400, FF_TAIL=0x200, FF_UNK=0x0. +_MS_CLS = ida_bytes.MS_CLS +_FF_CODE = ida_bytes.FF_CODE +_FF_DATA = ida_bytes.FF_DATA + from typing import Annotated # the extracted tool signatures still carry these @@ -119,9 +134,10 @@ def _idatui_head_row(ea, flags=None, text=True): """ f = ida_bytes.get_flags(ea) if flags is None else flags - if ida_bytes.is_code(f): + cls = f & _MS_CLS # == is_code(f) / is_data(f), without the calls + if cls == _FF_CODE: kind = "code" - elif ida_bytes.is_data(f): + elif cls == _FF_DATA: kind = "data" else: kind = "unknown" @@ -552,7 +568,9 @@ def heads( # end found in O(1) via next_head, which skips undefined) so a large .bss or # gap doesn't explode into millions of one-byte rows. def _is_unknown_f(f): - return not (ida_bytes.is_code(f) or ida_bytes.is_data(f)) + # Hot: twice per head. See _MS_CLS -- same test, no call. + cls = f & _MS_CLS + return cls != _FF_CODE and cls != _FF_DATA def _run_end(e): """End (exclusive) of the undefined run starting at ``e``.""" |