diff options
| author | CreamElDudJafar <jahern2398@gmail.com> | 2026-01-17 15:41:04 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-01-17 16:41:04 -0500 |
| commit | 4c7ce815272c41c9cbfee8059f7f4d1418350e82 (patch) | |
| tree | 11290323541b9a8fb93fd50b0afb46c1ec268f03 | |
| parent | Fix CI for Linux and add CI for macOS (#567) (diff) | |
| download | pokeyellow-4c7ce815272c41c9cbfee8059f7f4d1418350e82.tar.gz pokeyellow-4c7ce815272c41c9cbfee8059f7f4d1418350e82.tar.xz pokeyellow-4c7ce815272c41c9cbfee8059f7f4d1418350e82.zip | |
Document SFX event bug inside Rocket Hideout B1F (#566)
| -rw-r--r-- | constants/event_constants.asm | 2 | ||||
| -rw-r--r-- | scripts/RocketHideoutB1F.asm | 5 |
2 files changed, 4 insertions, 3 deletions
diff --git a/constants/event_constants.asm b/constants/event_constants.asm index 7bcef25c..7f4213f1 100644 --- a/constants/event_constants.asm +++ b/constants/event_constants.asm @@ -598,7 +598,7 @@ const EVENT_BEAT_ROCKET_HIDEOUT_1_TRAINER_3 const EVENT_BEAT_ROCKET_HIDEOUT_1_TRAINER_4 const_skip - const EVENT_677 ; ??? + const EVENT_ENTERED_ROCKET_HIDEOUT const_skip 7 const EVENT_67F ; ??? const_skip diff --git a/scripts/RocketHideoutB1F.asm b/scripts/RocketHideoutB1F.asm index 9354a0c7..fc107001 100644 --- a/scripts/RocketHideoutB1F.asm +++ b/scripts/RocketHideoutB1F.asm @@ -13,7 +13,7 @@ RocketHideoutB1FDoorCallbackScript: bit BIT_CUR_MAP_LOADED_1, [hl] res BIT_CUR_MAP_LOADED_1, [hl] ret z - CheckEvent EVENT_677 + CheckEvent EVENT_ENTERED_ROCKET_HIDEOUT jr nz, .door_open CheckEventReuseA EVENT_BEAT_ROCKET_HIDEOUT_1_TRAINER_4 jr nz, .play_sound_door_open @@ -22,7 +22,8 @@ RocketHideoutB1FDoorCallbackScript: .play_sound_door_open ld a, SFX_GO_INSIDE call PlaySound - CheckEventHL EVENT_677 + ; BUG: should be SetEvent to avoid the SFX playing every time you enter the map + CheckEventHL EVENT_ENTERED_ROCKET_HIDEOUT .door_open ld a, $e ; Floor Block .set_door_block |