diff options
| author | PokefanMarcel <166040321+PokefanMarcel@users.noreply.github.com> | 2025-09-10 21:48:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-10 15:48:30 -0400 |
| commit | 59da8c8122ebb8fcc334d4e5421e4fb333eea730 (patch) | |
| tree | db8065bd595241fe45524d7bc19d7b801d6095bf | |
| parent | Use RAMG_SRAM_ENABLE (#530) (diff) | |
| download | pokeyellow-59da8c8122ebb8fcc334d4e5421e4fb333eea730.tar.gz pokeyellow-59da8c8122ebb8fcc334d4e5421e4fb333eea730.tar.xz pokeyellow-59da8c8122ebb8fcc334d4e5421e4fb333eea730.zip | |
Clean up home/copy2.asm (#531)
* Use `SCREEN_WIDTH`, rename loop, and remove obsolete comment in `ClearScreenArea`
* Use `SCREEN_HEIGHT` and `lb` in `CopyScreenTileBufferToVRAM`
* Use `SCREEN_AREA` in `ClearScreen`
| -rw-r--r-- | home/copy2.asm | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/home/copy2.asm b/home/copy2.asm index 06c45b59..9e5b1f14 100644 --- a/home/copy2.asm +++ b/home/copy2.asm @@ -161,39 +161,39 @@ CopyVideoDataDouble:: ClearScreenArea:: ; Clear tilemap area cxb at hl. - ld a, " " ; blank tile - ld de, 20 ; screen width -.y + ld a, " " + ld de, SCREEN_WIDTH +.loopRows push hl push bc -.x +.loopTiles ld [hli], a dec c - jr nz, .x + jr nz, .loopTiles pop bc pop hl add hl, de dec b - jr nz, .y + jr nz, .loopRows ret CopyScreenTileBufferToVRAM:: ; Copy wTileMap to the BG Map starting at b * $100. ; This is done in thirds of 6 rows, so it takes 3 frames. - ld c, 6 + ld c, SCREEN_HEIGHT / 3 - ld hl, $600 * 0 + lb hl, 0, 0 decoord 0, 6 * 0 call .setup call DelayFrame - ld hl, $600 * 1 + lb hl, SCREEN_HEIGHT / 3, 0 decoord 0, 6 * 1 call .setup call DelayFrame - ld hl, $600 * 2 + lb hl, 2 * SCREEN_HEIGHT / 3, 0 decoord 0, 6 * 2 call .setup jp DelayFrame @@ -215,7 +215,7 @@ CopyScreenTileBufferToVRAM:: ClearScreen:: ; Clear wTileMap, then wait ; for the bg map to update. - ld bc, 20 * 18 + ld bc, SCREEN_AREA inc b hlcoord 0, 0 ld a, " " |