diff options
| author | SatoMew <SatoMew@users.noreply.github.com> | 2022-08-12 02:22:57 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-11 21:22:57 -0400 |
| commit | ac7263b1adef941f8978b775d4b7629a7d8620e3 (patch) | |
| tree | 5d76a0166784d847521bfaea63630acb3fc85a6c | |
| parent | Replace Hard-Coded Number With Constant (#381) (diff) | |
| download | pokeyellow-ac7263b1adef941f8978b775d4b7629a7d8620e3.tar.gz pokeyellow-ac7263b1adef941f8978b775d4b7629a7d8620e3.tar.xz pokeyellow-ac7263b1adef941f8978b775d4b7629a7d8620e3.zip | |
Update comments related to Swift and Substitute checks (#380)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
| -rw-r--r-- | engine/battle/core.asm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/engine/battle/core.asm b/engine/battle/core.asm index 44c657ee..6aa697c9 100644 --- a/engine/battle/core.asm +++ b/engine/battle/core.asm @@ -5368,10 +5368,10 @@ MoveHitTest: .swiftCheck ld a, [de] cp SWIFT_EFFECT - ret z ; Swift never misses (interestingly, Azure Heights lists this is a myth, but it appears to be true) + ret z ; Swift never misses (this was fixed from the Japanese versions) call CheckTargetSubstitute ; substitute check (note that this overwrites a) jr z, .checkForDigOrFlyStatus -; This code is buggy. It's supposed to prevent HP draining moves from working on substitutes. +; The fix for Swift broke this code. It's supposed to prevent HP draining moves from working on Substitutes. ; Since CheckTargetSubstitute overwrites a with either $00 or $01, it never works. cp DRAIN_HP_EFFECT jp z, .moveMissed |