diff options
| author | Preeyan Parmar <4997904+preeyan@users.noreply.github.com> | 2024-05-23 17:43:54 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-23 11:43:54 -0500 |
| commit | d38cf5281a902b4bd167a46a7c9fd9db436484a7 (patch) | |
| tree | 2bd616c64eeb3df0b0c70ee7da02bf858dba76fb | |
| parent | Use constant in wram for hidden item flags (#445) (diff) | |
| download | pokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.tar.gz pokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.tar.xz pokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.zip | |
Add comment about audio engine perfect pitch bug (#451)
Co-authored-by: preeyan <preeyan>
| -rw-r--r-- | audio/engine_1.asm | 3 | ||||
| -rw-r--r-- | audio/engine_2.asm | 3 | ||||
| -rw-r--r-- | audio/engine_3.asm | 3 |
3 files changed, 6 insertions, 3 deletions
diff --git a/audio/engine_1.asm b/audio/engine_1.asm index 8b30fb1a..24c93c9a 100644 --- a/audio/engine_1.asm +++ b/audio/engine_1.asm @@ -831,7 +831,8 @@ Audio1_note_pitch: bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used? jr z, .skipFrequencyInc inc e ; if yes, increment the frequency by 1 - jr nc, .skipFrequencyInc + jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C. + ; Fortunately this does not seem to affect any notes that actually occur. inc d .skipFrequencyInc ld hl, wChannelFrequencyLowBytes diff --git a/audio/engine_2.asm b/audio/engine_2.asm index 8783c4c6..2d15f7bb 100644 --- a/audio/engine_2.asm +++ b/audio/engine_2.asm @@ -842,7 +842,8 @@ Audio2_note_pitch: bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used? jr z, .skipFrequencyInc inc e ; if yes, increment the frequency by 1 - jr nc, .skipFrequencyInc + jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C. + ; Fortunately this does not seem to affect any notes that actually occur. inc d .skipFrequencyInc ld hl, wChannelFrequencyLowBytes diff --git a/audio/engine_3.asm b/audio/engine_3.asm index 404e6e7c..2f1bbf96 100644 --- a/audio/engine_3.asm +++ b/audio/engine_3.asm @@ -831,7 +831,8 @@ Audio3_note_pitch: bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used? jr z, .skipFrequencyInc inc e ; if yes, increment the frequency by 1 - jr nc, .skipFrequencyInc + jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C. + ; Fortunately this does not seem to affect any notes that actually occur. inc d .skipFrequencyInc ld hl, wChannelFrequencyLowBytes |