aboutsummaryrefslogtreecommitdiffstats
path: root/data/events
diff options
context:
space:
mode:
authorSatoMew <SatoMew@users.noreply.github.com>2022-09-10 18:44:31 +0100
committerGitHub <noreply@github.com>2022-09-10 13:44:31 -0400
commit63a7eb2cf545281cbeaf289b261f9345d9249819 (patch)
tree6bb0dd48e603e8203a50ca8c1ff0853d4eb957d3 /data/events
parentUse the same music headers as pokecrystal (#382) (diff)
downloadpokeyellow-63a7eb2cf545281cbeaf289b261f9345d9249819.tar.gz
pokeyellow-63a7eb2cf545281cbeaf289b261f9345d9249819.tar.xz
pokeyellow-63a7eb2cf545281cbeaf289b261f9345d9249819.zip
Improve NPC trade labels and comments (#384)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Diffstat (limited to 'data/events')
-rw-r--r--data/events/trades.asm24
1 files changed, 14 insertions, 10 deletions
diff --git a/data/events/trades.asm b/data/events/trades.asm
index 560abfa1..b230a918 100644
--- a/data/events/trades.asm
+++ b/data/events/trades.asm
@@ -2,14 +2,18 @@ TradeMons:
; entries correspond to TRADE_FOR_* constants
table_width 3 + NAME_LENGTH, TradeMons
; give mon, get mon, dialog id, nickname
- db NIDORINO, NIDORINA, TRADE_DIALOGSET_CASUAL, "TERRY@@@@@@"
- db ABRA, MR_MIME, TRADE_DIALOGSET_CASUAL, "MARCEL@@@@@"
- db BUTTERFREE, BEEDRILL, TRADE_DIALOGSET_HAPPY, "CHIKUCHIKU@"
- db PONYTA, SEEL, TRADE_DIALOGSET_CASUAL, "SAILOR@@@@@"
- db SPEAROW, FARFETCHD, TRADE_DIALOGSET_HAPPY, "DUX@@@@@@@@"
- db SLOWBRO, LICKITUNG, TRADE_DIALOGSET_CASUAL, "MARC@@@@@@@"
- db POLIWHIRL, JYNX, TRADE_DIALOGSET_POLITE, "LOLA@@@@@@@"
- db RAICHU, ELECTRODE, TRADE_DIALOGSET_POLITE, "DORIS@@@@@@"
- db VENONAT, TANGELA, TRADE_DIALOGSET_HAPPY, "CRINKLES@@@"
- db NIDORAN_M, NIDORAN_F, TRADE_DIALOGSET_HAPPY, "SPOT@@@@@@@"
+ ; The two instances of TRADE_DIALOGSET_EVOLUTION are a leftover
+ ; from the Japanese Blue trades, which used species that evolve.
+ ; Japanese Red and Green used TRADE_DIALOGSET_CASUAL, and had
+ ; the same species as English Red and Blue.
+ db NIDORINO, NIDORINA, TRADE_DIALOGSET_CASUAL, "TERRY@@@@@@"
+ db ABRA, MR_MIME, TRADE_DIALOGSET_CASUAL, "MARCEL@@@@@"
+ db BUTTERFREE, BEEDRILL, TRADE_DIALOGSET_HAPPY, "CHIKUCHIKU@" ; unused
+ db PONYTA, SEEL, TRADE_DIALOGSET_CASUAL, "SAILOR@@@@@"
+ db SPEAROW, FARFETCHD, TRADE_DIALOGSET_HAPPY, "DUX@@@@@@@@"
+ db SLOWBRO, LICKITUNG, TRADE_DIALOGSET_CASUAL, "MARC@@@@@@@"
+ db POLIWHIRL, JYNX, TRADE_DIALOGSET_EVOLUTION, "LOLA@@@@@@@"
+ db RAICHU, ELECTRODE, TRADE_DIALOGSET_EVOLUTION, "DORIS@@@@@@"
+ db VENONAT, TANGELA, TRADE_DIALOGSET_HAPPY, "CRINKLES@@@"
+ db NIDORAN_M, NIDORAN_F, TRADE_DIALOGSET_HAPPY, "SPOT@@@@@@@"
assert_table_length NUM_NPC_TRADES