diff options
| author | luckytyphlosion <alan.rj.huang@gmail.com> | 2015-08-28 15:24:44 -0400 |
|---|---|---|
| committer | luckytyphlosion <alan.rj.huang@gmail.com> | 2015-08-28 15:24:44 -0400 |
| commit | ae920d1be7641712b3df90151cbf91af7c614a47 (patch) | |
| tree | 0b3d4c04d8485f4a277511f448067cd9a4b22c05 /engine/bank3d | |
| parent | Attempt to make pokeyellow buildable, part 8. (diff) | |
| download | pokeyellow-ae920d1be7641712b3df90151cbf91af7c614a47.tar.gz pokeyellow-ae920d1be7641712b3df90151cbf91af7c614a47.tar.xz pokeyellow-ae920d1be7641712b3df90151cbf91af7c614a47.zip | |
Fix bank3d so it matches baserom.gbc
Diffstat (limited to 'engine/bank3d')
| -rw-r--r-- | engine/bank3d/link_menu.asm | 14 | ||||
| -rw-r--r-- | engine/bank3d/main.asm | 25 |
2 files changed, 19 insertions, 20 deletions
diff --git a/engine/bank3d/link_menu.asm b/engine/bank3d/link_menu.asm index f794c1e4..3915c85d 100644 --- a/engine/bank3d/link_menu.asm +++ b/engine/bank3d/link_menu.asm @@ -9,7 +9,7 @@ Func_f531b:: ; f531b (3d:531b) ld bc,$405 call TextBoxBorder ld de,Text_f5791 - hlCoord 0,1 + hlCoord 1,2 call PlaceString hlCoord 8,0 ld bc,$80a @@ -177,7 +177,7 @@ Func_f531b:: ; f531b (3d:531b) ret Func_f5476:: ; f5476 (3d:5476) - ld hl,ColosseumEvolvedText + ld hl,ColosseumIneligibleText call PrintText asm_f547c:: ; f547c (3d:574c) jp Func_f531b @@ -200,8 +200,8 @@ PokeCup:: ; f548e (3d:548e) cp $3 jp nz,NotThreeMonsInParty ld b,$3 - ld a,[hli] .loop + ld a,[hli] cp MEW jp z,MewInParty dec b @@ -642,11 +642,11 @@ LinkMenu: ; f580c (3d:580c) call SaveScreenTilesToBuffer1 ld hl, ColosseumWhereToText call PrintText - hlCoord 5, 5 + hlCoord 5, 3 ld bc, $80d call TextBoxBorder call UpdateSprites - hlCoord 7, 7 + hlCoord 7, 5 ld de, TradeCenterText call PlaceString xor a @@ -770,7 +770,7 @@ LinkMenu: ; f580c (3d:580c) ld a, BATTLE_CENTER .next ld [wd72d], a - ld hl, _ColosseumCanceledText + ld hl, ColosseumPleaseWaitText call PrintText ld c, $32 call DelayFrames @@ -795,7 +795,7 @@ LinkMenu: ; f580c (3d:580c) ld [wMenuJoypadPollCount], a call Delay3 callab CloseLinkConnection - ld hl, ColosseumVersionText + ld hl, ColosseumCanceledText call PrintText ld hl, wd72e res 6, [hl] diff --git a/engine/bank3d/main.asm b/engine/bank3d/main.asm index 78d314a7..7b3326c9 100644 --- a/engine/bank3d/main.asm +++ b/engine/bank3d/main.asm @@ -151,18 +151,18 @@ Func_f453f:: ; f453f (3d:453f) ld bc,$730 ld a,BANK(PokemonLogoGraphics) ; redundant because this function is in bank3d call FarCopyData - ld hl,YellowLogoGraphics - ld de,vChars1+$fd0 + ld hl,YellowLogoGraphics+$230 + ld de,vChars0+$fd0 ld bc,$30 ld a,BANK(YellowLogoGraphics) call FarCopyData - ld hl,YellowLogoGraphics+$30 + ld hl,YellowLogoGraphics+$260 ld de,vChars1 ld bc,$400 ld a,BANK(YellowLogoGraphics) call FarCopyData - ld hl,YellowLogoGraphics+$430 - ld de,vChars1+$f00 + ld hl,YellowLogoGraphics+$660 + ld de,vChars0+$f00 ld bc,$c0 ld a,BANK(YellowLogoGraphics) call FarCopyData @@ -288,7 +288,7 @@ HandleMenuInputPokemonSelectionDouble:: ; f5a44 (3d:5a44) xor a ld [wPartyMonAnimCounter],a ; counter for pokemon shaking animation call Func_f5ab0 - call Delay3 + call JoypadLowSensitivity ld a,[hJoy5] and a ; was a key pressed? jr nz,.keyPressed @@ -323,7 +323,7 @@ HandleMenuInputPokemonSelectionDouble:: ; f5a44 (3d:5a44) ld c,a ld a,[wMaxMenuItem] cp c - jr nc,.checkOtherKeys + jr c,.checkOtherKeys ld a,c ld [wCurrentMenuItem],a .checkOtherKeys @@ -342,8 +342,6 @@ HandleMenuInputPokemonSelectionDouble:: ; f5a44 (3d:5a44) ld [H_DOWNARROWBLINKCNT2],a pop af ld [H_DOWNARROWBLINKCNT1],a ; restore previous values - xor a - ld [wMenuWrappingEnabled],a ; disable menu wrapping ld a,[hJoy5] ret @@ -450,7 +448,7 @@ Func_f5b2d:: ; f5b2d (3d:5b2d) jp PrintText CoordsData_f5b64:: ; f5b64 (3d:5b64) - db 13,07 + db 11,07 db $ff Text_f5b67:: ; f5b67 (3d:5b67) @@ -458,7 +456,7 @@ Text_f5b67:: ; f5b67 (3d:5b67) db "@" Text_f5b6c:: ; f5b6c (3d:5b6c) - TX_FAR _NewBadgeRequiredText ; 2d:412d + TX_FAR _CyclingIsFunText ; 2d:41ca db "@" AddItemToInventory_:: ; f5b70 (3d:5b70) @@ -484,16 +482,17 @@ AddItemToInventory_:: ; f5b70 (3d:5b70) ld a,[hli] and a jr z,.addNewItem -.loop +.notAtEndOfInventory ld a,[hli] ld b,a ; b = ID of current item in table ld a,[wcf91] ; a = ID of item being added cp b ; does the current item in the table match the item being added? jp z,.increaseItemQuantity ; if so, increase the item's quantity inc hl +.loop ld a,[hl] cp a,$ff ; is it the end of the table? - jr nz,.loop + jr nz, .notAtEndOfInventory .addNewItem ; add an item not yet in the inventory pop hl ld a,d |
