diff options
| author | Rangi <35663410+Rangi42@users.noreply.github.com> | 2025-01-28 23:31:15 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-28 23:31:15 -0500 |
| commit | afb899016938d03911eaafb85c7caa1c67680210 (patch) | |
| tree | 26e5d73301ab16e060c4a16171e0a5aa3c47d732 /engine/items | |
| parent | Comment on size of union (diff) | |
| download | pokeyellow-afb899016938d03911eaafb85c7caa1c67680210.tar.gz pokeyellow-afb899016938d03911eaafb85c7caa1c67680210.tar.xz pokeyellow-afb899016938d03911eaafb85c7caa1c67680210.zip | |
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
Diffstat (limited to 'engine/items')
| -rw-r--r-- | engine/items/item_effects.asm | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm index 9643412c..6c87bde0 100644 --- a/engine/items/item_effects.asm +++ b/engine/items/item_effects.asm @@ -468,7 +468,7 @@ ItemUseBall: push hl -; If the Pokémon is transformed, the Pokémon is assumed to be a Ditto. +; Bug: If the Pokémon is transformed, the Pokémon is assumed to be a Ditto. ; This is a bug because a wild Pokémon could have used Transform via ; Mirror Move even though the only wild Pokémon that knows Transform is Ditto. ld hl, wEnemyBattleStatus3 @@ -774,7 +774,7 @@ ItemUseEvoStone: jr c, .canceledItemUse ld a, b ld [wCurPartySpecies], a - ld a, $01 + ld a, TRUE ld [wForceEvolution], a ld a, SFX_HEAL_AILMENT call PlaySoundWaitForCurrent @@ -2077,10 +2077,10 @@ ItemUsePPRestore: ret .fullyRestorePP ld a, [hl] ; move PP -; Note that this code has a bug. It doesn't mask out the upper two bits, which -; are used to count how many PP Ups have been used on the move. So, Max Ethers -; and Max Elixirs will not be detected as having no effect on a move with full -; PP if the move has had any PP Ups used on it. +; Bug: This code doesn't mask out the upper two bits, which are used to count +; how many PP Ups have been used on the move. +; So, Max Ethers and Max Elixirs will not be detected as having no effect on +; a move with full PP if the move has had any PP Ups used on it. cp b ; does current PP equal max PP? ret z jr .storeNewAmount |