aboutsummaryrefslogtreecommitdiffstats
path: root/engine/movie
diff options
context:
space:
mode:
authordannye <33dannye@gmail.com>2025-09-06 16:54:17 -0500
committerdannye <33dannye@gmail.com>2025-09-06 16:54:17 -0500
commit377749ca4efac05b6c57dfed049899891af6c35a (patch)
tree4b429403935c4a7c2de710a6cbf7310246874539 /engine/movie
parentFix .tilemap file extension, fix some typos (#138) (diff)
parentDocument visual glitch with Pewter City Gym guy (#526) (diff)
downloadpokeyellow-377749ca4efac05b6c57dfed049899891af6c35a.tar.gz
pokeyellow-377749ca4efac05b6c57dfed049899891af6c35a.tar.xz
pokeyellow-377749ca4efac05b6c57dfed049899891af6c35a.zip
Merge branch 'master' of https://github.com/pret/pokered
Diffstat (limited to 'engine/movie')
-rw-r--r--engine/movie/hall_of_fame.asm2
-rw-r--r--engine/movie/oak_speech/clear_save.asm2
-rw-r--r--engine/movie/title.asm2
-rw-r--r--engine/movie/trade.asm12
4 files changed, 8 insertions, 10 deletions
diff --git a/engine/movie/hall_of_fame.asm b/engine/movie/hall_of_fame.asm
index 025d6a03..38d937f6 100644
--- a/engine/movie/hall_of_fame.asm
+++ b/engine/movie/hall_of_fame.asm
@@ -7,7 +7,7 @@ AnimateHallOfFame:
call LoadTextBoxTilePatterns
call DisableLCD
ld hl, vBGMap0
- ld bc, $800
+ ld bc, 2 * TILEMAP_AREA
ld a, " "
call FillMemory
call EnableLCD
diff --git a/engine/movie/oak_speech/clear_save.asm b/engine/movie/oak_speech/clear_save.asm
index 4df2faa4..f44a12b9 100644
--- a/engine/movie/oak_speech/clear_save.asm
+++ b/engine/movie/oak_speech/clear_save.asm
@@ -19,7 +19,7 @@ DoClearSaveDialogue:
ld a, [wCurrentMenuItem]
and a
jp z, Init
- farcall ClearSAV
+ farcall ClearAllSRAMBanks
jp Init
ClearSaveDataText:
diff --git a/engine/movie/title.asm b/engine/movie/title.asm
index 7a4637ec..495c8cfe 100644
--- a/engine/movie/title.asm
+++ b/engine/movie/title.asm
@@ -240,7 +240,6 @@ ENDC
.doClearSaveDialogue
farjp DoClearSaveDialogue
-
TitleScreenCopyTileMapToVRAM:
ldh [hAutoBGTransferDest + 1], a
jp Delay3
@@ -283,7 +282,6 @@ DoTitleScreenFunction:
ld l, a
jp hl
-
.Jumptable:
dw .Nop
dw .BlinkHalf
diff --git a/engine/movie/trade.asm b/engine/movie/trade.asm
index 2cb51d98..852af717 100644
--- a/engine/movie/trade.asm
+++ b/engine/movie/trade.asm
@@ -168,7 +168,7 @@ LoadTradingGFXAndMonNames:
ld a, BANK(TradingAnimationGraphics2)
call FarCopyData
ld hl, vBGMap0
- ld bc, $800
+ ld bc, 2 * TILEMAP_AREA
ld a, " "
call FillMemory
call ClearSprites
@@ -226,7 +226,7 @@ Trade_Cleanup:
ret
Trade_ShowPlayerMon:
- ld a, %10101011
+ ld a, LCDC_ON | LCDC_WIN_9800 | LCDC_WIN_ON | LCDC_BLOCK21 | LCDC_BG_9C00 | LCDC_OBJ_8 | LCDC_OBJ_ON | LCDC_BG_ON
ldh [rLCDC], a
ld a, $50
ldh [hWY], a
@@ -281,7 +281,7 @@ Trade_DrawOpenEndOfLinkCable:
ld a, $a0
ldh [hSCX], a
call DelayFrame
- ld a, %10001011
+ ld a, LCDC_ON | LCDC_WIN_9800 | LCDC_WIN_OFF | LCDC_BLOCK21 | LCDC_BG_9C00 | LCDC_OBJ_8 | LCDC_OBJ_ON | LCDC_BG_ON
ldh [rLCDC], a
hlcoord 6, 2
ld b, TILEMAP_LINK_CABLE
@@ -341,7 +341,7 @@ Trade_AnimateBallEnteringLinkCable:
ld a, $1
ldh [hAutoBGTransferEnabled], a
call ClearScreen
- ld b, $98
+ ld b, HIGH(vBGMap0)
call CopyScreenTileBufferToVRAM
call Delay3
xor a
@@ -457,7 +457,7 @@ Trade_InitGameboyTransferGfx:
ldh [hAutoBGTransferEnabled], a
call Trade_LoadMonPartySpriteGfx
call DelayFrame
- ld a, %10101011
+ ld a, LCDC_ON | LCDC_WIN_9800 | LCDC_WIN_ON | LCDC_BLOCK21 | LCDC_BG_9C00 | LCDC_OBJ_8 | LCDC_OBJ_ON | LCDC_BG_ON
ldh [rLCDC], a
xor a
ldh [hSCX], a
@@ -761,7 +761,7 @@ Trade_ShowClearedWindow:
ld a, $1
ldh [hAutoBGTransferEnabled], a
call ClearScreen
- ld a, %11100011
+ ld a, LCDC_DEFAULT
ldh [rLCDC], a
ld a, $7
ldh [rWX], a