aboutsummaryrefslogtreecommitdiffstats
path: root/engine/pokemon
diff options
context:
space:
mode:
authorSylvie <35663410+Rangi42@users.noreply.github.com>2024-09-18 21:41:58 -0400
committerGitHub <noreply@github.com>2024-09-18 21:41:58 -0400
commit5a622f628de6908210091a05956b0d8ce3620237 (patch)
tree9cc32420b50f09531c58f4c5019ef167e133b95c /engine/pokemon
parentSplit `hSpriteIndexOrTextID` into `hSpriteIndex` and `hTextID` (#462) (diff)
downloadpokeyellow-5a622f628de6908210091a05956b0d8ce3620237.tar.gz
pokeyellow-5a622f628de6908210091a05956b0d8ce3620237.tar.xz
pokeyellow-5a622f628de6908210091a05956b0d8ce3620237.zip
Identify remaining uses of `wd0b5` and `wd11e` (#463)
Diffstat (limited to 'engine/pokemon')
-rw-r--r--engine/pokemon/add_mon.asm12
-rw-r--r--engine/pokemon/evos_moves.asm33
-rw-r--r--engine/pokemon/experience.asm2
-rw-r--r--engine/pokemon/learn_move.asm2
-rw-r--r--engine/pokemon/load_mon_data.asm2
-rw-r--r--engine/pokemon/set_types.asm6
-rw-r--r--engine/pokemon/status_screen.asm8
7 files changed, 33 insertions, 32 deletions
diff --git a/engine/pokemon/add_mon.asm b/engine/pokemon/add_mon.asm
index ab167a24..7eaca222 100644
--- a/engine/pokemon/add_mon.asm
+++ b/engine/pokemon/add_mon.asm
@@ -65,7 +65,7 @@ _AddPartyMon::
ld d, h
push hl
ld a, [wCurPartySpecies]
- ld [wd0b5], a
+ ld [wCurSpecies], a
call GetMonHeader
ld hl, wMonHeader
ld a, [hli]
@@ -81,11 +81,11 @@ _AddPartyMon::
; If the mon is being added to the player's party, update the pokedex.
ld a, [wCurPartySpecies]
- ld [wd11e], a
+ ld [wPokedexNum], a
push de
predef IndexToPokedex
pop de
- ld a, [wd11e]
+ ld a, [wPokedexNum]
dec a
ld c, a
ld b, FLAG_TEST
@@ -93,7 +93,7 @@ _AddPartyMon::
call FlagAction
ld a, c ; whether the mon was already flagged as owned
ld [wUnusedAlreadyOwnedFlag], a
- ld a, [wd11e]
+ ld a, [wPokedexNum]
dec a
ld c, a
ld b, FLAG_SET
@@ -323,9 +323,9 @@ _AddEnemyMonToPlayerParty::
ld bc, NAME_LENGTH
call CopyData ; write new mon's nickname (from an enemy mon)
ld a, [wCurPartySpecies]
- ld [wd11e], a
+ ld [wPokedexNum], a
predef IndexToPokedex
- ld a, [wd11e]
+ ld a, [wPokedexNum]
dec a
ld c, a
ld b, FLAG_SET
diff --git a/engine/pokemon/evos_moves.asm b/engine/pokemon/evos_moves.asm
index aae6cb87..268e522a 100644
--- a/engine/pokemon/evos_moves.asm
+++ b/engine/pokemon/evos_moves.asm
@@ -135,7 +135,7 @@ Evolution_PartyMonLoop: ; loop over party mons
call PrintText
pop hl
ld a, [hl]
- ld [wd0b5], a
+ ld [wCurSpecies], a
ld [wLoadedMonSpecies], a
ld [wEvoNewSpecies], a
ld a, MONSTER_NAME
@@ -153,22 +153,22 @@ Evolution_PartyMonLoop: ; loop over party mons
call DelayFrames
call ClearScreen
call RenameEvolvedMon
- ld a, [wd11e]
+ ld a, [wPokedexNum]
push af
- ld a, [wd0b5]
- ld [wd11e], a
+ ld a, [wCurSpecies]
+ ld [wPokedexNum], a
predef IndexToPokedex
- ld a, [wd11e]
+ ld a, [wPokedexNum]
dec a
ld hl, BaseStats
ld bc, BASE_DATA_SIZE
call AddNTimes
ld de, wMonHeader
call CopyData
- ld a, [wd0b5]
+ ld a, [wCurSpecies]
ld [wMonHIndex], a
pop af
- ld [wd11e], a
+ ld [wPokedexNum], a
ld hl, wLoadedMonHPExp - 1
ld de, wLoadedMonStats
ld b, $1
@@ -203,8 +203,8 @@ Evolution_PartyMonLoop: ; loop over party mons
dec hl
pop bc
call CopyData
- ld a, [wd0b5]
- ld [wd11e], a
+ ld a, [wCurSpecies]
+ ld [wPokedexNum], a
xor a
ld [wMonDataLocation], a
call LearnMoveFromLevelUp
@@ -214,7 +214,7 @@ Evolution_PartyMonLoop: ; loop over party mons
and a
call z, Evolution_ReloadTilesetTilePatterns
predef IndexToPokedex
- ld a, [wd11e]
+ ld a, [wPokedexNum]
dec a
ld c, a
ld b, FLAG_SET
@@ -260,13 +260,14 @@ Evolution_PartyMonLoop: ; loop over party mons
RenameEvolvedMon:
; Renames the mon to its new, evolved form's standard name unless it had a
; nickname, in which case the nickname is kept.
- ld a, [wd0b5]
+ assert wCurSpecies == wNameListIndex ; save+restore wCurSpecies while using wNameListIndex
+ ld a, [wCurSpecies]
push af
ld a, [wMonHIndex]
- ld [wd0b5], a
+ ld [wNameListIndex], a
call GetName
pop af
- ld [wd0b5], a
+ ld [wCurSpecies], a
ld hl, wNameBuffer
ld de, wStringBuffer
.compareNamesLoop
@@ -319,7 +320,7 @@ Evolution_ReloadTilesetTilePatterns:
LearnMoveFromLevelUp:
ld hl, EvosMovesPointerTable
- ld a, [wd11e] ; species
+ ld a, [wPokedexNum] ; species
ld [wCurPartySpecies], a
dec a
ld bc, 0
@@ -366,13 +367,13 @@ LearnMoveFromLevelUp:
jr nz, .checkCurrentMovesLoop
ld a, d
ld [wMoveNum], a
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMoveName
call CopyToStringBuffer
predef LearnMove
.done
ld a, [wCurPartySpecies]
- ld [wd11e], a
+ ld [wPokedexNum], a
ret
; writes the moves a mon has at level [wCurEnemyLevel] to [de]
diff --git a/engine/pokemon/experience.asm b/engine/pokemon/experience.asm
index 427d2a7f..d651321a 100644
--- a/engine/pokemon/experience.asm
+++ b/engine/pokemon/experience.asm
@@ -1,7 +1,7 @@
; calculates the level a mon should be based on its current exp
CalcLevelFromExperience::
ld a, [wLoadedMonSpecies]
- ld [wd0b5], a
+ ld [wCurSpecies], a
call GetMonHeader
ld d, $1 ; init level to 1
.loop
diff --git a/engine/pokemon/learn_move.asm b/engine/pokemon/learn_move.asm
index 981fe13a..2df9964e 100644
--- a/engine/pokemon/learn_move.asm
+++ b/engine/pokemon/learn_move.asm
@@ -29,7 +29,7 @@ DontAbandonLearning:
jp c, AbandonLearning
push hl
push de
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMoveName
ld hl, OneTwoAndText
call PrintText
diff --git a/engine/pokemon/load_mon_data.asm b/engine/pokemon/load_mon_data.asm
index 3d0548e0..7a39f083 100644
--- a/engine/pokemon/load_mon_data.asm
+++ b/engine/pokemon/load_mon_data.asm
@@ -19,7 +19,7 @@ LoadMonData_::
.GetMonHeader
ld a, [wCurPartySpecies]
- ld [wd0b5], a ; input for GetMonHeader
+ ld [wCurSpecies], a
call GetMonHeader
ld hl, wPartyMons
diff --git a/engine/pokemon/set_types.asm b/engine/pokemon/set_types.asm
index e9235f13..2cf8f14c 100644
--- a/engine/pokemon/set_types.asm
+++ b/engine/pokemon/set_types.asm
@@ -1,10 +1,10 @@
-; updates the types of a party mon (pointed to in hl) to the ones of the mon specified in wd11e
+; updates the types of a party mon (pointed to in hl) to the ones of the mon specified in [wPokedexNum]
SetPartyMonTypes:
call GetPredefRegisters
ld bc, wPartyMon1Type - wPartyMon1 ; $5
add hl, bc
- ld a, [wd11e]
- ld [wd0b5], a
+ ld a, [wPokedexNum]
+ ld [wCurSpecies], a
push hl
call GetMonHeader
pop hl
diff --git a/engine/pokemon/status_screen.asm b/engine/pokemon/status_screen.asm
index 4ae4327a..8d377f79 100644
--- a/engine/pokemon/status_screen.asm
+++ b/engine/pokemon/status_screen.asm
@@ -139,11 +139,11 @@ StatusScreen:
hlcoord 14, 2
call PrintLevel ; Pokémon level
ld a, [wMonHIndex]
- ld [wd11e], a
- ld [wd0b5], a
+ ld [wPokedexNum], a
+ ld [wCurSpecies], a
predef IndexToPokedex
hlcoord 3, 7
- ld de, wd11e
+ ld de, wPokedexNum
lb bc, LEADING_ZEROES | 1, 3
call PrintNumber ; Pokémon no.
hlcoord 11, 10
@@ -420,7 +420,7 @@ StatusScreen2:
hlcoord 9, 1
call StatusScreen_ClearName
ld a, [wMonHIndex]
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMonName
hlcoord 9, 1
call PlaceString