aboutsummaryrefslogtreecommitdiffstats
path: root/engine
diff options
context:
space:
mode:
authorRangi <sylvie.oukaour+rangi42@gmail.com>2025-09-26 16:55:23 -0400
committerRangi <sylvie.oukaour+rangi42@gmail.com>2025-09-26 16:55:23 -0400
commit628797baffe7ea7dd4b224116d9704c7ae1b9c29 (patch)
treec018e77ef1f05cf777f3349f04165a1c78d2dc3d /engine
parentClean up home/copy2.asm (#531) (diff)
downloadpokeyellow-628797baffe7ea7dd4b224116d9704c7ae1b9c29.tar.gz
pokeyellow-628797baffe7ea7dd4b224116d9704c7ae1b9c29.tar.xz
pokeyellow-628797baffe7ea7dd4b224116d9704c7ae1b9c29.zip
Revise some RAM buffer constants
Diffstat (limited to 'engine')
-rw-r--r--engine/items/item_effects.asm4
-rw-r--r--engine/menus/party_menu.asm2
-rw-r--r--engine/overworld/wild_mons.asm6
3 files changed, 6 insertions, 6 deletions
diff --git a/engine/items/item_effects.asm b/engine/items/item_effects.asm
index 8a96c517..1b68e47a 100644
--- a/engine/items/item_effects.asm
+++ b/engine/items/item_effects.asm
@@ -2195,7 +2195,7 @@ ItemUseTMHM:
.chooseMon
ld hl, wStringBuffer
ld de, wTempMoveNameBuffer
- ld bc, 14
+ ld bc, ITEM_NAME_LENGTH + 1
call CopyData ; save the move name because DisplayPartyMenu will overwrite it
ld a, $ff
ld [wUpdateSpritesEnabled], a
@@ -2205,7 +2205,7 @@ ItemUseTMHM:
push af
ld hl, wTempMoveNameBuffer
ld de, wStringBuffer
- ld bc, 14
+ ld bc, ITEM_NAME_LENGTH + 1
call CopyData
pop af
jr nc, .checkIfAbleToLearnMove
diff --git a/engine/menus/party_menu.asm b/engine/menus/party_menu.asm
index e6388b5f..81472c31 100644
--- a/engine/menus/party_menu.asm
+++ b/engine/menus/party_menu.asm
@@ -131,7 +131,7 @@ RedrawPartyMenu_::
ld l, a
ld de, wEvoDataBuffer
ld a, BANK(EvosMovesPointerTable)
- ld bc, 4 * 3 + 1 ; enough for Eevee's three 4-byte evolutions and 0 terminator
+ ld bc, wEvoDataBufferEnd - wEvoDataBuffer
call FarCopyData
ld hl, wEvoDataBuffer
ld de, .notAbleToEvolveText
diff --git a/engine/overworld/wild_mons.asm b/engine/overworld/wild_mons.asm
index 2593e0ec..2b186e75 100644
--- a/engine/overworld/wild_mons.asm
+++ b/engine/overworld/wild_mons.asm
@@ -16,10 +16,10 @@ LoadWildData::
jr z, .NoGrassData ; if no grass data, skip to surfing data
push hl
ld de, wGrassMons ; otherwise, load grass data
- ld bc, $14
+ ld bc, WILDDATA_LENGTH - 1
call CopyData
pop hl
- ld bc, $14
+ ld bc, WILDDATA_LENGTH - 1
add hl, bc
.NoGrassData
ld a, [hli]
@@ -27,7 +27,7 @@ LoadWildData::
and a
ret z ; if no water data, we're done
ld de, wWaterMons ; otherwise, load surfing data
- ld bc, $14
+ ld bc, WILDDATA_LENGTH - 1
jp CopyData
INCLUDE "data/wild/grass_water.asm"