aboutsummaryrefslogtreecommitdiffstats
path: root/home
diff options
context:
space:
mode:
authorRangi <35663410+Rangi42@users.noreply.github.com>2025-01-28 23:31:15 -0500
committerGitHub <noreply@github.com>2025-01-28 23:31:15 -0500
commitafb899016938d03911eaafb85c7caa1c67680210 (patch)
tree26e5d73301ab16e060c4a16171e0a5aa3c47d732 /home
parentComment on size of union (diff)
downloadpokeyellow-afb899016938d03911eaafb85c7caa1c67680210.tar.gz
pokeyellow-afb899016938d03911eaafb85c7caa1c67680210.tar.xz
pokeyellow-afb899016938d03911eaafb85c7caa1c67680210.zip
Miscellaneous cleanup (#488)
Co-authored-by: SatoMew <SatoMew@users.noreply.github.com>
Diffstat (limited to 'home')
-rw-r--r--home/pokemon.asm6
-rw-r--r--home/text.asm2
-rw-r--r--home/yes_no.asm2
3 files changed, 7 insertions, 3 deletions
diff --git a/home/pokemon.asm b/home/pokemon.asm
index 7cc5f2d1..afa0d129 100644
--- a/home/pokemon.asm
+++ b/home/pokemon.asm
@@ -114,7 +114,11 @@ LoadFrontSpriteByMonIndex::
cp NUM_POKEMON + 1
jr c, .validDexNumber ; dex >#151 invalid
.invalidDexNumber
- ld a, RHYDON ; $1
+ ; This is the so-called "Rhydon trap" or "Rhydon glitch"
+ ; to fail-safe invalid dex numbers
+ ; (see https://glitchcity.wiki/wiki/Rhydon_trap
+ ; or https://bulbapedia.bulbagarden.net/wiki/Rhydon_glitch)
+ ld a, RHYDON
ld [wCurPartySpecies], a
ret
.validDexNumber
diff --git a/home/text.asm b/home/text.asm
index da884125..112956da 100644
--- a/home/text.asm
+++ b/home/text.asm
@@ -111,7 +111,7 @@ NextChar::
inc de
jp PlaceNextChar
-NullChar:: ; unused
+NullChar::
ld b, h
ld c, l
pop hl
diff --git a/home/yes_no.asm b/home/yes_no.asm
index 3f5a5a45..8d995832 100644
--- a/home/yes_no.asm
+++ b/home/yes_no.asm
@@ -26,7 +26,7 @@ YesNoChoicePokeCenter::
lb bc, 8, 12
jr DisplayYesNoChoice
-WideYesNoChoice:: ; unused
+WideYesNoChoice:: ; unreferenced
call SaveScreenTilesToBuffer1
ld a, WIDE_YES_NO_MENU
ld [wTwoOptionMenuID], a