diff options
| author | vulcandth <vulcandth@gmail.com> | 2023-07-13 20:27:56 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-13 21:27:56 -0400 |
| commit | d001ced41b53271373753de835a9c3b3413dc318 (patch) | |
| tree | ff2db7f403bddfcdeb12e50def8411cafedcdd5e /scripts/HallOfFame.asm | |
| parent | Make wCurrentBoxNum a byte instead of word (#414) (diff) | |
| download | pokeyellow-d001ced41b53271373753de835a9c3b3413dc318.tar.gz pokeyellow-d001ced41b53271373753de835a9c3b3413dc318.tar.xz pokeyellow-d001ced41b53271373753de835a9c3b3413dc318.zip | |
Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
Diffstat (limited to 'scripts/HallOfFame.asm')
| -rw-r--r-- | scripts/HallOfFame.asm | 38 |
1 files changed, 20 insertions, 18 deletions
diff --git a/scripts/HallOfFame.asm b/scripts/HallOfFame.asm index 45cef29c..9fc7da18 100644 --- a/scripts/HallOfFame.asm +++ b/scripts/HallOfFame.asm @@ -11,15 +11,16 @@ HallofFameRoomScript_5a4aa: ret HallOfFame_ScriptPointers: - dw HallofFameRoomScript0 - dw HallofFameRoomScript1 - dw HallofFameRoomScript2 - dw HallofFameRoomScript3 + def_script_pointers + dw_const HallOfFameDefaultScript, SCRIPT_HALLOFFAME_DEFAULT + dw_const HallOfFameOakCongratulationsScript, SCRIPT_HALLOFFAME_OAK_CONGRATULATIONS + dw_const HallOfFameResetEventsAndSaveScript, SCRIPT_HALLOFFAME_RESET_EVENTS_AND_SAVE + dw_const HallOfFameNoopScript, SCRIPT_HALLOFFAME_NOOP -HallofFameRoomScript3: +HallOfFameNoopScript: ret -HallofFameRoomScript2: +HallOfFameResetEventsAndSaveScript: call Delay3 ld a, [wLetterPrintingDelayFlags] push af @@ -32,7 +33,7 @@ HallofFameRoomScript2: res 1, [hl] inc hl set 0, [hl] - xor a + xor a ; SCRIPT_*_DEFAULT ld hl, wLoreleisRoomCurScript ld [hli], a ; wLoreleisRoomCurScript ld [hli], a ; wBrunosRoomCurScript @@ -55,8 +56,8 @@ HallofFameRoomScript2: call WaitForTextScrollButtonPress jp Init -HallofFameRoomScript0: - ld a, $ff +HallOfFameDefaultScript: + ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN ld [wJoyIgnore], a ld hl, wSimulatedJoypadStatesEnd ld de, RLEMovement5a528 @@ -64,7 +65,7 @@ HallofFameRoomScript0: dec a ld [wSimulatedJoypadStatesIndex], a call StartSimulatingJoypadStates - ld a, $1 + ld a, SCRIPT_HALLOFFAME_OAK_CONGRATULATIONS ld [wHallOfFameCurScript], a ret @@ -72,13 +73,13 @@ RLEMovement5a528: db D_UP, 5 db -1 ; end -HallofFameRoomScript1: +HallOfFameOakCongratulationsScript: ld a, [wSimulatedJoypadStatesIndex] and a ret nz ld a, PLAYER_DIR_RIGHT ld [wPlayerMovingDirection], a - ld a, $1 + ld a, HALLOFFAME_OAK ldh [hSpriteIndex], a call SetSpriteMovementBytesToFF ld a, SPRITE_FACING_LEFT @@ -89,21 +90,22 @@ HallofFameRoomScript1: ld [wJoyIgnore], a inc a ; PLAYER_DIR_RIGHT ld [wPlayerMovingDirection], a - ld a, $1 + ld a, TEXT_HALLOFFAME_OAK ldh [hSpriteIndexOrTextID], a call DisplayTextID - ld a, $ff + ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN ld [wJoyIgnore], a ld a, HS_CERULEAN_CAVE_GUY ld [wMissableObjectIndex], a predef HideObject - ld a, $2 + ld a, SCRIPT_HALLOFFAME_RESET_EVENTS_AND_SAVE ld [wHallOfFameCurScript], a ret HallOfFame_TextPointers: - dw HallofFameRoomText1 + def_text_pointers + dw_const HallOfFameOakText, TEXT_HALLOFFAME_OAK -HallofFameRoomText1: - text_far _HallofFameRoomText1 +HallOfFameOakText: + text_far _HallOfFameOakText text_end |