Allow toggling pane frames for specific panes (#4615)

* initial implementation

* add borderless to edit and plugin cli commands

* allow changing existing pane to borderless

* allow setting in layouts and keybindings

* get to work through the existing plugin api commands

* fix when applying (swap) layouts

* fix tests

* allow setting pane as bordered (borderful?) when changing its coordinates (eg. through the cli)

* allow explicitly setting a pane as bordered or borderless without toggling

* rustfmt

* adjust snapshots

* docs(changelog): add PR

3 files changed, 4 insertions, 0 deletions

diff --git a/default-plugins/sequence/src/main.rs b/default-plugins/sequence/src/main.rs
index 0ac286d9..4631caa2 100644
--- a/default-plugins/sequence/src/main.rs
+++ b/default-plugins/sequence/src/main.rs
@@ -881,6 +881,7 @@ fn change_floating_pane_coordinates(
         width.map(|width| format!("{}%", width)),
         height.map(|height| format!("{}%", height)),
         Some(should_be_pinned),
+        Some(false),
     );
     if let Some(coordinates) = coordinates {
         // TODO: better
diff --git a/default-plugins/sequence/src/state/mod.rs b/default-plugins/sequence/src/state/mod.rs
index 19738be7..e3fbf3ff 100644
--- a/default-plugins/sequence/src/state/mod.rs
+++ b/default-plugins/sequence/src/state/mod.rs
@@ -354,6 +354,7 @@ impl State {
                 Some(format!("50%")),
                 Some(format!("{}", initial_height)),
                 Some(false), // should not be pinned when running sequence
+                Some(false),
             );
             coordinates.map(|coordinates| {
                 if Some(&coordinates) != self.current_position.as_ref() {
@@ -403,6 +404,7 @@ impl State {
                 Some(width.to_string()),
                 Some(height.to_string()),
                 Some(true), // should be pinned for sequence
+                Some(false),
             );
             coordinates.map(|coordinates| {
                 if Some(&coordinates) != self.current_position.as_ref() {
diff --git a/default-plugins/sequence/src/state/positioning.rs b/default-plugins/sequence/src/state/positioning.rs
index 6acadfff..b724df62 100644
--- a/default-plugins/sequence/src/state/positioning.rs
+++ b/default-plugins/sequence/src/state/positioning.rs
@@ -41,6 +41,7 @@ pub fn change_floating_pane_coordinates_absolute(
         width.map(|width| width.to_string()),
         height.map(|height| height.to_string()),
         Some(should_be_pinned),
+        Some(false),
     );
     if let Some(coordinates) = coordinates {
         change_floating_panes_coordinates(vec![(PaneId::Plugin(own_plugin_id), coordinates)]);