diff options
| author | raphCode <15750438+raphCode@users.noreply.github.com> | 2022-05-24 14:10:37 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-24 14:10:37 +0200 |
| commit | eab464b11adb28e504cefdc39b596d5e5787a2bb (patch) | |
| tree | 5c10a63ecbd7db2c9baf1fc292f052d3e4b6ea3e /default-plugins | |
| parent | docs(changelog): checking for missing extensions (diff) | |
| download | sl0ppij-eab464b11adb28e504cefdc39b596d5e5787a2bb.tar.gz sl0ppij-eab464b11adb28e504cefdc39b596d5e5787a2bb.tar.xz sl0ppij-eab464b11adb28e504cefdc39b596d5e5787a2bb.zip | |
Fix double panic lockup in clients panic handler (#1433)
* Fix possible lockup in the clients panic handler
When the pty the client was running in disappears, reading from stdin
causes a panic, which triggers the custom panic handler. This handler
attempts to print a backtrace to the terminal and tries to unset the raw
mode for that. Since the pty has already disappeared, the tcsetattr call
fails and causes a second panic, which locks everything up.
This commit fixes this by returning an Result from the unset_raw_mode
function, allowing the calling panic handler to handle any error
gracefully.
* Log any client panics to file
Since we are now aware of the fact that panics may happen / are handled
after the pty has disappeared, logging them to file seems useful: there
is no other other place to show them to the user.
* fix tests and improve function return type
Diffstat (limited to 'default-plugins')
0 files changed, 0 insertions, 0 deletions
