aboutsummaryrefslogtreecommitdiffstats
path: root/src/client/panes
diff options
context:
space:
mode:
authorBrooks J Rady <b.j.rady@gmail.com>2021-03-25 14:24:11 +0000
committerBrooks J Rady <b.j.rady@gmail.com>2021-03-25 14:24:11 +0000
commitf2f77583848bce219fc098508fffde30fa366b89 (patch)
tree391ac6129ddcc6ea0fe760dd206abaa97bde3b35 /src/client/panes
parentRemove a dead input enum variant (diff)
parentfix(render): various rendering issues (#238) (diff)
downloadsl0ppij-f2f77583848bce219fc098508fffde30fa366b89.tar.gz
sl0ppij-f2f77583848bce219fc098508fffde30fa366b89.tar.xz
sl0ppij-f2f77583848bce219fc098508fffde30fa366b89.zip
Merge in changes from main and fix clippy lints
Diffstat (limited to 'src/client/panes')
-rw-r--r--src/client/panes/terminal_pane.rs9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/client/panes/terminal_pane.rs b/src/client/panes/terminal_pane.rs
index 9fa70d11..f0b15e50 100644
--- a/src/client/panes/terminal_pane.rs
+++ b/src/client/panes/terminal_pane.rs
@@ -188,7 +188,14 @@ impl Pane for TerminalPane {
self.max_height
}
fn render(&mut self) -> Option<String> {
- if self.should_render || cfg!(test) {
+ // FIXME:
+ // the below conditional is commented out because it causes several bugs:
+ // 1. When panes are resized or tabs are switched the previous contents of the screen stick
+ // around
+ // 2. When there are wide characters in a pane, since we don't yet handle them properly,
+ // the spill over to the pane to the right
+ // if self.should_render || cfg!(test) {
+ if true {
let mut vte_output = String::new();
let buffer_lines = &self.read_buffer_as_lines();
let display_cols = self.get_columns();