fix(threads): a race condition, build-times, and warnings (#79)

* Fix a race condition, build-times, and warnings

* Yeah, yeah... I know

* style(code): add comment to explain race condition

Co-authored-by: Aram Drevekenin <aram@poor.dev>

1 files changed, 8 insertions, 2 deletions

diff --git a/src/screen.rs b/src/screen.rs
index 53655216..56bb82d2 100644
--- a/src/screen.rs
+++ b/src/screen.rs
@@ -380,8 +380,14 @@ impl Screen {
         }
     }
     pub fn handle_pty_event(&mut self, pid: RawFd, event: VteEvent) {
-        let terminal_output = self.terminals.get_mut(&pid).unwrap();
-        terminal_output.handle_event(event);
+        // if we don't have the terminal in self.terminals it's probably because
+        // of a race condition where the terminal was created in pty_bus but has not
+        // yet been created in Screen. These events are currently not buffered, so
+        // if you're debugging seemingly randomly missing stdout data, this is
+        // the reason
+        if let Some(terminal_output) = self.terminals.get_mut(&pid) {
+            terminal_output.handle_event(event);
+        }
     }
     pub fn write_to_active_terminal(&mut self, mut bytes: Vec<u8>) {
         if let Some(active_terminal_id) = &self.get_active_terminal_id() {