chore(infra): added clippy check. (#65)

* Added clippy check.

* Changed step name.

* Used the suggested ci config.

* Some more clippy fixes.

* Some more clippy fixes.

* More clippy fixes.

* Removed allow annotations.

* Minor lint edit.

* More clippy fixes.

* Ran cargo fmt.

* More clippy fixes.

* More clippy fixes.

* More clippy fixes.

* More clippy fixes.

* More clippy fixes.

* More clippy fixes.

* Code review edits.

* Code review edits.

* Code review edits.

* CI update.

* CI update.

* CI update.

* Added clippy warn so wip won't fail ci.

* Cargo fmt.

1 files changed, 13 insertions, 15 deletions

diff --git a/src/utils/logging.rs b/src/utils/logging.rs
index 4bd53743..1af1cb06 100644
--- a/src/utils/logging.rs
+++ b/src/utils/logging.rs
@@ -30,33 +30,33 @@ pub fn debug_log_to_file(message: String) -> io::Result<()> {
         .create(true)
         .open(MOSAIC_TMP_LOG_FILE)?;
     file.write_all(message.as_bytes())?;
-    file.write_all("\n".as_bytes())?;
-
-    Ok(())
+    file.write_all(b"\n")
 }
 
 pub fn debug_log_to_file_pid_0(message: String, pid: RawFd) -> io::Result<()> {
     if pid == 0 {
-        debug_log_to_file(message)?;
+        debug_log_to_file(message)
+    } else {
+        Ok(())
     }
-
-    Ok(())
 }
 
+#[allow(dead_code)]
 pub fn delete_log_file() -> io::Result<()> {
     if fs::metadata(MOSAIC_TMP_LOG_FILE).is_ok() {
-        fs::remove_file(MOSAIC_TMP_LOG_FILE)?;
+        fs::remove_file(MOSAIC_TMP_LOG_FILE)
+    } else {
+        Ok(())
     }
-
-    Ok(())
 }
 
+#[allow(dead_code)]
 pub fn delete_log_dir() -> io::Result<()> {
     if fs::metadata(MOSAIC_TMP_LOG_DIR).is_ok() {
-        fs::remove_dir_all(MOSAIC_TMP_LOG_DIR)?;
+        fs::remove_dir_all(MOSAIC_TMP_LOG_DIR)
+    } else {
+        Ok(())
     }
-
-    Ok(())
 }
 
 pub fn debug_to_file(message: u8, pid: RawFd) -> io::Result<()> {
@@ -68,7 +68,5 @@ pub fn debug_to_file(message: u8, pid: RawFd) -> io::Result<()> {
         .append(true)
         .create(true)
         .open(path)?;
-    file.write_all(&[message])?;
-
-    Ok(())
+    file.write_all(&[message])
 }