diff options
| author | Aram Drevekenin <aram@poor.dev> | 2026-01-20 17:11:26 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-01-20 17:11:26 +0100 |
| commit | 432c6d749121bc2d8fa3361b59c5d14cbd82a0e0 (patch) | |
| tree | ca8f61fa7ed151681d5f3220bdf91a100139306c /zellij-server/src/plugins | |
| parent | Allow toggling pane frames for specific panes (#4615) (diff) | |
| download | sl0ppij-432c6d749121bc2d8fa3361b59c5d14cbd82a0e0.tar.gz sl0ppij-432c6d749121bc2d8fa3361b59c5d14cbd82a0e0.tar.xz sl0ppij-432c6d749121bc2d8fa3361b59c5d14cbd82a0e0.zip | |
Fix tiled new pane borderless (#4618)
* allow opening tiled pane as borderless
* rustfmt
* add pr
* fix e2e tests
Diffstat (limited to 'zellij-server/src/plugins')
6 files changed, 29 insertions, 15 deletions
diff --git a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_background_plugin_command.snap b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_background_plugin_command.snap index 37624741..7c6f1dc1 100644 --- a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_background_plugin_command.snap +++ b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_background_plugin_command.snap @@ -29,7 +29,9 @@ Some( ), ), None, - NoPreference, + NoPreference { + borderless: None, + }, true, ClientId( 1, diff --git a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_plugin_command.snap b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_plugin_command.snap index 596700c5..371851ab 100644 --- a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_plugin_command.snap +++ b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_command_pane_plugin_command.snap @@ -27,9 +27,10 @@ Some( ), ), None, - Tiled( - None, - ), + Tiled { + direction: None, + borderless: None, + }, false, ClientId( 1, diff --git a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_plugin_command.snap b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_plugin_command.snap index b899e596..f16526d0 100644 --- a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_plugin_command.snap +++ b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_plugin_command.snap @@ -25,9 +25,10 @@ Some( Some( "Editing: /path/to/my/file.rs", ), - Tiled( - None, - ), + Tiled { + direction: None, + borderless: None, + }, false, ClientId( 1, diff --git a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_with_line_plugin_command.snap b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_with_line_plugin_command.snap index 4d2689db..59970eee 100644 --- a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_with_line_plugin_command.snap +++ b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_file_with_line_plugin_command.snap @@ -27,9 +27,10 @@ Some( Some( "Editing: /path/to/my/file.rs", ), - Tiled( - None, - ), + Tiled { + direction: None, + borderless: None, + }, false, ClientId( 1, diff --git a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_terminal_plugin_command.snap b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_terminal_plugin_command.snap index dd197b76..582c0aaf 100644 --- a/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_terminal_plugin_command.snap +++ b/zellij-server/src/plugins/unit/snapshots/zellij_server__plugins__plugin_tests__open_terminal_plugin_command.snap @@ -20,9 +20,10 @@ Some( ), ), None, - Tiled( - None, - ), + Tiled { + direction: None, + borderless: None, + }, false, ClientId( 1, diff --git a/zellij-server/src/plugins/zellij_exports.rs b/zellij-server/src/plugins/zellij_exports.rs index 2ba461b3..9c8fd616 100644 --- a/zellij-server/src/plugins/zellij_exports.rs +++ b/zellij-server/src/plugins/zellij_exports.rs @@ -1236,6 +1236,7 @@ fn open_terminal(env: &PluginEnv, cwd: PathBuf) { command: run_command_action, pane_name: None, near_current_pane: false, + borderless: None, }; apply_action!(action, error_msg, env); } @@ -1254,7 +1255,10 @@ fn open_terminal_near_plugin(env: &PluginEnv, cwd: PathBuf) { let _ = env.senders.send_to_pty(PtyInstruction::SpawnTerminal( Some(default_shell), name, - NewPanePlacement::Tiled(None), + NewPanePlacement::Tiled { + direction: None, + borderless: None, + }, false, ClientTabIndexOrPaneId::PaneId(PaneId::Plugin(env.plugin_id)), None, // no completion signal needed for plugin calls @@ -1440,6 +1444,7 @@ fn open_command_pane( command: Some(run_command_action), pane_name: name, near_current_pane: false, + borderless: None, }; apply_action!(action, error_msg, env); } @@ -1475,7 +1480,10 @@ fn open_command_pane_near_plugin( let _ = env.senders.send_to_pty(PtyInstruction::SpawnTerminal( Some(run_cmd), name, - NewPanePlacement::Tiled(None), + NewPanePlacement::Tiled { + direction: None, + borderless: None, + }, false, ClientTabIndexOrPaneId::PaneId(PaneId::Plugin(env.plugin_id)), None, // no completion signal needed for plugin calls |
