feat(terminal): support styled underlines (#2730)

* feat: support styled underlines

* remove deadcode

* Add ansi_underlines config option

* Add missing variables

* Add ansi_underlines on Output and OutputBuffer

* Fix tests

* Add separate styled underline enum

* Remove ansi_underlines from fg and bg

* Remove unneeded variables

* Rename ansi_underlines -> styled_underlines

* Simplify CharacterStyles::new()

* Move styled_underlines config description

* Fix single underline and remove extra field on CharacterStyles

* Read styled-underlines flag from cli opts

* remove extra attribute left from merge conflict

---------

Co-authored-by: Mike Lloyd <mike.lloyd03@pm.me>
Co-authored-by: Mike Lloyd <49411532+mike-lloyd03@users.noreply.github.com>
Co-authored-by: Aram Drevekenin <aram@poor.dev>

10 files changed, 10 insertions, 10 deletions

diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_config_options.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_config_options.snap
index 6e08b82c..b1788677 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_config_options.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_config_options.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 686
 expression: "format!(\"{:#?}\", options)"
 ---
 Options {
@@ -29,4 +28,5 @@ Options {
     session_serialization: None,
     serialize_pane_viewport: None,
     scrollback_lines_to_serialize: None,
+    styled_underlines: None,
 }
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_layout_options.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_layout_options.snap
index d02d83bc..f6f89eaa 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_layout_options.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__cli_arguments_override_layout_options.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 714
 expression: "format!(\"{:#?}\", options)"
 ---
 Options {
@@ -29,4 +28,5 @@ Options {
     session_serialization: None,
     serialize_pane_viewport: None,
     scrollback_lines_to_serialize: None,
+    styled_underlines: None,
 }
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments-3.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments-3.snap
index fbf93ce2..10f7318a 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments-3.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments-3.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 673
 expression: "format!(\"{:#?}\", options)"
 ---
 Options {
@@ -27,4 +26,5 @@ Options {
     session_serialization: None,
     serialize_pane_viewport: None,
     scrollback_lines_to_serialize: None,
+    styled_underlines: None,
 }
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments.snap
index 3083777a..cfd5652b 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__default_config_with_no_cli_arguments.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 671
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -3592,6 +3591,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {},
     plugins: {
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_env_vars_override_config_env_vars.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_env_vars_override_config_env_vars.snap
index 3bd3a5ab..36573171 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_env_vars_override_config_env_vars.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_env_vars_override_config_env_vars.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 729
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -3592,6 +3591,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {},
     plugins: {
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_keybinds_override_config_keybinds.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_keybinds_override_config_keybinds.snap
index 2a64a6f1..7a5e3991 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_keybinds_override_config_keybinds.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_keybinds_override_config_keybinds.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 785
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -85,6 +84,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {},
     plugins: {
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_options_override_config_options.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_options_override_config_options.snap
index a2ccc3c3..71364b8a 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_options_override_config_options.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_options_override_config_options.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 696
 expression: "format!(\"{:#?}\", options)"
 ---
 Options {
@@ -29,4 +28,5 @@ Options {
     session_serialization: None,
     serialize_pane_viewport: None,
     scrollback_lines_to_serialize: None,
+    styled_underlines: None,
 }
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_plugins_override_config_plugins.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_plugins_override_config_plugins.snap
index e3911cb8..c011cb0e 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_plugins_override_config_plugins.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_plugins_override_config_plugins.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 757
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -3592,6 +3591,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {},
     plugins: {
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_themes_override_config_themes.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_themes_override_config_themes.snap
index 7168d096..18ce1143 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_themes_override_config_themes.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_themes_override_config_themes.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 771
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -3592,6 +3591,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {
         "other-theme-from-config": Theme {
diff --git a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_ui_config_overrides_config_ui_config.snap b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_ui_config_overrides_config_ui_config.snap
index b1bbe745..4d135566 100644
--- a/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_ui_config_overrides_config_ui_config.snap
+++ b/zellij-utils/src/snapshots/zellij_utils__setup__setup_test__layout_ui_config_overrides_config_ui_config.snap
@@ -1,6 +1,5 @@
 ---
 source: zellij-utils/src/setup.rs
-assertion_line: 743
 expression: "format!(\"{:#?}\", config)"
 ---
 Config {
@@ -3592,6 +3591,7 @@ Config {
         session_serialization: None,
         serialize_pane_viewport: None,
         scrollback_lines_to_serialize: None,
+        styled_underlines: None,
     },
     themes: {},
     plugins: {