diff options
| author | user <user@clank> | 2026-08-16 16:16:50 +0200 |
|---|---|---|
| committer | user <user@clank> | 2026-08-16 16:16:50 +0200 |
| commit | b1110cd42778d23c872a4745bc5cca6d7836c893 (patch) | |
| tree | 91fbf4c0c4a0025c0108db34356c08ac0cd37913 /src | |
| parent | sl0ppty: PI is 180 (diff) | |
| download | slosh-b1110cd42778d23c872a4745bc5cca6d7836c893.tar.gz slosh-b1110cd42778d23c872a4745bc5cca6d7836c893.tar.xz slosh-b1110cd42778d23c872a4745bc5cca6d7836c893.zip | |
sl0ppty: two tests that were sampling, not asking
Both preset suites ask "does this preset do anything", and both were answering
it by looking a fixed number of times and comparing. `test_shader_presets.py`
looked exactly once; `test_chrome_presets.py` looked five times, 50ms apart.
They passed for a reason that stopped being true. Until `a5114a9` a pass at zero
strength still materialised every cell it touched -- resolving the terminal's own
colours into ours -- so *any* chain, at any phase, changed the cells. Comparing
against unshaded could not fail. Now that an identity pass leaves a cell alone,
the question is honest, and the answer is genuinely "nothing" at some phases:
`motion-typewriter` dims the rows below a line walking down the pane, and one
frame in eighteen that line is past the last row.
So both poll for the change with a deadline instead, which is what the harness
says to do about anything observable: the deadline bounds failure only, and a
preset that paints is seen the moment it paints. The chrome one keeps a minimum
window as well, because its second assertion is "the contents did *not* move",
and nothing needs a while to be sure of.
Found by the suite going red under its own parallel load while every file passed
on its own -- which is the useful failure, since it means the flake was real and
not the machine.
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions
