diff options
| author | user <user@clank> | 2026-08-17 14:22:38 +0200 |
|---|---|---|
| committer | user <user@clank> | 2026-08-17 14:22:38 +0200 |
| commit | ec91ccffe631ae34b111bf6161fd0e3c487f684c (patch) | |
| tree | 4a9fdbb720d9bf03edd5f538d1d87afd2bf51bfb /tests/expr_test.c | |
| parent | sl0ppty: clang-format, and a hook that runs it on what you staged (diff) | |
| download | slosh-ec91ccffe631ae34b111bf6161fd0e3c487f684c.tar.gz slosh-ec91ccffe631ae34b111bf6161fd0e3c487f684c.tar.xz slosh-ec91ccffe631ae34b111bf6161fd0e3c487f684c.zip | |
sl0ppty: clang-format the tree
The bumpy one. `make fmt` over every `.c` and `.h` outside `vendor/`: 32 files,
1,843 lines rewritten, no behaviour changed. Nothing here is worth reading -- the
next commit adds it to `.git-blame-ignore-revs` so `git blame` walks past it.
Two thirds of it is alignment the formatter now owns: trailing comments in a
struct, continuation lines under a signature. The rest is the hand-packed tables
opening up to one entry per line -- `ACTIONS`, `NAMED_KEYS`, `ACTION_HELP`. That
is a real loss of density and a real gain in diffs: adding an action was a reflow
of the block and is now one line. Anything worth keeping packed can be fenced with
`// clang-format off`; nothing was, on the grounds that a table is the thing a
formatter is for.
**One change is not formatting.** `src/config.h` had three trailing comments glued
onto one field:
uint16_t hover_delay_ms; /* how long the pointer must rest to arm a guide */
/* how long an announcement stays up */ /* rows per wheel notch */
-- `toast_ms`'s and `scroll_lines`' comments, landed on their neighbour by an
earlier edit, documenting the wrong things ever since. It is in this commit
because it is what caught it: clang-format could not settle on that line, wrapping
it one way and then re-indenting the wrap on a second pass, so `make fmt` was not
idempotent. The comments are back where they belong and it is.
Verified after the reformat, not before: `make clean && make all` is
warning-free, `make retest` is 1801 checks green, and `make fmt` twice in a row
changes nothing the second time. A formatter that alters behaviour would be worse
than none, so the gate was the whole suite rather than a reading of the diff.
Diffstat (limited to 'tests/expr_test.c')
| -rw-r--r-- | tests/expr_test.c | 27 |
1 files changed, 20 insertions, 7 deletions
diff --git a/tests/expr_test.c b/tests/expr_test.c index f775065..19968d1 100644 --- a/tests/expr_test.c +++ b/tests/expr_test.c @@ -21,9 +21,16 @@ static int at(const char *src, int x, int y) { snprintf(detail, sizeof detail, "%s: %s", src, err); return -99999; } - expr_env_t env = {.x = x, .y = y, .cols = 80, .rows = 24, - .curx = 10, .cury = 5, .cursor = 1, .focused = 1, - .t = 1000, .since = 250}; + expr_env_t env = {.x = x, + .y = y, + .cols = 80, + .rows = 24, + .curx = 10, + .cury = 5, + .cursor = 1, + .focused = 1, + .t = 1000, + .since = 250}; int v = expr_eval(p, &env); expr_free(p); return v; @@ -31,7 +38,8 @@ static int at(const char *src, int x, int y) { static void eq(const char *src, int want) { int got = at(src, 3, 4); - if (got != want) snprintf(detail, sizeof detail, "%s -> %d, wanted %d", src, got, want); + if (got != want) + snprintf(detail, sizeof detail, "%s -> %d, wanted %d", src, got, want); ok(src, got == want, detail); } @@ -196,11 +204,15 @@ int main(void) { printf("\n-- dependencies are derived from the source, not declared\n"); { - struct { const char *src; unsigned want; } cases[] = { + struct { + const char *src; + unsigned want; + } cases[] = { {"128", 0}, {"x * 2", EXPR_DEP_POS}, {"y", EXPR_DEP_POS}, - {"cols / 2", EXPR_DEP_SIZE}, /* not constant: the rect is not known yet */ + {"cols / 2", + EXPR_DEP_SIZE}, /* not constant: the rect is not known yet */ {"dist(x, y, curx, cury)", EXPR_DEP_POS | EXPR_DEP_CURSOR}, {"focused * 90", EXPR_DEP_FOCUS}, {"t % 1000", EXPR_DEP_TIME}, @@ -282,7 +294,8 @@ int main(void) { * than accepted and run forever. */ char big[4096]; size_t n = 0; - for (int i = 0; i < 200; i++) n += (size_t)snprintf(big + n, sizeof big - n, "1+"); + for (int i = 0; i < 200; i++) + n += (size_t)snprintf(big + n, sizeof big - n, "1+"); snprintf(big + n, sizeof big - n, "1"); char err[128] = {0}; expr_prog_t *p = expr_compile(big, err, sizeof err); |
