diff options
| author | user <user@clank> | 2026-08-16 16:25:36 +0200 |
|---|---|---|
| committer | user <user@clank> | 2026-08-16 16:25:36 +0200 |
| commit | 814a2e52757060237e8354f138dc3e4e3d13fd90 (patch) | |
| tree | 61bed6123c1aba1182678345dcd4c3b67b1ca1ff /src | |
| parent | sl0ppty: two tests that were sampling, not asking (diff) | |
| download | slosh-814a2e52757060237e8354f138dc3e4e3d13fd90.tar.gz slosh-814a2e52757060237e8354f138dc3e4e3d13fd90.tar.xz slosh-814a2e52757060237e8354f138dc3e4e3d13fd90.zip | |
sl0ppty: a race in the reload test, caught at one in eight
`test_a_config_written_after_the_session_started_is_noticed` starts a session
whose config directory does not exist, then writes a config into it. The session
is what *creates* that directory -- the whole point of the test is that a file
appearing later gets noticed -- and `sl0ppty -s` returning means the session was
asked for, not that it has got that far. So the write could land first, and did:
FileNotFoundError: /tmp/sl0ppty-home-rl_q8peu/.config/sl0ppty/config.kdl
Once in about eight full-suite runs, never on its own, never under load I could
synthesise -- which is why it took ten runs in a row to catch and why it has been
sitting there since the watcher work. Nothing to do with what is around it in
this branch; found because I was hunting a flake I had caused elsewhere and this
one answered instead.
Fixed by waiting for the directory, which turns the thing the test *depended* on
into something it *states*: "the session created the directory it needs to
watch". The include test's startup check is polled for the same reason, since it
too read a screen the session had not necessarily drawn yet.
Verified the only way this kind of thing can be: ten consecutive clean runs of
the whole suite, and the file's own eleven checks green in isolation.
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions
