aboutsummaryrefslogtreecommitdiffstats
path: root/audio/engine_1.asm
diff options
context:
space:
mode:
authorPreeyan Parmar <4997904+preeyan@users.noreply.github.com>2024-05-23 17:43:54 +0100
committerGitHub <noreply@github.com>2024-05-23 11:43:54 -0500
commitd38cf5281a902b4bd167a46a7c9fd9db436484a7 (patch)
tree2bd616c64eeb3df0b0c70ee7da02bf858dba76fb /audio/engine_1.asm
parentUse constant in wram for hidden item flags (#445) (diff)
downloadpokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.tar.gz
pokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.tar.xz
pokeyellow-d38cf5281a902b4bd167a46a7c9fd9db436484a7.zip
Add comment about audio engine perfect pitch bug (#451)
Co-authored-by: preeyan <preeyan>
Diffstat (limited to 'audio/engine_1.asm')
-rw-r--r--audio/engine_1.asm3
1 files changed, 2 insertions, 1 deletions
diff --git a/audio/engine_1.asm b/audio/engine_1.asm
index 8b30fb1a..24c93c9a 100644
--- a/audio/engine_1.asm
+++ b/audio/engine_1.asm
@@ -831,7 +831,8 @@ Audio1_note_pitch:
bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used?
jr z, .skipFrequencyInc
inc e ; if yes, increment the frequency by 1
- jr nc, .skipFrequencyInc
+ jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C.
+ ; Fortunately this does not seem to affect any notes that actually occur.
inc d
.skipFrequencyInc
ld hl, wChannelFrequencyLowBytes