aboutsummaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authordannye <33dannye@gmail.com>2024-09-25 00:45:00 -0500
committerdannye <33dannye@gmail.com>2024-09-25 00:45:00 -0500
commita02a98ee7ada1a658e28698484058be2796dc0df (patch)
tree945986054565bd8b5212fc755415096050d1d3a8 /scripts
parentUse long option flags for rgbgfx, same as tools/gfx (diff)
parentUse `const_skip` (diff)
downloadpokeyellow-a02a98ee7ada1a658e28698484058be2796dc0df.tar.gz
pokeyellow-a02a98ee7ada1a658e28698484058be2796dc0df.tar.xz
pokeyellow-a02a98ee7ada1a658e28698484058be2796dc0df.zip
Merge branch 'master' of https://github.com/pret/pokered
Diffstat (limited to 'scripts')
-rw-r--r--scripts/AgathasRoom.asm8
-rw-r--r--scripts/BikeShop.asm8
-rw-r--r--scripts/BillsHouse.asm10
-rw-r--r--scripts/BrunosRoom.asm8
-rw-r--r--scripts/CeladonGym.asm16
-rw-r--r--scripts/CeladonMansion3F.asm8
-rw-r--r--scripts/CeladonMartElevator.asm8
-rw-r--r--scripts/CeladonMartRoof.asm19
-rw-r--r--scripts/CeruleanBadgeHouse.asm4
-rw-r--r--scripts/CeruleanCity.asm30
-rw-r--r--scripts/CeruleanGym.asm16
-rw-r--r--scripts/CeruleanMelaniesHouse.asm4
-rw-r--r--scripts/ChampionsRoom.asm30
-rw-r--r--scripts/CinnabarGym.asm32
-rw-r--r--scripts/CinnabarIsland.asm4
-rw-r--r--scripts/CinnabarLabFossilRoom.asm7
-rw-r--r--scripts/Daycare.asm6
-rw-r--r--scripts/FightingDojo.asm16
-rw-r--r--scripts/FuchsiaGoodRodHouse.asm8
-rw-r--r--scripts/FuchsiaGym.asm16
-rw-r--r--scripts/GameCorner.asm32
-rw-r--r--scripts/GameCornerPrizeRoom.asm1
-rw-r--r--scripts/HallOfFame.asm9
-rw-r--r--scripts/IndigoPlateauLobby.asm12
-rw-r--r--scripts/LancesRoom.asm10
-rw-r--r--scripts/LoreleisRoom.asm12
-rw-r--r--scripts/MtMoonB2F.asm42
-rw-r--r--scripts/Museum1F.asm4
-rw-r--r--scripts/OaksLab.asm98
-rw-r--r--scripts/PalletTown.asm14
-rw-r--r--scripts/PewterCity.asm22
-rw-r--r--scripts/PewterGym.asm16
-rw-r--r--scripts/PewterMart.asm2
-rw-r--r--scripts/PokemonFanClub.asm8
-rw-r--r--scripts/PokemonMansion1F.asm8
-rw-r--r--scripts/PokemonMansion2F.asm8
-rw-r--r--scripts/PokemonMansion3F.asm18
-rw-r--r--scripts/PokemonMansionB1F.asm6
-rw-r--r--scripts/PokemonTower2F.asm14
-rw-r--r--scripts/PokemonTower5F.asm10
-rw-r--r--scripts/PokemonTower6F.asm14
-rw-r--r--scripts/PokemonTower7F.asm28
-rw-r--r--scripts/RedsHouse1F_2.asm4
-rw-r--r--scripts/RocketHideoutB1F.asm4
-rw-r--r--scripts/RocketHideoutB2F.asm8
-rw-r--r--scripts/RocketHideoutB3F.asm10
-rw-r--r--scripts/RocketHideoutB4F.asm34
-rw-r--r--scripts/RocketHideoutElevator.asm8
-rw-r--r--scripts/Route11Gate2F.asm2
-rw-r--r--scripts/Route12.asm6
-rw-r--r--scripts/Route12SuperRodHouse.asm8
-rw-r--r--scripts/Route15Gate2F.asm4
-rw-r--r--scripts/Route16.asm6
-rw-r--r--scripts/Route16Gate1F.asm12
-rw-r--r--scripts/Route18Gate1F.asm12
-rw-r--r--scripts/Route22.asm36
-rw-r--r--scripts/Route22Gate.asm2
-rw-r--r--scripts/Route23.asm8
-rw-r--r--scripts/Route24.asm16
-rw-r--r--scripts/Route25.asm4
-rw-r--r--scripts/Route2Gate.asm4
-rw-r--r--scripts/Route5Gate.asm20
-rw-r--r--scripts/Route6Gate.asm16
-rw-r--r--scripts/Route7Gate.asm16
-rw-r--r--scripts/Route8Gate.asm16
-rw-r--r--scripts/SSAnne2F.asm18
-rw-r--r--scripts/SSAnneCaptainsRoom.asm12
-rw-r--r--scripts/SafariZoneGate.asm8
-rw-r--r--scripts/SaffronGym.asm16
-rw-r--r--scripts/SeafoamIslands1F.asm6
-rw-r--r--scripts/SeafoamIslandsB1F.asm6
-rw-r--r--scripts/SeafoamIslandsB2F.asm6
-rw-r--r--scripts/SeafoamIslandsB3F.asm22
-rw-r--r--scripts/SeafoamIslandsB4F.asm4
-rw-r--r--scripts/SilphCo10F.asm4
-rw-r--r--scripts/SilphCo11F.asm42
-rw-r--r--scripts/SilphCo2F.asm4
-rw-r--r--scripts/SilphCo3F.asm4
-rw-r--r--scripts/SilphCo4F.asm4
-rw-r--r--scripts/SilphCo5F.asm4
-rw-r--r--scripts/SilphCo6F.asm4
-rw-r--r--scripts/SilphCo7F.asm32
-rw-r--r--scripts/SilphCo8F.asm4
-rw-r--r--scripts/SilphCo9F.asm4
-rw-r--r--scripts/SilphCoElevator.asm8
-rw-r--r--scripts/SummerBeachHouse.asm8
-rw-r--r--scripts/SummerBeachHouse_2.asm8
-rw-r--r--scripts/TradeCenter.asm6
-rw-r--r--scripts/VermilionCity.asm10
-rw-r--r--scripts/VermilionCity_2.asm4
-rw-r--r--scripts/VermilionDock.asm4
-rw-r--r--scripts/VermilionGym.asm20
-rw-r--r--scripts/VermilionOldRodHouse.asm8
-rw-r--r--scripts/VictoryRoad1F.asm6
-rw-r--r--scripts/VictoryRoad2F.asm14
-rw-r--r--scripts/VictoryRoad3F.asm26
-rw-r--r--scripts/ViridianCity.asm20
-rw-r--r--scripts/ViridianGym.asm20
-rw-r--r--scripts/ViridianMart.asm4
-rw-r--r--scripts/WardensHouse.asm2
100 files changed, 638 insertions, 636 deletions
diff --git a/scripts/AgathasRoom.asm b/scripts/AgathasRoom.asm
index cf5254ac..2d0dca08 100644
--- a/scripts/AgathasRoom.asm
+++ b/scripts/AgathasRoom.asm
@@ -11,8 +11,8 @@ AgathasRoom_Script:
AgathaShowOrHideExitBlock:
; Blocks or clears the exit to the next room.
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_BEAT_AGATHAS_ROOM_TRAINER_0
jr z, .blockExitToNextRoom
@@ -75,7 +75,7 @@ AgathasRoomDefaultScript:
jr z, AgathaScriptWalkIntoRoom
.stopPlayerFromLeaving
ld a, TEXT_AGATHASROOM_AGATHA_DONT_RUN_AWAY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, D_UP
ld [wSimulatedJoypadStatesEnd], a
@@ -111,7 +111,7 @@ AgathasRoomAgathaEndBattleScript:
cp $ff
jp z, ResetAgathaScript
ld a, TEXT_AGATHASROOM_AGATHA
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SCRIPT_CHAMPIONSROOM_PLAYER_ENTERS
ld [wChampionsRoomCurScript], a
diff --git a/scripts/BikeShop.asm b/scripts/BikeShop.asm
index fa38701b..019fe97d 100644
--- a/scripts/BikeShop.asm
+++ b/scripts/BikeShop.asm
@@ -49,8 +49,8 @@ BikeShopClerkText:
ld [wTopMenuItemY], a
ld a, $1
ld [wTopMenuItemX], a
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
hlcoord 0, 0
lb bc, 4, 15
call TextBoxBorder
@@ -64,8 +64,8 @@ BikeShopClerkText:
ld hl, BikeShopClerkDoYouLikeItText
call PrintText
; This fixes the bike shop instatext glitch
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call HandleMenuInput
bit BIT_B_BUTTON, a
jr nz, .cancel
diff --git a/scripts/BillsHouse.asm b/scripts/BillsHouse.asm
index c44e4e3f..ee9a2299 100644
--- a/scripts/BillsHouse.asm
+++ b/scripts/BillsHouse.asm
@@ -91,8 +91,8 @@ MovementData_1e7a0:
db -1 ; end
BillsHouseScript3:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_BILL_POKEMON
ld [wMissableObjectIndex], a
@@ -199,8 +199,8 @@ PikachuMovementData_1e1a9:
db $3f
BillsHouseScript6:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
SetEvent EVENT_MET_BILL_2 ; this event seems redundant
SetEvent EVENT_MET_BILL
@@ -245,7 +245,7 @@ BillsHouseScript8:
xor a
ld [wJoyIgnore], a
ld a, TEXT_BILLSHOUSE_BILL_SS_TICKET
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SCRIPT_BILLSHOUSE_SCRIPT9
ld [wBillsHouseCurScript], a
diff --git a/scripts/BrunosRoom.asm b/scripts/BrunosRoom.asm
index 2a4ed6e6..6d7fde6e 100644
--- a/scripts/BrunosRoom.asm
+++ b/scripts/BrunosRoom.asm
@@ -11,8 +11,8 @@ BrunosRoom_Script:
BrunoShowOrHideExitBlock:
; Blocks or clears the exit to the next room.
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_BEAT_BRUNOS_ROOM_TRAINER_0
jr z, .blockExitToNextRoom
@@ -75,7 +75,7 @@ BrunosRoomDefaultScript:
jr z, BrunoScriptWalkIntoRoom
.stopPlayerFromLeaving
ld a, TEXT_BRUNOSROOM_BRUNO_DONT_RUN_AWAY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID ; "Don't run away!"
ld a, D_UP
ld [wSimulatedJoypadStatesEnd], a
@@ -111,7 +111,7 @@ BrunosRoomBrunoEndBattleScript:
cp $ff
jp z, ResetBrunoScript
ld a, TEXT_BRUNOSROOM_BRUNO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
BrunosRoom_TextPointers:
diff --git a/scripts/CeladonGym.asm b/scripts/CeladonGym.asm
index 0195d0b9..f95d129a 100644
--- a/scripts/CeladonGym.asm
+++ b/scripts/CeladonGym.asm
@@ -1,7 +1,7 @@
CeladonGym_Script:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, .LoadNames
call EnableAutoTextBoxDrawing
ld hl, CeladonGymTrainerHeaders
@@ -45,20 +45,20 @@ CeladonGymErikaPostBattleScript:
CeladonGymReceiveTM21:
ld a, TEXT_CELADONGYM_RAINBOWBADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_ERIKA
lb bc, TM_MEGA_DRAIN, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_CELADONGYM_RECEIVED_TM21
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM21
jr .gymVictory
.BagFull
ld a, TEXT_CELADONGYM_TM21_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -119,9 +119,9 @@ CeladonGymErikaText:
.beforeBeat
ld hl, .PreBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .ReceivedRainbowBadgeText
ld de, .ReceivedRainbowBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/CeladonMansion3F.asm b/scripts/CeladonMansion3F.asm
index 824f4883..8453d0e5 100644
--- a/scripts/CeladonMansion3F.asm
+++ b/scripts/CeladonMansion3F.asm
@@ -57,11 +57,11 @@ CeladonMansion3FGraphicArtistText:
call SaveScreenTilesToBuffer2
xor a
ld [wUpdateSpritesEnabled], a
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
callfar PrintDiploma
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call GBPalWhiteOutWithDelay3
call ReloadTilesetTilePatterns
call RestoreScreenTilesAndReloadTilePatterns
diff --git a/scripts/CeladonMartElevator.asm b/scripts/CeladonMartElevator.asm
index 9a2842f3..69686fa8 100644
--- a/scripts/CeladonMartElevator.asm
+++ b/scripts/CeladonMartElevator.asm
@@ -1,12 +1,12 @@
CeladonMartElevator_Script:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
push hl
call nz, CeladonMartElevatorStoreWarpEntriesScript
pop hl
- bit 7, [hl]
- res 7, [hl]
+ bit BIT_CUR_MAP_USED_ELEVATOR, [hl]
+ res BIT_CUR_MAP_USED_ELEVATOR, [hl]
call nz, CeladonMartElevatorShakeScript
xor a
ld [wAutoTextBoxDrawingControl], a
diff --git a/scripts/CeladonMartRoof.asm b/scripts/CeladonMartRoof.asm
index 56be937f..57eab858 100644
--- a/scripts/CeladonMartRoof.asm
+++ b/scripts/CeladonMartRoof.asm
@@ -14,15 +14,16 @@ CeladonMartRoofScript_GetDrinksInBag:
jr z, .done
push hl
push de
- ld [wd11e], a
+ ld [wTempByteValue], a
ld b, a
predef GetQuantityOfItemInBag
pop de
pop hl
ld a, b
and a
- jr z, .loop ; if the item isn't in the bag
- ld a, [wd11e]
+ jr z, .loop
+ ; A drink is in the bag
+ ld a, [wTempByteValue]
ld [de], a
inc de
push hl
@@ -42,8 +43,8 @@ CeladonMartRoofDrinkList:
db 0 ; end
CeladonMartRoofScript_GiveDrinkToGirl:
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
ld hl, CeladonMartRoofLittleGirlGiveHerWhichDrinkText
call PrintText
xor a
@@ -69,8 +70,8 @@ CeladonMartRoofScript_GiveDrinkToGirl:
call TextBoxBorder
call UpdateSprites
call CeladonMartRoofScript_PrintDrinksInBag
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call HandleMenuInput
bit BIT_B_BUTTON, a
ret nz
@@ -196,13 +197,13 @@ CeladonMartRoofScript_PrintDrinksInBag:
cp $ff
ret z
push hl
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetItemName
hlcoord 2, 2
ldh a, [hItemCounter]
ld bc, SCREEN_WIDTH * 2
call AddNTimes
- ld de, wcd6d
+ ld de, wNameBuffer
call PlaceString
ld hl, hItemCounter
inc [hl]
diff --git a/scripts/CeruleanBadgeHouse.asm b/scripts/CeruleanBadgeHouse.asm
index 417198e1..54186523 100644
--- a/scripts/CeruleanBadgeHouse.asm
+++ b/scripts/CeruleanBadgeHouse.asm
@@ -1,5 +1,5 @@
CeruleanBadgeHouse_Script:
- ld a, TRUE
+ ld a, 1 << BIT_NO_AUTO_TEXT_BOX
ld [wAutoTextBoxDrawingControl], a
dec a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -34,7 +34,7 @@ CeruleanBadgeHouseMiddleAgedManText:
call DisplayListMenuID
jr c, .done
ld hl, CeruleanBadgeHouseBadgeTextPointers
- ld a, [wcf91]
+ ld a, [wCurItem]
sub BOULDERBADGE
add a
ld d, $0
diff --git a/scripts/CeruleanCity.asm b/scripts/CeruleanCity.asm
index 45685f83..c1268a60 100644
--- a/scripts/CeruleanCity.asm
+++ b/scripts/CeruleanCity.asm
@@ -28,7 +28,7 @@ CeruleanCityRocketDefeatedScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_CERULEAN_ROCKET_THIEF
ld a, TEXT_CERULEANCITY_ROCKET
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a ; SCRIPT_CERULEANCITY_DEFAULT
ld [wJoyIgnore], a
@@ -58,7 +58,7 @@ ENDC
ld [wSprite02StateData1FacingDirection], a
call Delay3
ld a, TEXT_CERULEANCITY_ROCKET
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
.skipRocketThiefEncounter
CheckEvent EVENT_BEAT_CERULEAN_RIVAL
@@ -123,17 +123,17 @@ CeruleanCityFaceRivalScript:
jp SetSpriteFacingDirectionAndDelay ; face object
CeruleanCityRivalBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
ld a, TEXT_CERULEANCITY_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, CeruleanCityRivalDefeatedText
ld de, CeruleanCityRivalVictoryText
call SaveEndBattleTextPointers
@@ -157,7 +157,7 @@ CeruleanCityRivalDefeatedScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_CERULEAN_RIVAL
ld a, TEXT_CERULEANCITY_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call StopAllMusic
farcall Music_RivalAlternateStart
@@ -200,8 +200,8 @@ CeruleanCityMovement4:
db -1 ; end
CeruleanCityRivalCleanupScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_CERULEAN_RIVAL
ld [wMissableObjectIndex], a
@@ -270,13 +270,13 @@ CeruleanCityRocketText:
jr nz, .beatRocketThief
ld hl, .Text
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .IGiveUpText
ld de, .IGiveUpText
call SaveEndBattleTextPointers
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hTextID]
ld [wSpriteIndex], a
call EngageMapTrainer
call InitBattleEnemyParameters
diff --git a/scripts/CeruleanGym.asm b/scripts/CeruleanGym.asm
index b4bed363..cb4d3975 100644
--- a/scripts/CeruleanGym.asm
+++ b/scripts/CeruleanGym.asm
@@ -1,7 +1,7 @@
CeruleanGym_Script:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, .LoadNames
call EnableAutoTextBoxDrawing
ld hl, CeruleanGymTrainerHeaders
@@ -45,20 +45,20 @@ CeruleanGymMistyPostBattleScript:
CeruleanGymReceiveTM11:
ld a, TEXT_CERULEANGYM_MISTY_CASCADE_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_MISTY
lb bc, TM_BUBBLEBEAM, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_CERULEANGYM_MISTY_RECEIVED_TM11
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM11
jr .gymVictory
.BagFull
ld a, TEXT_CERULEANGYM_MISTY_TM11_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -105,9 +105,9 @@ CeruleanGymMistyText:
.beforeBeat
ld hl, .PreBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, CeruleanGymMistyReceivedCascadeBadgeText
ld de, CeruleanGymMistyReceivedCascadeBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/CeruleanMelaniesHouse.asm b/scripts/CeruleanMelaniesHouse.asm
index eec62f92..1d2b817d 100644
--- a/scripts/CeruleanMelaniesHouse.asm
+++ b/scripts/CeruleanMelaniesHouse.asm
@@ -29,8 +29,8 @@ CeruleanMelanieHouseMelanieText:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, BULBASAUR
- ld [wd11e], a
- ld [wcf91], a
+ ld [wNamedObjectIndex], a
+ ld [wCurPartySpecies], a
call GetMonName
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
diff --git a/scripts/ChampionsRoom.asm b/scripts/ChampionsRoom.asm
index 918e9468..f244327d 100644
--- a/scripts/ChampionsRoom.asm
+++ b/scripts/ChampionsRoom.asm
@@ -55,14 +55,14 @@ ChampionsRoomRivalReadyToBattleScript:
xor a
ld [wJoyIgnore], a
ld hl, wOptions
- res 7, [hl] ; Turn on battle animations to make the battle feel more epic.
+ res BIT_BATTLE_ANIMATION, [hl]
ld a, TEXT_CHAMPIONSROOM_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, RivalDefeatedText
ld de, RivalVictoryText
call SaveEndBattleTextPointers
@@ -89,7 +89,7 @@ ChampionsRoomRivalDefeatedScript:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_CHAMPIONSROOM_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call ChampionsRoom_DisplayTextID_AllowABSelectStart
ld a, CHAMPIONSROOM_RIVAL
ldh [hSpriteIndex], a
@@ -101,7 +101,7 @@ ChampionsRoomRivalDefeatedScript:
ChampionsRoomOakArrivesScript:
farcall Music_Cities1AlternateTempo
ld a, TEXT_CHAMPIONSROOM_OAK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call ChampionsRoom_DisplayTextID_AllowABSelectStart
ld a, CHAMPIONSROOM_OAK
ldh [hSpriteIndex], a
@@ -126,8 +126,8 @@ OakEntranceAfterVictoryMovement:
db -1 ; end
ChampionsRoomOakCongratulatesPlayerScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, PLAYER_DIR_LEFT
ld [wPlayerMovingDirection], a
@@ -142,7 +142,7 @@ ChampionsRoomOakCongratulatesPlayerScript:
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_CHAMPIONSROOM_OAK_CONGRATULATES_PLAYER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call ChampionsRoom_DisplayTextID_AllowABSelectStart
ld a, SCRIPT_CHAMPIONSROOM_OAK_DISAPPOINTED_WITH_RIVAL
ld [wChampionsRoomCurScript], a
@@ -155,7 +155,7 @@ ChampionsRoomOakDisappointedWithRivalScript:
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_CHAMPIONSROOM_OAK_DISAPPOINTED_WITH_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call ChampionsRoom_DisplayTextID_AllowABSelectStart
ld a, SCRIPT_CHAMPIONSROOM_OAK_COME_WITH_ME
ld [wChampionsRoomCurScript], a
@@ -168,7 +168,7 @@ ChampionsRoomOakComeWithMeScript:
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_CHAMPIONSROOM_OAK_COME_WITH_ME
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call ChampionsRoom_DisplayTextID_AllowABSelectStart
ld de, OakExitChampionsRoomMovement
ld a, CHAMPIONSROOM_OAK
@@ -184,8 +184,8 @@ OakExitChampionsRoomMovement:
db -1 ; end
ChampionsRoomOakExitsScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_CHAMPIONS_ROOM_OAK
ld [wMissableObjectIndex], a
@@ -271,7 +271,7 @@ ChampionsRoomOakText:
ChampionsRoomOakCongratulatesPlayerText:
text_asm
ld a, [wPlayerStarter]
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMonName
ld hl, .Text
call PrintText
diff --git a/scripts/CinnabarGym.asm b/scripts/CinnabarGym.asm
index 7279c971..2ebf51df 100644
--- a/scripts/CinnabarGym.asm
+++ b/scripts/CinnabarGym.asm
@@ -7,13 +7,13 @@ CinnabarGym_Script:
CinnabarGymSetMapAndTiles:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
push hl
call nz, .LoadNames
pop hl
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
call nz, UpdateCinnabarGymGateTileBlocks
ResetEvent EVENT_2A7
ret
@@ -38,7 +38,7 @@ CinnabarGymResetScripts:
ret
CinnabarGymSetTrainerHeader:
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hTextID]
ld [wTrainerHeaderFlagBit], a
ret
@@ -119,14 +119,14 @@ CinnabarGymScript_74fa3:
ret
CinnabarGymGetOpponentTextScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
ld a, [wOpponentAfterWrongAnswer]
ld [wTrainerHeaderFlagBit], a
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
CinnabarGymOpenGateScript:
@@ -205,20 +205,20 @@ CinnabarGymBlainePostBattleScript:
; fallthrough
CinnabarGymReceiveTM38:
ld a, TEXT_CINNABARGYM_BLAINE_VOLCANO_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_BLAINE
lb bc, TM_FIRE_BLAST, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_CINNABARGYM_BLAINE_RECEIVED_TM38
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM38
jr .gymVictory
.BagFull
ld a, TEXT_CINNABARGYM_BLAINE_TM38_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -230,7 +230,7 @@ CinnabarGymReceiveTM38:
SetEventRange EVENT_BEAT_CINNABAR_GYM_TRAINER_0, EVENT_BEAT_CINNABAR_GYM_TRAINER_6
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
jp CinnabarGymResetScripts
@@ -250,13 +250,13 @@ CinnabarGym_TextPointers:
dw_const CinnabarGymBlaineTM38NoRoomText, TEXT_CINNABARGYM_BLAINE_TM38_NO_ROOM
CinnabarGymStartBattleScript:
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hSpriteIndex]
ld [wSpriteIndex], a
call EngageMapTrainer
call InitBattleEnemyParameters
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld a, [wSpriteIndex]
cp CINNABARGYM_BLAINE
jr z, .blaine
diff --git a/scripts/CinnabarIsland.asm b/scripts/CinnabarIsland.asm
index aca1b995..f2a36afb 100644
--- a/scripts/CinnabarIsland.asm
+++ b/scripts/CinnabarIsland.asm
@@ -1,7 +1,7 @@
CinnabarIsland_Script:
call EnableAutoTextBoxDrawing
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ResetEvent EVENT_MANSION_SWITCH_ON
ResetEvent EVENT_LAB_STILL_REVIVING_FOSSIL
ld hl, CinnabarIsland_ScriptPointers
@@ -26,7 +26,7 @@ CinnabarIslandDefaultScript:
ld a, PLAYER_DIR_UP
ld [wPlayerMovingDirection], a
ld a, TEXT_CINNABARISLAND_DOOR_IS_LOCKED
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ldh [hJoyHeld], a
diff --git a/scripts/CinnabarLabFossilRoom.asm b/scripts/CinnabarLabFossilRoom.asm
index 7e1f57f0..daa14412 100644
--- a/scripts/CinnabarLabFossilRoom.asm
+++ b/scripts/CinnabarLabFossilRoom.asm
@@ -18,7 +18,7 @@ Lab4Script_GetFossilsInBag:
jr z, .done
push hl
push de
- ld [wd11e], a
+ ld [wTempByteValue], a
ld b, a
predef GetQuantityOfItemInBag
pop de
@@ -26,9 +26,8 @@ Lab4Script_GetFossilsInBag:
ld a, b
and a
jr z, .loop
-
- ; A fossil's in the bag
- ld a, [wd11e]
+ ; A fossil is in the bag
+ ld a, [wTempByteValue]
ld [de], a
inc de
push hl
diff --git a/scripts/Daycare.asm b/scripts/Daycare.asm
index 26f4342a..a39361d5 100644
--- a/scripts/Daycare.asm
+++ b/scripts/Daycare.asm
@@ -58,7 +58,7 @@ DaycareGentlemanText:
call RemovePokemon
pop af
jr c, .depositedPikachuIntoDayCare
- ld a, [wcf91]
+ ld a, [wCurPartySpecies]
call PlayCry
jr .asm_562e3
@@ -179,7 +179,7 @@ DaycareGentlemanText:
ld [wMoveMonType], a
call MoveMon
ld a, [wDayCareMonSpecies]
- ld [wcf91], a
+ ld [wCurPartySpecies], a
ld a, [wPartyCount]
dec a
push af
@@ -213,7 +213,7 @@ DaycareGentlemanText:
ld [wWhichPokemon], a
callfar IsThisPartymonStarterPikachu
jr c, .withdrewPikachuFromDayCare
- ld a, [wcf91]
+ ld a, [wCurPartySpecies]
call PlayCry
jr .asm_56430
diff --git a/scripts/FightingDojo.asm b/scripts/FightingDojo.asm
index d434f681..bffa4554 100644
--- a/scripts/FightingDojo.asm
+++ b/scripts/FightingDojo.asm
@@ -49,7 +49,7 @@ FightingDojoDefaultScript:
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_FIGHTINGDOJO_KARATE_MASTER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ret
@@ -72,7 +72,7 @@ FightingDojoKarateMasterPostBattleScript:
ld [wJoyIgnore], a
SetEventRange EVENT_BEAT_KARATE_MASTER, EVENT_BEAT_FIGHTING_DOJO_TRAINER_3
ld a, TEXT_FIGHTINGDOJO_KARATE_MASTER_I_WILL_GIVE_YOU_A_POKEMON
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a ; SCRIPT_FIGHTINGDOJO_DEFAULT
ld [wJoyIgnore], a
@@ -111,13 +111,13 @@ FightingDojoKarateMasterText:
jp nz, .defeated_master
ld hl, .Text
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .DefeatedText
ld de, .DefeatedText
call SaveEndBattleTextPointers
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hSpriteIndex]
ld [wSpriteIndex], a
call EngageMapTrainer
call InitBattleEnemyParameters
@@ -239,7 +239,7 @@ FightingDojoHitmonleePokeBallText:
ld a, [wCurrentMenuItem]
and a
jr nz, .done
- ld a, [wcf91]
+ ld a, [wCurPartySpecies]
ld b, a
ld c, 30
call GivePokemon
@@ -273,7 +273,7 @@ FightingDojoHitmonchanPokeBallText:
ld a, [wCurrentMenuItem]
and a
jr nz, .done
- ld a, [wcf91]
+ ld a, [wCurPartySpecies]
ld b, a
ld c, 30
call GivePokemon
diff --git a/scripts/FuchsiaGoodRodHouse.asm b/scripts/FuchsiaGoodRodHouse.asm
index 4bfd49ae..ee55938b 100644
--- a/scripts/FuchsiaGoodRodHouse.asm
+++ b/scripts/FuchsiaGoodRodHouse.asm
@@ -7,8 +7,8 @@ FuchsiaGoodRodHouse_TextPointers:
FuchsiaGoodRodHouseFishingGuruText:
text_asm
- ld a, [wd728]
- bit 4, a ; got good rod?
+ ld a, [wStatusFlags1]
+ bit BIT_GOT_GOOD_ROD, a
jr nz, .got_item
ld hl, .Text
call PrintText
@@ -19,8 +19,8 @@ FuchsiaGoodRodHouseFishingGuruText:
lb bc, GOOD_ROD, 1
call GiveItem
jr nc, .bag_full
- ld hl, wd728
- set 4, [hl] ; got good rod
+ ld hl, wStatusFlags1
+ set BIT_GOT_GOOD_ROD, [hl]
ld hl, .ReceivedGoodRodText
jr .done
.bag_full
diff --git a/scripts/FuchsiaGym.asm b/scripts/FuchsiaGym.asm
index 1c0f02df..c983c896 100644
--- a/scripts/FuchsiaGym.asm
+++ b/scripts/FuchsiaGym.asm
@@ -10,8 +10,8 @@ FuchsiaGym_Script:
.LoadNames:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
ret z
ld hl, .CityName
ld de, .LeaderName
@@ -47,20 +47,20 @@ FuchsiaGymKogaPostBattleScript:
; fallthrough
FuchsiaGymReceiveTM06:
ld a, TEXT_FUCHSIAGYM_KOGA_SOUL_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_KOGA
lb bc, TM_TOXIC, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_FUCHSIAGYM_KOGA_RECEIVED_TM06
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM06
jr .gymVictory
.BagFull
ld a, TEXT_FUCHSIAGYM_KOGA_TM06_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -119,9 +119,9 @@ FuchsiaGymKogaText:
.beforeBeat
ld hl, .BeforeBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .ReceivedSoulBadgeText
ld de, .ReceivedSoulBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/GameCorner.asm b/scripts/GameCorner.asm
index 3fd58f60..94442a60 100644
--- a/scripts/GameCorner.asm
+++ b/scripts/GameCorner.asm
@@ -8,8 +8,8 @@ GameCorner_Script:
GameCornerSelectLuckySlotMachine:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
ret z
call Random
ldh a, [hRandomAdd]
@@ -25,8 +25,8 @@ GameCornerSelectLuckySlotMachine:
GameCornerSetRocketHideoutDoorTile:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_FOUND_ROCKET_HIDEOUT
ret nz
@@ -58,7 +58,7 @@ GameCornerRocketBattleScript:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_GAMECORNER_ROCKET_AFTER_BATTLE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, GAMECORNER_ROCKET
ldh [hSpriteIndex], a
@@ -106,8 +106,8 @@ GameCornerMovement_Rocket_WalkDirect:
db -1 ; end
GameCornerRocketExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
@@ -115,8 +115,8 @@ GameCornerRocketExitScript:
ld [wMissableObjectIndex], a
predef HideObject
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
- set 6, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
+ set BIT_CUR_MAP_LOADED_2, [hl]
ld a, SCRIPT_GAMECORNER_DEFAULT
ld [wGameCornerCurScript], a
ret
@@ -426,9 +426,9 @@ GameCornerRocketText:
text_asm
ld hl, .ImGuardingThisPosterText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .BattleEndText
ld de, .BattleEndText
call SaveEndBattleTextPointers
@@ -486,8 +486,8 @@ GameCornerOopsForgotCoinCaseText:
text_end
GameCornerDrawCoinBox:
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
hlcoord 11, 0
lb bc, 5, 7
call TextBoxBorder
@@ -515,8 +515,8 @@ GameCornerDrawCoinBox:
ld de, wPlayerCoins
ld c, $82
call PrintBCDNumber
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
ret
GameCornerMoneyText:
diff --git a/scripts/GameCornerPrizeRoom.asm b/scripts/GameCornerPrizeRoom.asm
index 443e0260..8e3bc0a6 100644
--- a/scripts/GameCornerPrizeRoom.asm
+++ b/scripts/GameCornerPrizeRoom.asm
@@ -8,6 +8,7 @@ GameCornerPrizeRoom_TextPointers:
dw_const GameCornerPRizeRoomPrizeVendorText, TEXT_GAMECORNERPRIZEROOM_PRIZE_VENDOR_1
dw_const GameCornerPRizeRoomPrizeVendorText, TEXT_GAMECORNERPRIZEROOM_PRIZE_VENDOR_2
dw_const GameCornerPRizeRoomPrizeVendorText, TEXT_GAMECORNERPRIZEROOM_PRIZE_VENDOR_3
+ EXPORT TEXT_GAMECORNERPRIZEROOM_PRIZE_VENDOR_1 ; used by engine/events/prize_menu.asm
GameCornerPrizeRoomBaldingGuyText:
text_far _GameCornerPrizeRoomBaldingGuyText
diff --git a/scripts/HallOfFame.asm b/scripts/HallOfFame.asm
index d5102830..ed3d2a73 100644
--- a/scripts/HallOfFame.asm
+++ b/scripts/HallOfFame.asm
@@ -29,10 +29,11 @@ HallOfFameResetEventsAndSaveScript:
predef HallOfFamePC
pop af
ld [wLetterPrintingDelayFlags], a
- ld hl, wFlags_D733
- res 1, [hl]
+ ld hl, wStatusFlags7
+ res BIT_NO_MAP_MUSIC, [hl]
+ assert wStatusFlags7 + 1 == wElite4Flags
inc hl
- set BIT_TEST_BATTLE, [hl] ; debug, unused?
+ set BIT_UNUSED_BEAT_ELITE_4, [hl] ; debug, unused?
xor a ; SCRIPT_*_DEFAULT
ld hl, wLoreleisRoomCurScript
ld [hli], a ; wLoreleisRoomCurScript
@@ -91,7 +92,7 @@ HallOfFameOakCongratulationsScript:
inc a ; PLAYER_DIR_RIGHT
ld [wPlayerMovingDirection], a
ld a, TEXT_HALLOFFAME_OAK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
diff --git a/scripts/IndigoPlateauLobby.asm b/scripts/IndigoPlateauLobby.asm
index 0af18a96..ee757ef7 100644
--- a/scripts/IndigoPlateauLobby.asm
+++ b/scripts/IndigoPlateauLobby.asm
@@ -2,15 +2,15 @@ IndigoPlateauLobby_Script:
call Serial_TryEstablishingExternallyClockedConnection
call EnableAutoTextBoxDrawing
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
ret z
ResetEvent EVENT_VICTORY_ROAD_1_BOULDER_ON_SWITCH
- ld hl, wBeatLorelei
- bit 1, [hl]
- res 1, [hl]
+ ; Reset Elite Four events if the player started challenging them before
+ ld hl, wElite4Flags
+ bit BIT_STARTED_ELITE_4, [hl]
+ res BIT_STARTED_ELITE_4, [hl]
ret z
- ; Elite 4 events
ResetEventRange INDIGO_PLATEAU_EVENTS_START, EVENT_LANCES_ROOM_LOCK_DOOR
ret
diff --git a/scripts/LancesRoom.asm b/scripts/LancesRoom.asm
index 75215cba..772b33bf 100644
--- a/scripts/LancesRoom.asm
+++ b/scripts/LancesRoom.asm
@@ -10,8 +10,8 @@ LancesRoom_Script:
LanceShowOrHideEntranceBlocks:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_LANCES_ROOM_LOCK_DOOR
jr nz, .closeEntrance
@@ -63,7 +63,7 @@ LancesRoomDefaultScript:
cp $3 ; Is player standing next to Lance's sprite?
jr nc, .notStandingNextToLance
ld a, TEXT_LANCESROOM_LANCE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
.notStandingNextToLance
cp $5 ; Is player standing on the entrance staircase?
@@ -71,7 +71,7 @@ LancesRoomDefaultScript:
CheckAndSetEvent EVENT_LANCES_ROOM_LOCK_DOOR
ret nz
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ld a, SFX_GO_INSIDE
call PlaySound
jp LanceShowOrHideEntranceBlocks
@@ -90,7 +90,7 @@ LancesRoomLanceEndBattleScript:
cp $ff
jp z, ResetLanceScript
ld a, TEXT_LANCESROOM_LANCE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
WalkToLance:
diff --git a/scripts/LoreleisRoom.asm b/scripts/LoreleisRoom.asm
index c1cc2adb..455561b8 100644
--- a/scripts/LoreleisRoom.asm
+++ b/scripts/LoreleisRoom.asm
@@ -11,11 +11,11 @@ LoreleisRoom_Script:
LoreleiShowOrHideExitBlock:
; Blocks or clears the exit to the next room.
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
- ld hl, wBeatLorelei
- set 1, [hl]
+ ld hl, wElite4Flags
+ set BIT_STARTED_ELITE_4, [hl]
CheckEvent EVENT_BEAT_LORELEIS_ROOM_TRAINER_0
jr z, .blockExitToNextRoom
ld a, $5
@@ -77,7 +77,7 @@ LoreleisRoomDefaultScript:
jr z, LoreleiScriptWalkIntoRoom
.stopPlayerFromLeaving
ld a, TEXT_LORELEISROOM_DONT_RUN_AWAY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID ; "Don't run away!"
ld a, D_UP
ld [wSimulatedJoypadStatesEnd], a
@@ -113,7 +113,7 @@ LoreleisRoomLoreleiEndBattleScript:
cp $ff
jp z, ResetLoreleiScript
ld a, TEXT_LORELEISROOM_LORELEI
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
LoreleisRoom_TextPointers:
diff --git a/scripts/MtMoonB2F.asm b/scripts/MtMoonB2F.asm
index 0f336136..a110d877 100644
--- a/scripts/MtMoonB2F.asm
+++ b/scripts/MtMoonB2F.asm
@@ -10,12 +10,12 @@ MtMoonB2F_Script:
ld hl, MtMoonB2FFossilAreaCoords
call ArePlayerCoordsInArray
jr nc, .enable_battles
- ld hl, wd72e
- set 4, [hl]
+ ld hl, wStatusFlags4
+ set BIT_NO_BATTLES, [hl]
ret
.enable_battles
- ld hl, wd72e
- res 4, [hl]
+ ld hl, wStatusFlags4
+ res BIT_NO_BATTLES, [hl]
ret
MtMoonB2FFossilAreaCoords:
@@ -96,7 +96,7 @@ MtMoonB2FScript_49d28:
xor a
ldh [hJoyHeld], a
ld a, TEXT_MTMOONB2F_SUPER_NERD
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ret
@@ -197,15 +197,15 @@ MovementData_49ddd:
db -1 ; end
MtMoonB2FSuperNerdTakesOtherFossilScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_MTMOONB2F_SUPER_NERD_THEN_THIS_IS_MINE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
CheckEvent EVENT_GOT_HELIX_FOSSIL
jr z, .asm_49e1d
@@ -244,7 +244,7 @@ MtMoonB2FScript_49e15:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_MTMOONB2F_TEXT12
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -289,8 +289,8 @@ MtMoonB2FScript6:
MtMoonB2FScript7:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
MtMoonB2FScript8:
ld a, $2
@@ -311,8 +311,8 @@ MtMoonB2FScript9:
MtMoonB2FScript10:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
MtMoonB2FScript11:
ld a, $2
@@ -323,12 +323,12 @@ MtMoonB2FScript11:
ld a, ~(A_BUTTON | B_BUTTON)
ld [wJoyIgnore], a
ld a, TEXT_MTMOONB2F_TEXT13
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
MtMoonB2FScript12:
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, MtMoonB2FJessieJamesEndBattleText
ld de, MtMoonB2FJessieJamesEndBattleText
call SaveEndBattleTextPointers
@@ -361,7 +361,7 @@ MtMoonB2FScript13:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_MTMOONB2F_TEXT14
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -487,9 +487,9 @@ MtMoonB2FSuperNerdText:
.beat_super_nerd
ld hl, MtMoonB2FSuperNerdTheyreBothMineText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, MtMoonB2FSuperNerdOkIllShareText
ld de, MtMoonB2FSuperNerdOkIllShareText
call SaveEndBattleTextPointers
diff --git a/scripts/Museum1F.asm b/scripts/Museum1F.asm
index 9fff771d..0e65accd 100644
--- a/scripts/Museum1F.asm
+++ b/scripts/Museum1F.asm
@@ -1,5 +1,5 @@
Museum1F_Script:
- ld a, TRUE
+ ld a, 1 << BIT_NO_AUTO_TEXT_BOX
ld [wAutoTextBoxDrawingControl], a
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -27,7 +27,7 @@ Museum1FDefaultScript:
xor a
ldh [hJoyHeld], a
ld a, TEXT_MUSEUM1F_SCIENTIST1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
Museum1FNoopScript:
diff --git a/scripts/OaksLab.asm b/scripts/OaksLab.asm
index 17be9fc3..5be583d9 100644
--- a/scripts/OaksLab.asm
+++ b/scripts/OaksLab.asm
@@ -1,7 +1,7 @@
OaksLab_Script:
CheckEvent EVENT_PALLET_AFTER_GETTING_POKEBALLS_2
call nz, OaksLabLoadTextPointers2Script
- ld a, TRUE
+ ld a, 1 << BIT_NO_AUTO_TEXT_BOX
ld [wAutoTextBoxDrawingControl], a
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -45,8 +45,8 @@ OaksLabDefaultScript:
ld a, HS_OAKS_LAB_OAK_2
ld [wMissableObjectIndex], a
predef ShowObject
- ld hl, wd72e
- res 4, [hl]
+ ld hl, wStatusFlags4
+ res BIT_NO_BATTLES, [hl]
ld a, SCRIPT_OAKSLAB_OAK_ENTERS_LAB
ld [wOaksLabCurScript], a
@@ -69,8 +69,8 @@ OakEntryMovement:
db -1 ; end
OaksLabHideShowOaksScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_OAKS_LAB_OAK_2
ld [wMissableObjectIndex], a
@@ -121,8 +121,8 @@ OaksLabFollowedOakScript:
ld a, SPRITE_FACING_UP
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
- ld hl, wFlags_D733
- res 1, [hl]
+ ld hl, wStatusFlags7
+ res BIT_NO_MAP_MUSIC, [hl]
call PlayDefaultMusic
ld a, SCRIPT_OAKSLAB_OAK_CHOOSE_MON_SPEECH
@@ -134,11 +134,11 @@ OaksLabOakChooseMonSpeechScript:
ld a, SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_OAKSLAB_RIVAL_FED_UP_WITH_WAITING
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
ld a, TEXT_OAKSLAB_OAK_CHOOSE_MON
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
ld a, $2
@@ -146,11 +146,11 @@ OaksLabOakChooseMonSpeechScript:
ld a, SPRITE_FACING_UP
ld [wSprite01StateData1FacingDirection], a
ld a, TEXT_OAKSLAB_RIVAL_WHAT_ABOUT_ME
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
ld a, TEXT_OAKSLAB_OAK_BE_PATIENT
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
@@ -175,7 +175,7 @@ OaksLabPlayerDontGoAwayScript:
call SetSpriteFacingDirectionAndDelay
call UpdateSprites
ld a, TEXT_OAKSLAB_OAK_DONT_GO_AWAY_YET
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $1
ld [wSimulatedJoypadStatesIndex], a
@@ -201,7 +201,7 @@ OaksLabPlayerForcedToWalkBackScript:
OaksLabChoseStarterScript:
ld a, OAKSLAB_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
ld de, .RivalPushesPlayerAwayFromEeveeBall
call MoveSprite
ld a, SCRIPT_OAKSLAB_RIVAL_TAKES_POKEBALL
@@ -216,8 +216,8 @@ OaksLabChoseStarterScript:
db $FF
OaksLabRivalTakesPokeballScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
jr nz, .asm_1c564
ld a, HS_STARTER_BALL_1
ld [wMissableObjectIndex], a
@@ -230,12 +230,12 @@ OaksLabRivalTakesPokeballScript:
ld a, RIVAL_STARTER_JOLTEON
ld [wRivalStarter], a
ld a, EEVEE
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMonName
ld a, ~(A_BUTTON | B_BUTTON)
ld [wJoyIgnore], a
ld a, TEXT_OAKSLAB_RIVAL_RECEIVED_MON
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SCRIPT_OAKSLAB_PLAYER_WALKS_TO_OAK
@@ -293,7 +293,7 @@ OaksLabPlayerReceivesPikachuScript:
and a
ret nz
ld a, TEXT_OAKSLAB_PLAYER_RECEIVED_MON
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
@@ -317,7 +317,7 @@ OaksLabRivalChallengesPlayerScript:
ld a, MUSIC_MEET_RIVAL
call PlayMusic
ld a, TEXT_OAKSLAB_RIVAL_ILL_TAKE_YOU_ON
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $1
ldh [hNPCPlayerRelativePosPerspective], a
@@ -338,8 +338,8 @@ OaksLabRivalChallengesPlayerScript:
ret
OaksLabRivalStartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, OAKSLAB_RIVAL
@@ -352,9 +352,9 @@ OaksLabRivalStartBattleScript:
ld hl, OaksLabRivalIPickedTheWrongPokemonText
ld de, OaksLabRivalAmIGreatOrWhatText
call SaveEndBattleTextPointers
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
xor a
ld [wJoyIgnore], a
ld a, PLAYER_DIR_UP
@@ -403,7 +403,7 @@ OaksLabRivalStartsExitScript:
ld c, 20
call DelayFrames
ld a, TEXT_OAKSLAB_RIVAL_SMELL_YOU_LATER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
farcall Music_RivalAlternateStart
ld a, OAKSLAB_RIVAL
@@ -436,8 +436,8 @@ OaksLabRivalStartsExitScript:
db -1 ; end
OaksLabPlayerWatchRivalExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
jr nz, .checkRivalPosition
ld a, ~(A_BUTTON | B_BUTTON)
ld [wJoyIgnore], a
@@ -478,7 +478,7 @@ OaksLabPikachuEscapesPokeballScript:
farcall SchedulePikachuSpawnForAfterText
call EnablePikachuOverworldSpriteDrawing
ld a, TEXT_OAKSLAB_PIKACHU_DISLIKES_POKEBALLS1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SCRIPT_OAKSLAB_PIKACHU_DISLIKES_POKEBALLS
ld [wOaksLabCurScript], a
@@ -486,7 +486,7 @@ OaksLabPikachuEscapesPokeballScript:
OaksLabPikachuDislikesPokeballsScript:
ld a, TEXT_OAKSLAB_PIKACHU_DISLIKES_POKEBALLS2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
@@ -501,7 +501,7 @@ OaksLabRivalArrivesAtOaksRequestScript:
call StopAllMusic
farcall Music_RivalAlternateStart
ld a, TEXT_OAKSLAB_RIVAL_GRAMPS
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
callfar OaksLabPikachuMovementScript
call OaksLabCalcRivalMovementScript
@@ -539,8 +539,8 @@ OaksLabRivalFaceUpOakFaceDownScript:
ret
OaksLabOakGivesPokedexScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
call EnableAutoTextBoxDrawing
call PlayDefaultMusic
@@ -548,21 +548,21 @@ OaksLabOakGivesPokedexScript:
ld [wJoyIgnore], a
call OaksLabRivalFaceUpOakFaceDownScript
ld a, TEXT_OAKSLAB_RIVAL_MY_POKEMON_HAS_GROWN_STRONGER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call DelayFrame
call OaksLabRivalFaceUpOakFaceDownScript
ld a, TEXT_OAKSLAB_OAK_I_HAVE_A_REQUEST
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call DelayFrame
call OaksLabRivalFaceUpOakFaceDownScript
ld a, TEXT_OAKSLAB_OAK_MY_INVENTION_POKEDEX
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call DelayFrame
ld a, TEXT_OAKSLAB_OAK_GOT_POKEDEX
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
ld a, HS_POKEDEX_1
@@ -573,7 +573,7 @@ OaksLabOakGivesPokedexScript:
predef HideObject
call OaksLabRivalFaceUpOakFaceDownScript
ld a, TEXT_OAKSLAB_OAK_THAT_WAS_MY_DREAM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, OAKSLAB_RIVAL
ldh [hSpriteIndex], a
@@ -582,7 +582,7 @@ OaksLabOakGivesPokedexScript:
call SetSpriteFacingDirectionAndDelay
call Delay3
ld a, TEXT_OAKSLAB_RIVAL_LEAVE_IT_ALL_TO_ME
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_POKEDEX
ld a, SCRIPT_VIRIDIANCITY_AFTER_POKEDEX
@@ -604,7 +604,7 @@ OaksLabOakGivesPokedexScript:
call StopAllMusic
farcall Music_RivalAlternateStart
ld a, OAKSLAB_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
ld de, wNPCMovementDirections2
call MoveSprite
@@ -613,8 +613,8 @@ OaksLabOakGivesPokedexScript:
ret
OaksLabRivalLeavesWithPokedexScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
call PlayDefaultMusic
ld a, HS_OAKS_LAB_RIVAL
@@ -837,8 +837,8 @@ OaksLabOak1Text:
jr nz, .mon_around_the_world
CheckEventReuseA EVENT_BATTLED_RIVAL_IN_OAKS_LAB
jr nz, .check_got_parcel
- ld a, [wd72e]
- bit 3, a
+ ld a, [wStatusFlags4]
+ bit BIT_GOT_STARTER, a
jr nz, .already_got_pokemon
ld hl, .GoAheadItsYours
call PrintText
@@ -1018,7 +1018,7 @@ OaksLabPlayerReceivedMonText:
text_asm
ld a, STARTER_PIKACHU
ld [wPlayerStarter], a
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetMonName
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -1029,17 +1029,17 @@ OaksLabPlayerReceivedMonText:
xor a
ld [wMonDataLocation], a
ld a, 5
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
ld a, STARTER_PIKACHU
- ld [wd11e], a
- ld [wcf91], a
+ ld [wPokedexNum], a
+ ld [wCurPartySpecies], a
call AddPartyMon
ld a, LIGHT_BALL_GSC
ld [wPartyMon1CatchRate], a
call DisablePikachuOverworldSpriteDrawing
SetEvent EVENT_GOT_STARTER
- ld hl, wd72e
- set 3, [hl]
+ ld hl, wStatusFlags4
+ set BIT_GOT_STARTER, [hl]
jp TextScriptEnd
OaksLabOakGivesText:
diff --git a/scripts/PalletTown.asm b/scripts/PalletTown.asm
index 9c8ab449..5bdd774b 100644
--- a/scripts/PalletTown.asm
+++ b/scripts/PalletTown.asm
@@ -57,7 +57,7 @@ PalletTownOakHeyWaitScript:
xor a
ld [wOakWalkedToPlayer], a
ld a, TEXT_PALLETTOWN_OAK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -103,8 +103,8 @@ PalletTownOakWalksToPlayerScript:
ret
PalletTownOakGreetsPlayerScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, ~(A_BUTTON | B_BUTTON)
ld [wJoyIgnore], a
@@ -115,7 +115,7 @@ PalletTownOakGreetsPlayerScript:
ld a, SPRITE_FACING_UP
ld [wSprite01StateData1FacingDirection], a
ld a, TEXT_PALLETTOWN_OAK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
; oak faces the horizontally adjacent patch of grass to face pikachu
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
@@ -145,7 +145,7 @@ PalletTownPikachuBattleScript:
ld a, STARTER_PIKACHU
ld [wCurOpponent], a
ld a, 5
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
; trigger the next script
ld a, SCRIPT_PALLETTOWN_AFTER_PIKACHU_BATTLE
@@ -156,14 +156,14 @@ PalletTownAfterPikachuBattleScript:
ld a, 2
ld [wOakWalkedToPlayer], a
ld a, TEXT_PALLETTOWN_OAK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $2
ld [wSprite01StateData1MovementStatus], a
ld a, SPRITE_FACING_UP
ld [wSprite01StateData1FacingDirection], a
ld a, TEXT_PALLETTOWN_OAK_COME_WITH_ME
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
diff --git a/scripts/PewterCity.asm b/scripts/PewterCity.asm
index 9437a55d..6cd96acc 100644
--- a/scripts/PewterCity.asm
+++ b/scripts/PewterCity.asm
@@ -37,7 +37,7 @@ ENDC
ld a, SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_PEWTERCITY_YOUNGSTER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
PewterCityPlayerLeavingEastCoords:
@@ -60,10 +60,10 @@ PewterCitySuperNerd1ShowsPlayerMuseumScript:
ldh [hSpriteImageIndex], a
call SpriteFunc_34a1
call PlayDefaultMusic
- ld hl, wFlags_0xcd60
- set 4, [hl]
+ ld hl, wMiscFlags
+ set BIT_NO_SPRITE_UPDATES, [hl]
ld a, TEXT_PEWTERCITY_SUPER_NERD1_ITS_RIGHT_HERE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $3c
ldh [hSpriteScreenYCoord], a
@@ -92,8 +92,8 @@ MovementData_PewterMuseumGuyExit:
db -1 ; end
PewterCityHideSuperNerd1Script:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_MUSEUM_GUY
ld [wMissableObjectIndex], a
@@ -125,10 +125,10 @@ PewterCityYoungsterShowsPlayerGymScript:
ldh [hSpriteFacingDirection], a
call SpriteFunc_34a1
call PlayDefaultMusic
- ld hl, wFlags_0xcd60
- set 4, [hl]
+ ld hl, wMiscFlags
+ set BIT_NO_SPRITE_UPDATES, [hl]
ld a, TEXT_PEWTERCITY_YOUNGSTER_GO_TAKE_ON_BROCK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $3c
ldh [hSpriteScreenYCoord], a
@@ -158,8 +158,8 @@ MovementData_PewterGymGuyExit:
db -1 ; end
PewterCityHideYoungsterScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_GYM_GUY
ld [wMissableObjectIndex], a
diff --git a/scripts/PewterGym.asm b/scripts/PewterGym.asm
index a2f4eaa3..b8d8898f 100644
--- a/scripts/PewterGym.asm
+++ b/scripts/PewterGym.asm
@@ -1,7 +1,7 @@
PewterGym_Script:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, .LoadNames
call EnableAutoTextBoxDrawing
ld hl, PewterGymTrainerHeaders
@@ -46,20 +46,20 @@ PewterGymBrockPostBattle:
; fallthrough
PewterGymScriptReceiveTM34:
ld a, TEXT_PEWTERGYM_BROCK_WAIT_TAKE_THIS
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_BROCK
lb bc, TM_BIDE, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_PEWTERGYM_RECEIVED_TM34
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM34
jr .gymVictory
.BagFull
ld a, TEXT_PEWTERGYM_TM34_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -112,9 +112,9 @@ PewterGymBrockText:
.beforeBeat
ld hl, .PreBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, PewterGymBrockReceivedBoulderBadgeText
ld de, PewterGymBrockReceivedBoulderBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/PewterMart.asm b/scripts/PewterMart.asm
index 0a5baac2..49a91977 100644
--- a/scripts/PewterMart.asm
+++ b/scripts/PewterMart.asm
@@ -1,6 +1,6 @@
PewterMart_Script:
call EnableAutoTextBoxDrawing
- ld a, TRUE
+ ld a, 1 << BIT_NO_AUTO_TEXT_BOX
ld [wAutoTextBoxDrawingControl], a
ret
diff --git a/scripts/PokemonFanClub.asm b/scripts/PokemonFanClub.asm
index a648b92b..f14b126b 100644
--- a/scripts/PokemonFanClub.asm
+++ b/scripts/PokemonFanClub.asm
@@ -238,11 +238,11 @@ PokemonFanClubChairmanText:
.print
xor a
ld [wUpdateSpritesEnabled], a
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
callfar PrintFanClubPortrait
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call GBPalWhiteOutWithDelay3
call ReloadTilesetTilePatterns
call RestoreScreenTilesAndReloadTilePatterns
diff --git a/scripts/PokemonMansion1F.asm b/scripts/PokemonMansion1F.asm
index b294a247..d06a234a 100644
--- a/scripts/PokemonMansion1F.asm
+++ b/scripts/PokemonMansion1F.asm
@@ -10,8 +10,8 @@ PokemonMansion1F_Script:
Mansion1CheckReplaceSwitchDoorBlocks:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_MANSION_SWITCH_ON
jr nz, .switchTurnedOn
@@ -52,7 +52,7 @@ Mansion1Script_Switches::
xor a
ldh [hJoyHeld], a
ld a, TEXT_POKEMONMANSION1F_SWITCH
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
PokemonMansion1F_ScriptPointers:
@@ -103,7 +103,7 @@ PokemonMansion1FSwitchText:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ld hl, .PressedText
call PrintText
ld a, SFX_GO_INSIDE
diff --git a/scripts/PokemonMansion2F.asm b/scripts/PokemonMansion2F.asm
index bc3d78e9..7da9e50f 100644
--- a/scripts/PokemonMansion2F.asm
+++ b/scripts/PokemonMansion2F.asm
@@ -10,8 +10,8 @@ PokemonMansion2F_Script:
Mansion2CheckReplaceSwitchDoorBlocks:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_MANSION_SWITCH_ON
jr nz, .switchTurnedOn
@@ -48,7 +48,7 @@ Mansion2Script_Switches::
xor a
ldh [hJoyHeld], a
ld a, TEXT_POKEMONMANSION2F_SWITCH
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
PokemonMansion2F_ScriptPointers:
@@ -108,7 +108,7 @@ PokemonMansion2FSwitchText:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ld hl, .PressedText
call PrintText
ld a, SFX_GO_INSIDE
diff --git a/scripts/PokemonMansion3F.asm b/scripts/PokemonMansion3F.asm
index f64357d5..de8bd1dd 100644
--- a/scripts/PokemonMansion3F.asm
+++ b/scripts/PokemonMansion3F.asm
@@ -10,8 +10,8 @@ PokemonMansion3F_Script:
Mansion3CheckReplaceSwitchDoorBlocks:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_MANSION_SWITCH_ON
jr nz, .switchTurnedOn
@@ -60,17 +60,17 @@ PokemonMansion3FDefaultScript:
.isPlayerFallingDownHole:
xor a
ld [wWhichDungeonWarp], a
- ld a, [wd72d]
- bit 4, a
+ ld a, [wStatusFlags3]
+ bit BIT_ON_DUNGEON_WARP, a
ret nz
call ArePlayerCoordsInArray
ret nc
ld a, [wCoordIndex]
ld [wWhichDungeonWarp], a
- ld hl, wd72d
- set 4, [hl]
- ld hl, wd732
- set 4, [hl]
+ ld hl, wStatusFlags3
+ set BIT_ON_DUNGEON_WARP, [hl]
+ ld hl, wStatusFlags6
+ set BIT_DUNGEON_WARP, [hl]
ret
Mansion3Script_Switches::
@@ -80,7 +80,7 @@ Mansion3Script_Switches::
xor a
ldh [hJoyHeld], a
ld a, TEXT_POKEMONMANSION3F_SWITCH
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
PokemonMansion3F_TextPointers:
diff --git a/scripts/PokemonMansionB1F.asm b/scripts/PokemonMansionB1F.asm
index 74f1648e..e31bbd3e 100644
--- a/scripts/PokemonMansionB1F.asm
+++ b/scripts/PokemonMansionB1F.asm
@@ -10,8 +10,8 @@ PokemonMansionB1F_Script:
MansionB1FCheckReplaceSwitchDoorBlocks:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_MANSION_SWITCH_ON
jr nz, .switchTurnedOn
@@ -50,7 +50,7 @@ Mansion4Script_Switches::
xor a
ldh [hJoyHeld], a
ld a, TEXT_POKEMONMANSIONB1F_SWITCH
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
PokemonMansionB1F_ScriptPointers:
diff --git a/scripts/PokemonTower2F.asm b/scripts/PokemonTower2F.asm
index b4d09619..4a7abbb6 100644
--- a/scripts/PokemonTower2F.asm
+++ b/scripts/PokemonTower2F.asm
@@ -49,7 +49,7 @@ ENDC
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_POKEMONTOWER2F_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ldh [hJoyHeld], a
@@ -69,7 +69,7 @@ PokemonTower2FDefeatedRivalScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_POKEMON_TOWER_RIVAL
ld a, TEXT_POKEMONTOWER2F_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld de, PokemonTower2FRivalDownThenRightMovement
CheckEvent EVENT_POKEMON_TOWER_RIVAL_ON_LEFT
@@ -110,8 +110,8 @@ PokemonTower2FRivalDownThenRightMovement:
db -1 ; end
PokemonTower2FRivalExitsScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_POKEMON_TOWER_2F_RIVAL
ld [wMissableObjectIndex], a
@@ -139,9 +139,9 @@ PokemonTower2FRivalText:
.do_battle
ld hl, .WhatBringsYouHereText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .DefeatedText
ld de, .VictoryText
call SaveEndBattleTextPointers
diff --git a/scripts/PokemonTower5F.asm b/scripts/PokemonTower5F.asm
index 6482993d..b35a2f0a 100644
--- a/scripts/PokemonTower5F.asm
+++ b/scripts/PokemonTower5F.asm
@@ -17,8 +17,8 @@ PokemonTower5FDefaultScript:
ld hl, PokemonTower5FPurifiedZoneCoords
call ArePlayerCoordsInArray
jr c, .in_purified_zone
- ld hl, wd72e
- res 4, [hl]
+ ld hl, wStatusFlags4
+ res BIT_NO_BATTLES, [hl]
ResetEvent EVENT_IN_PURIFIED_ZONE
jp CheckFightingMapTrainers
.in_purified_zone
@@ -28,15 +28,15 @@ PokemonTower5FDefaultScript:
ldh [hJoyHeld], a
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld hl, wd72e
- set 4, [hl]
+ ld hl, wStatusFlags4
+ set BIT_NO_BATTLES, [hl]
predef HealParty
call GBFadeOutToWhite
call Delay3
call Delay3
call GBFadeInFromWhite
ld a, TEXT_POKEMONTOWER5F_PURIFIEDZONE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
diff --git a/scripts/PokemonTower6F.asm b/scripts/PokemonTower6F.asm
index f2e99586..cf246c56 100644
--- a/scripts/PokemonTower6F.asm
+++ b/scripts/PokemonTower6F.asm
@@ -31,12 +31,12 @@ PokemonTower6FDefaultScript:
xor a
ldh [hJoyHeld], a
ld a, TEXT_POKEMONTOWER6F_BEGONE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, RESTLESS_SOUL
ld [wCurOpponent], a
ld a, 30
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
ld a, SCRIPT_POKEMONTOWER6F_MAROWAK_BATTLE
ld [wPokemonTower6FCurScript], a
ld [wCurMapScript], a
@@ -52,8 +52,8 @@ PokemonTower6FMarowakBattleScript:
jp z, PokemonTower6FSetDefaultScript
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd72d]
- bit 6, a
+ ld a, [wStatusFlags3]
+ bit BIT_TALKED_TO_TRAINER, a
ret nz
call UpdateSprites
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
@@ -63,7 +63,7 @@ PokemonTower6FMarowakBattleScript:
jr nz, .did_not_defeat
SetEvent EVENT_BEAT_GHOST_MAROWAK
ld a, TEXT_POKEMONTOWER6F_MAROWAK_DEPARTED
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
@@ -79,8 +79,8 @@ PokemonTower6FMarowakBattleScript:
xor a
ld [wSpritePlayerStateData2MovementByte1], a
ld [wOverrideSimulatedJoypadStatesMask], a
- ld hl, wd730
- set 7, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, SCRIPT_POKEMONTOWER6F_PLAYER_MOVING
ld [wPokemonTower6FCurScript], a
ld [wCurMapScript], a
diff --git a/scripts/PokemonTower7F.asm b/scripts/PokemonTower7F.asm
index 5334afd2..79c091b6 100644
--- a/scripts/PokemonTower7F.asm
+++ b/scripts/PokemonTower7F.asm
@@ -64,7 +64,7 @@ PokemonTower7FScript_60d2a:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_POKEMONTOWER7F_TEXT4
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -87,7 +87,7 @@ PokemonTower7FScript1:
ld de, PokemonTower7FMovementData_60d7a
.asm_60d8c
ld a, POKEMONTOWER7F_JESSIE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -98,8 +98,8 @@ PokemonTower7FScript1:
PokemonTower7FScript2:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
PokemonTower7FScript3:
ld a, SPRITE_FACING_DOWN
@@ -118,7 +118,7 @@ PokemonTower7FScript4:
ld de, PokemonTower7FMovementData_60d7b
.asm_60dcc
ld a, POKEMONTOWER7F_JAMES
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -129,8 +129,8 @@ PokemonTower7FScript4:
PokemonTower7FScript5:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
PokemonTower7FScript6:
ld a, $2
@@ -146,12 +146,12 @@ PokemonTower7FScript6:
ld a, ~(A_BUTTON | B_BUTTON)
ld [wJoyIgnore], a
ld a, TEXT_POKEMONTOWER7F_TEXT5
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
PokemonTower7FScript7:
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, PokemonTower7FJessieJamesEndBattleText
ld de, PokemonTower7FJessieJamesEndBattleText
call SaveEndBattleTextPointers
@@ -183,7 +183,7 @@ PokemonTower7FScript8:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_POKEMONTOWER7F_TEXT6
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -248,8 +248,8 @@ PokemonTower7FWarpToMrFujiHouseScript:
ld [wDestinationWarpID], a
ld a, LAVENDER_TOWN
ld [wLastMap], a
- ld hl, wd72d
- set 3, [hl]
+ ld hl, wStatusFlags3
+ set BIT_WARP_FROM_CUR_SCRIPT, [hl]
ld a, SCRIPT_POKEMONTOWER7F_SCRIPT0
ld [wPokemonTower7FCurScript], a
ret
diff --git a/scripts/RedsHouse1F_2.asm b/scripts/RedsHouse1F_2.asm
index c7e37989..a7c8d051 100644
--- a/scripts/RedsHouse1F_2.asm
+++ b/scripts/RedsHouse1F_2.asm
@@ -1,6 +1,6 @@
RedsHouse1FPrintMomText::
- ld a, [wd72e]
- bit 3, a ; received a Pokémon from Oak?
+ ld a, [wStatusFlags4]
+ bit BIT_GOT_STARTER, a
jp nz, RedsHouse1FMomHealScript
ld hl, .WakeUpText
call PrintText
diff --git a/scripts/RocketHideoutB1F.asm b/scripts/RocketHideoutB1F.asm
index f6c64bda..9354a0c7 100644
--- a/scripts/RocketHideoutB1F.asm
+++ b/scripts/RocketHideoutB1F.asm
@@ -10,8 +10,8 @@ RocketHideoutB1F_Script:
RocketHideoutB1FDoorCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEvent EVENT_677
jr nz, .door_open
diff --git a/scripts/RocketHideoutB2F.asm b/scripts/RocketHideoutB2F.asm
index 3a7ffa9b..7a5c2e4a 100644
--- a/scripts/RocketHideoutB2F.asm
+++ b/scripts/RocketHideoutB2F.asm
@@ -23,8 +23,8 @@ RocketHideoutB2FDefaultScript:
call DecodeArrowMovementRLE
cp $ff
jp z, CheckFightingMapTrainers
- ld hl, wd736
- set 7, [hl]
+ ld hl, wMovementFlags
+ set BIT_SPINNING, [hl]
call StartSimulatingJoypadStates
ld a, SFX_ARROW_TILES
call PlaySound
@@ -262,8 +262,8 @@ RocketHideoutB2FPlayerSpinningScript:
jr nz, LoadSpinnerArrowTiles
xor a
ld [wJoyIgnore], a
- ld hl, wd736
- res 7, [hl]
+ ld hl, wMovementFlags
+ res BIT_SPINNING, [hl]
ld a, SCRIPT_ROCKETHIDEOUTB2F_DEFAULT
ld [wCurMapScript], a
ret
diff --git a/scripts/RocketHideoutB3F.asm b/scripts/RocketHideoutB3F.asm
index 03681bef..0c0e02ea 100644
--- a/scripts/RocketHideoutB3F.asm
+++ b/scripts/RocketHideoutB3F.asm
@@ -23,8 +23,8 @@ RocketHideoutB3FDefaultScript:
call DecodeArrowMovementRLE
cp $ff
jp z, CheckFightingMapTrainers
- ld hl, wd736
- set 7, [hl]
+ ld hl, wMovementFlags
+ set BIT_SPINNING, [hl]
call StartSimulatingJoypadStates
ld a, SFX_ARROW_TILES
call PlaySound
@@ -119,8 +119,8 @@ RocketHideoutB3FPlayerSpinningScript:
jp nz, LoadSpinnerArrowTiles
xor a
ld [wJoyIgnore], a
- ld hl, wd736
- res 7, [hl]
+ ld hl, wMovementFlags
+ res BIT_SPINNING, [hl]
ld a, SCRIPT_ROCKETHIDEOUTB3F_DEFAULT
ld [wCurMapScript], a
ret
@@ -165,7 +165,7 @@ RocketHideoutB3FRocket2Text:
jp TextScriptEnd
RocketHideoutB3FRocket2BattleText:
- text_far _RocketHideout3BattleTxt
+ text_far _RocketHideout3BattleText
text_end
RocketHideoutB3FRocket2EndBattleText:
diff --git a/scripts/RocketHideoutB4F.asm b/scripts/RocketHideoutB4F.asm
index 81e11696..2365ff70 100644
--- a/scripts/RocketHideoutB4F.asm
+++ b/scripts/RocketHideoutB4F.asm
@@ -49,7 +49,7 @@ RocketHideoutB4FBeatGiovanniScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_ROCKET_HIDEOUT_GIOVANNI
ld a, TEXT_ROCKETHIDEOUTB4F_GIOVANNI_HOPE_WE_MEET_AGAIN
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call GBFadeOutToBlack
ld a, HS_ROCKET_HIDEOUT_B4F_GIOVANNI
@@ -63,7 +63,7 @@ RocketHideoutB4FBeatGiovanniScript:
xor a
ld [wJoyIgnore], a
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ld a, SCRIPT_ROCKETHIDEOUTB4F_DEFAULT
ld [wRocketHideoutB4FCurScript], a
ld [wCurMapScript], a
@@ -108,7 +108,7 @@ RocketHideoutB4FScript_455a5:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_ROCKETHIDEOUTB4F_TEXT11
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -137,7 +137,7 @@ RocketHideoutB4FScript4:
ld de, RocketHideoutB4FJessieJamesMovementData_45606
.asm_45617
ld a, ROCKETHIDEOUTB4F_JAMES
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -148,8 +148,8 @@ RocketHideoutB4FScript4:
RocketHideoutB4FScript5:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
RocketHideoutB4FScript6:
ld a, $2
@@ -171,7 +171,7 @@ RocketHideoutB4FScript7:
ld de, RocketHideoutB4FJessieJamesMovementData_45605
.asm_4565f
ld a, ROCKETHIDEOUTB4F_JESSIE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -182,8 +182,8 @@ RocketHideoutB4FScript7:
RocketHideoutB4FScript8:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -199,12 +199,12 @@ RocketHideoutB4FScript9:
.asm_45697
call Delay3
ld a, TEXT_ROCKETHIDEOUTB4F_TEXT12
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
RocketHideoutB4FScript10:
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, RocketHideoutB4FJessieJamesEndBattleText
ld de, RocketHideoutB4FJessieJamesEndBattleText
call SaveEndBattleTextPointers
@@ -237,7 +237,7 @@ RocketHideoutB4FScript11:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_ROCKETHIDEOUTB4F_TEXT13
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -350,9 +350,9 @@ RocketHideoutB4FGiovanniText:
jp nz, .beat_giovanni
ld hl, .ImpressedYouGotHereText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .WhatCannotBeText
ld de, .WhatCannotBeText
call SaveEndBattleTextPointers
diff --git a/scripts/RocketHideoutElevator.asm b/scripts/RocketHideoutElevator.asm
index 71ff0758..bd6fb498 100644
--- a/scripts/RocketHideoutElevator.asm
+++ b/scripts/RocketHideoutElevator.asm
@@ -1,12 +1,12 @@
RocketHideoutElevator_Script:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
push hl
call nz, RocketHideoutElevatorStoreWarpEntriesScript
pop hl
- bit 7, [hl]
- res 7, [hl]
+ bit BIT_CUR_MAP_USED_ELEVATOR, [hl]
+ res BIT_CUR_MAP_USED_ELEVATOR, [hl]
call nz, RocketHideoutElevatorShakeScript
xor a
ld [wAutoTextBoxDrawingControl], a
diff --git a/scripts/Route11Gate2F.asm b/scripts/Route11Gate2F.asm
index da690ad6..c9f183e1 100644
--- a/scripts/Route11Gate2F.asm
+++ b/scripts/Route11Gate2F.asm
@@ -24,7 +24,7 @@ Route11Gate2FOaksAideText:
ldh [hOaksAideRequirement], a
ld a, ITEMFINDER
ldh [hOaksAideRewardItem], a
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetItemName
ld h, d
ld l, e
diff --git a/scripts/Route12.asm b/scripts/Route12.asm
index ea7b66ca..ea9fc567 100644
--- a/scripts/Route12.asm
+++ b/scripts/Route12.asm
@@ -28,12 +28,12 @@ Route12DefaultScript:
ResetEventReuseHL EVENT_FIGHT_ROUTE12_SNORLAX
jp z, CheckFightingMapTrainers
ld a, TEXT_ROUTE12_SNORLAX_WOKE_UP
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SNORLAX
ld [wCurOpponent], a
ld a, 30
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
ld a, HS_ROUTE_12_SNORLAX
ld [wMissableObjectIndex], a
predef HideObject
@@ -51,7 +51,7 @@ Route12SnorlaxPostBattleScript:
cp $2
jr z, .caught_snorlax
ld a, TEXT_ROUTE12_SNORLAX_CALMED_DOWN
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.caught_snorlax
SetEvent EVENT_BEAT_ROUTE12_SNORLAX
diff --git a/scripts/Route12SuperRodHouse.asm b/scripts/Route12SuperRodHouse.asm
index 551949d0..54867248 100644
--- a/scripts/Route12SuperRodHouse.asm
+++ b/scripts/Route12SuperRodHouse.asm
@@ -7,8 +7,8 @@ Route12SuperRodHouse_TextPointers:
Route12SuperRodHouseFishingGuruText:
text_asm
- ld a, [wd728]
- bit 5, a ; received super rod?
+ ld a, [wStatusFlags1]
+ bit BIT_GOT_SUPER_ROD, a
jr nz, .got_item
ld hl, .DoYouLikeToFishText
call PrintText
@@ -19,8 +19,8 @@ Route12SuperRodHouseFishingGuruText:
lb bc, SUPER_ROD, 1
call GiveItem
jr nc, .bag_full
- ld hl, wd728
- set 5, [hl] ; received super rod
+ ld hl, wStatusFlags1
+ set BIT_GOT_SUPER_ROD, [hl]
ld hl, .ReceivedSuperRodText
jr .done
.bag_full
diff --git a/scripts/Route15Gate2F.asm b/scripts/Route15Gate2F.asm
index 0e04367b..831b66e6 100644
--- a/scripts/Route15Gate2F.asm
+++ b/scripts/Route15Gate2F.asm
@@ -14,9 +14,9 @@ Route15Gate2FOaksAideText:
ldh [hOaksAideRequirement], a
ld a, EXP_ALL
ldh [hOaksAideRewardItem], a
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetItemName
- ld hl, wcd6d
+ ld hl, wNameBuffer
ld de, wOaksAideRewardItemName
ld bc, ITEM_NAME_LENGTH
call CopyData
diff --git a/scripts/Route16.asm b/scripts/Route16.asm
index f51bd00e..6e3da97c 100644
--- a/scripts/Route16.asm
+++ b/scripts/Route16.asm
@@ -28,12 +28,12 @@ Route16DefaultScript:
ResetEventReuseHL EVENT_FIGHT_ROUTE16_SNORLAX
jp z, CheckFightingMapTrainers
ld a, TEXT_ROUTE16_SNORLAX_WOKE_UP
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SNORLAX
ld [wCurOpponent], a
ld a, 30
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
ld a, HS_ROUTE_16_SNORLAX
ld [wMissableObjectIndex], a
predef HideObject
@@ -52,7 +52,7 @@ Route16SnorlaxPostBattleScript:
cp $2
jr z, .caught
ld a, TEXT_ROUTE16_SNORLAX_RETURNED_TO_MOUNTAINS
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.caught
SetEvent EVENT_BEAT_ROUTE16_SNORLAX
diff --git a/scripts/Route16Gate1F.asm b/scripts/Route16Gate1F.asm
index 2d9777fc..a8bf2f0f 100644
--- a/scripts/Route16Gate1F.asm
+++ b/scripts/Route16Gate1F.asm
@@ -1,6 +1,6 @@
Route16Gate1F_Script:
- ld hl, wd732
- res 5, [hl]
+ ld hl, wStatusFlags6
+ res BIT_ALWAYS_ON_BIKE, [hl]
call EnableAutoTextBoxDrawing
ld a, [wRoute16Gate1FCurScript]
ld hl, Route16Gate1F_ScriptPointers
@@ -20,7 +20,7 @@ Route16Gate1FDefaultScript:
call ArePlayerCoordsInArray
ret nc
ld a, TEXT_ROUTE16GATE1F_GUARD_WAIT_UP
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ldh [hJoyHeld], a
@@ -60,7 +60,7 @@ Route16Gate1FPlayerMovingUpScript:
Route16Gate1FGuardScript:
ld a, TEXT_ROUTE16GATE1F_GUARD
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $1
ld [wSimulatedJoypadStatesIndex], a
@@ -77,8 +77,8 @@ Route16Gate1FPlayerMovingRightScript:
ret nz
xor a
ld [wJoyIgnore], a
- ld hl, wd730
- res 7, [hl]
+ ld hl, wStatusFlags5
+ res BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, SCRIPT_ROUTE16GATE1F_DEFAULT
ld [wRoute16Gate1FCurScript], a
ret
diff --git a/scripts/Route18Gate1F.asm b/scripts/Route18Gate1F.asm
index 8f08638c..a2b4dcdf 100644
--- a/scripts/Route18Gate1F.asm
+++ b/scripts/Route18Gate1F.asm
@@ -1,6 +1,6 @@
Route18Gate1F_Script:
- ld hl, wd732
- res 5, [hl]
+ ld hl, wStatusFlags6
+ res BIT_ALWAYS_ON_BIKE, [hl]
call EnableAutoTextBoxDrawing
ld a, [wRoute18Gate1FCurScript]
ld hl, Route18Gate1F_ScriptPointers
@@ -20,7 +20,7 @@ Route18Gate1FDefaultScript:
call ArePlayerCoordsInArray
ret nc
ld a, TEXT_ROUTE18GATE1F_GUARD_EXCUSE_ME
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ldh [hJoyHeld], a
@@ -60,7 +60,7 @@ Route18Gate1FPlayerMovingUpScript:
Route18Gate1FGuardScript:
ld a, TEXT_ROUTE18GATE1F_GUARD
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, $1
ld [wSimulatedJoypadStatesIndex], a
@@ -77,8 +77,8 @@ Route18Gate1FPlayerMovingRightScript:
ret nz
xor a
ld [wJoyIgnore], a
- ld hl, wd730
- res 7, [hl]
+ ld hl, wStatusFlags5
+ res BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, SCRIPT_ROUTE18GATE1F_DEFAULT
ld [wRoute18Gate1FCurScript], a
ret
diff --git a/scripts/Route22.asm b/scripts/Route22.asm
index 40e2ea92..d4149252 100644
--- a/scripts/Route22.asm
+++ b/scripts/Route22.asm
@@ -103,8 +103,8 @@ Route22FirstRivalBattleScript:
ret
Route22Rival1StartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, [wSavedCoordIndex]
cp 1 ; index of second, lower entry in Route22DefaultScript.Route22RivalBattleCoords
@@ -123,11 +123,11 @@ Route22Rival1StartBattleScript:
xor a
ld [wJoyIgnore], a
ld a, TEXT_ROUTE22_RIVAL1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, Route22Rival1DefeatedText
ld de, Route22Rival1VictoryText
call SaveEndBattleTextPointers
@@ -170,7 +170,7 @@ Route22Rival1AfterBattleScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE
ld a, TEXT_ROUTE22_RIVAL1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call StopAllMusic
farcall Music_RivalAlternateStart
@@ -221,8 +221,8 @@ Route22Rival1ExitMovementData2:
db -1 ; end
Route22Rival1ExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
@@ -256,8 +256,8 @@ Route22SecondRivalBattleScript:
ret
Route22Rival2StartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, ROUTE22_RIVAL2
ldh [hSpriteIndex], a
@@ -278,11 +278,11 @@ Route22Rival2StartBattleScript:
xor a
ld [wJoyIgnore], a
ld a, TEXT_ROUTE22_RIVAL2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, Route22Rival2DefeatedText
ld de, Route22Rival2VictoryText
call SaveEndBattleTextPointers
@@ -323,7 +323,7 @@ Route22Rival2AfterBattleScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_ROUTE22_RIVAL_2ND_BATTLE
ld a, TEXT_ROUTE22_RIVAL2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call StopAllMusic
farcall Music_RivalAlternateStartAndTempo
@@ -359,8 +359,8 @@ Route22Rival2ExitMovementData2:
db -1 ; end
Route22Rival2ExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
diff --git a/scripts/Route22Gate.asm b/scripts/Route22Gate.asm
index 4ed252d4..97b4ae6a 100644
--- a/scripts/Route22Gate.asm
+++ b/scripts/Route22Gate.asm
@@ -27,7 +27,7 @@ Route22GateDefaultScript:
ld a, SPRITE_FACING_LEFT
ld [wSprite01StateData1FacingDirection], a
ld a, TEXT_ROUTE22GATE_GUARD
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ret
diff --git a/scripts/Route23.asm b/scripts/Route23.asm
index 044d5e50..ac4853d8 100644
--- a/scripts/Route23.asm
+++ b/scripts/Route23.asm
@@ -7,8 +7,8 @@ Route23_Script:
Route23SetVictoryRoadBoulders:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
ret z
ResetEvents EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH1, EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2
ResetEvents EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1, EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH2
@@ -46,7 +46,7 @@ Route23DefaultScript:
ret nc
.not_past_victory_road
ld a, e
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
ld a, c
ld [wWhichBadge], a
ld b, FLAG_TEST
@@ -81,7 +81,7 @@ Route23CopyBadgeTextScript:
ld a, [hli]
ld h, [hl]
ld l, a
- ld de, wcd6d
+ ld de, wNameBuffer
.copyTextLoop
ld a, [hli]
ld [de], a
diff --git a/scripts/Route24.asm b/scripts/Route24.asm
index a5454773..29c90868 100644
--- a/scripts/Route24.asm
+++ b/scripts/Route24.asm
@@ -31,7 +31,7 @@ Route24DefaultScript:
xor a
ldh [hJoyHeld], a
ld a, TEXT_ROUTE24_COOLTRAINER_M1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
CheckAndResetEvent EVENT_NUGGET_REWARD_AVAILABLE
ret z
@@ -68,7 +68,7 @@ Route24AfterRocketBattleScript:
ld [wJoyIgnore], a
SetEvent EVENT_BEAT_ROUTE24_ROCKET
ld a, TEXT_ROUTE24_COOLTRAINER_M1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wJoyIgnore], a
@@ -120,13 +120,13 @@ Route24CooltrainerM1Text:
call PrintText
ld hl, .JoinTeamRocketText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .DefeatedText
ld de, .DefeatedText
call SaveEndBattleTextPointers
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hSpriteIndex]
ld [wSpriteIndex], a
call EngageMapTrainer
call InitBattleEnemyParameters
@@ -293,8 +293,8 @@ Route24CooltrainerM4Text:
and a
jr nz, .asm_515d0
ld a, CHARMANDER
- ld [wd11e], a
- ld [wcf91], a
+ ld [wNamedObjectIndex], a
+ ld [wCurPartySpecies], a
call GetMonName
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
diff --git a/scripts/Route25.asm b/scripts/Route25.asm
index 501592f9..8cb59c30 100644
--- a/scripts/Route25.asm
+++ b/scripts/Route25.asm
@@ -17,8 +17,8 @@ Route25ShowHideBillScript:
xor a
ld [wBillsHouseCurScript], a
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
ret z
CheckEventHL EVENT_LEFT_BILLS_HOUSE_AFTER_HELPING
ret nz
diff --git a/scripts/Route2Gate.asm b/scripts/Route2Gate.asm
index a198dbd7..795b210e 100644
--- a/scripts/Route2Gate.asm
+++ b/scripts/Route2Gate.asm
@@ -14,9 +14,9 @@ Route2GateOaksAideText:
ldh [hOaksAideRequirement], a
ld a, HM_FLASH
ldh [hOaksAideRewardItem], a
- ld [wd11e], a
+ ld [wNamedObjectIndex], a
call GetItemName
- ld hl, wcd6d
+ ld hl, wNameBuffer
ld de, wOaksAideRewardItemName
ld bc, ITEM_NAME_LENGTH
call CopyData
diff --git a/scripts/Route5Gate.asm b/scripts/Route5Gate.asm
index d6e086ce..0ccf9fae 100644
--- a/scripts/Route5Gate.asm
+++ b/scripts/Route5Gate.asm
@@ -17,8 +17,8 @@ Route5GateMovePlayerUpScript:
jp StartSimulatingJoypadStates
Route5GateDefaultScript:
- ld a, [wd728]
- bit 6, a
+ ld a, [wStatusFlags1]
+ bit BIT_GAVE_SAFFRON_GUARDS_DRINK, a
ret nz
ld hl, .PlayerInCoordsArray
call ArePlayerCoordsInArray
@@ -32,7 +32,7 @@ Route5GateDefaultScript:
and a
jr nz, .have_drink
ld a, TEXT_ROUTE5GATE_GUARD_GEE_IM_THIRSTY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Route5GateMovePlayerUpScript
ld a, SCRIPT_ROUTE5GATE_PLAYER_MOVING
@@ -40,10 +40,10 @@ Route5GateDefaultScript:
ret
.have_drink
ld a, TEXT_ROUTE5GATE_GUARD_GIVE_DRINK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
- ld hl, wd728
- set 6, [hl]
+ ld hl, wStatusFlags1
+ set BIT_GAVE_SAFFRON_GUARDS_DRINK, [hl]
ret
.PlayerInCoordsArray:
@@ -69,8 +69,8 @@ Route5Gate_TextPointers:
SaffronGateGuardText:
text_asm
- ld a, [wd728]
- bit 6, a
+ ld a, [wStatusFlags1]
+ bit BIT_GAVE_SAFFRON_GUARDS_DRINK, a
jr nz, .thanks_for_drink
farcall RemoveGuardDrink
ldh a, [hItemToRemoveID]
@@ -86,8 +86,8 @@ SaffronGateGuardText:
.have_drink
ld hl, SaffronGateGuardGiveDrinkText
call PrintText
- ld hl, wd728
- set 6, [hl]
+ ld hl, wStatusFlags1
+ set BIT_GAVE_SAFFRON_GUARDS_DRINK, [hl]
jp TextScriptEnd
.thanks_for_drink
diff --git a/scripts/Route6Gate.asm b/scripts/Route6Gate.asm
index db4cfcab..48228c7d 100644
--- a/scripts/Route6Gate.asm
+++ b/scripts/Route6Gate.asm
@@ -11,8 +11,8 @@ Route6Gate_ScriptPointers:
dw_const Route6GatePlayerMovingScript, SCRIPT_ROUTE6GATE_PLAYER_MOVING
Route6GateDefaultScript:
- ld a, [wd728]
- bit 6, a
+ ld a, [wStatusFlags1]
+ bit BIT_GAVE_SAFFRON_GUARDS_DRINK, a
ret nz
ld hl, .PlayerInCoordsArray
call ArePlayerCoordsInArray
@@ -26,17 +26,17 @@ Route6GateDefaultScript:
and a
jr nz, .have_drink
ld a, TEXT_ROUTE6GATE_GUARD_GEE_IM_THIRSTY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Route6GateMovePlayerDownScript
ld a, SCRIPT_ROUTE6GATE_PLAYER_MOVING
ld [wRoute6GateCurScript], a
ret
.have_drink
- ld hl, wd728
- set 6, [hl]
+ ld hl, wStatusFlags1
+ set BIT_GAVE_SAFFRON_GUARDS_DRINK, [hl]
ld a, TEXT_ROUTE6GATE_GUARD_GIVE_DRINK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
.PlayerInCoordsArray:
@@ -55,8 +55,8 @@ Route6GatePlayerMovingScript:
ret
Route6GateMovePlayerDownScript:
- ld hl, wd730
- set 7, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, D_DOWN
ld [wSimulatedJoypadStatesEnd], a
ld a, $1
diff --git a/scripts/Route7Gate.asm b/scripts/Route7Gate.asm
index 0260fb48..e599e147 100644
--- a/scripts/Route7Gate.asm
+++ b/scripts/Route7Gate.asm
@@ -11,8 +11,8 @@ Route7Gate_ScriptPointers:
dw_const Route7PlayerMovingScript, SCRIPT_ROUTE7GATE_PLAYER_MOVING
Route7GateMovePlayerLeftScript:
- ld hl, wd730
- set 7, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, D_LEFT
ld [wSimulatedJoypadStatesEnd], a
ld a, $1
@@ -23,8 +23,8 @@ Route7GateMovePlayerLeftScript:
ret
Route7DefaultScript:
- ld a, [wd728]
- bit 6, a
+ ld a, [wStatusFlags1]
+ bit BIT_GAVE_SAFFRON_GUARDS_DRINK, a
ret nz
ld hl, .PlayerInCoordsArray
call ArePlayerCoordsInArray
@@ -38,7 +38,7 @@ Route7DefaultScript:
and a
jr nz, .have_drink
ld a, TEXT_ROUTE7GATE_GUARD_GEE_IM_THIRSTY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Route7GateMovePlayerLeftScript
ld a, SCRIPT_ROUTE7GATE_PLAYER_MOVING
@@ -46,10 +46,10 @@ Route7DefaultScript:
ret
.have_drink
ld a, TEXT_ROUTE7GATE_GUARD_GIVE_DRINK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
- ld hl, wd728
- set 6, [hl]
+ ld hl, wStatusFlags1
+ set BIT_GAVE_SAFFRON_GUARDS_DRINK, [hl]
ret
.PlayerInCoordsArray:
diff --git a/scripts/Route8Gate.asm b/scripts/Route8Gate.asm
index 07e3f5c7..eb8b3957 100644
--- a/scripts/Route8Gate.asm
+++ b/scripts/Route8Gate.asm
@@ -10,8 +10,8 @@ Route8Gate_ScriptPointers:
dw_const Route8GatePlayerMovingScript, SCRIPT_ROUTE8GATE_PLAYER_MOVING
Route8GateMovePlayerRightScript:
- ld hl, wd730
- set 7, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld a, D_RIGHT
ld [wSimulatedJoypadStatesEnd], a
ld a, $1
@@ -22,8 +22,8 @@ Route8GateMovePlayerRightScript:
ret
Route8GateDefaultScript:
- ld a, [wd728]
- bit 6, a
+ ld a, [wStatusFlags1]
+ bit BIT_GAVE_SAFFRON_GUARDS_DRINK, a
ret nz
ld hl, .PlayerInCoordsArray
call ArePlayerCoordsInArray
@@ -37,17 +37,17 @@ Route8GateDefaultScript:
and a
jr nz, .have_drink
ld a, TEXT_ROUTE8GATE_GUARD_GEE_IM_THIRSTY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Route8GateMovePlayerRightScript
ld a, SCRIPT_ROUTE8GATE_PLAYER_MOVING
ld [wRoute8GateCurScript], a
ret
.have_drink
- ld hl, wd728
- set 6, [hl]
+ ld hl, wStatusFlags1
+ set BIT_GAVE_SAFFRON_GUARDS_DRINK, [hl]
ld a, TEXT_ROUTE8GATE_GUARD_GIVE_DRINK
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
jp DisplayTextID
.PlayerInCoordsArray:
diff --git a/scripts/SSAnne2F.asm b/scripts/SSAnne2F.asm
index d1e6b069..8fb6f18d 100644
--- a/scripts/SSAnne2F.asm
+++ b/scripts/SSAnne2F.asm
@@ -85,14 +85,14 @@ SSAnne2FSetFacingDirectionScript:
jp SetSpriteFacingDirectionAndDelay
SSAnne2FRivalStartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
call SSAnne2FSetFacingDirectionScript
xor a
ld [wJoyIgnore], a
ld a, TEXT_SSANNE2F_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
ld a, OPP_RIVAL2
@@ -112,7 +112,7 @@ SSAnne2FRivalAfterBattleScript:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_SSANNE2F_RIVAL_CUT_MASTER
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SSANNE2F_RIVAL
ldh [hSpriteIndex], a
@@ -145,8 +145,8 @@ SSAnne2FRivalAfterBattleScript:
db -1 ; end
SSAnne2FRivalExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
@@ -172,9 +172,9 @@ SSAnne2FRivalText:
text_asm
ld hl, .Text
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, SSAnne2FRivalDefeatedText
ld de, SSAnne2FRivalVictoryText
call SaveEndBattleTextPointers
diff --git a/scripts/SSAnneCaptainsRoom.asm b/scripts/SSAnneCaptainsRoom.asm
index 8926b604..1c49245b 100644
--- a/scripts/SSAnneCaptainsRoom.asm
+++ b/scripts/SSAnneCaptainsRoom.asm
@@ -5,8 +5,8 @@ SSAnneCaptainsRoom_Script:
SSAnneCaptainsRoomEventScript:
CheckEvent EVENT_GOT_HM01
ret nz
- ld hl, wd72d
- set 5, [hl]
+ ld hl, wStatusFlags3
+ set BIT_NO_NPC_FACE_PLAYER, [hl]
ret
SSAnneCaptainsRoom_TextPointers:
@@ -29,8 +29,8 @@ SSAnneCaptainsRoomCaptainText:
ld hl, SSAnneCaptainsRoomCaptainReceivedHM01Text
call PrintText
SetEvent EVENT_GOT_HM01
- ld hl, wd72d
- res 5, [hl]
+ ld hl, wStatusFlags3
+ res BIT_NO_NPC_FACE_PLAYER, [hl]
jr .done
.bag_full
ld hl, SSAnneCaptainsRoomCaptainHM01NoRoomText
@@ -62,8 +62,8 @@ SSAnneCaptainsRoomRubCaptainsBackText:
jr z, .loop
call PlayDefaultMusic
SetEvent EVENT_RUBBED_CAPTAINS_BACK
- ld hl, wd72d
- res 5, [hl]
+ ld hl, wStatusFlags3
+ res BIT_NO_NPC_FACE_PLAYER, [hl]
jp TextScriptEnd
SSAnneCaptainsRoomCaptainIFeelMuchBetterText:
diff --git a/scripts/SafariZoneGate.asm b/scripts/SafariZoneGate.asm
index db91146c..a0f4d828 100644
--- a/scripts/SafariZoneGate.asm
+++ b/scripts/SafariZoneGate.asm
@@ -21,7 +21,7 @@ SafariZoneGateDefaultScript:
call ArePlayerCoordsInArray
ret nc
ld a, TEXT_SAFARIZONEGATE_SAFARI_ZONE_WORKER1_1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -59,7 +59,7 @@ SafariZoneGateWouldYouLikeToJoinScript:
ld [wJoyIgnore], a
call UpdateSprites
ld a, TEXT_SAFARIZONEGATE_SAFARI_ZONE_WORKER1_WOULD_YOU_LIKE_TO_JOIN
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -84,7 +84,7 @@ SafariZoneGateLeavingSafariScript:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_SAFARIZONEGATE_SAFARI_ZONE_WORKER1_GOOD_HAUL_COME_AGAIN
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wNumSafariBalls], a
@@ -98,7 +98,7 @@ SafariZoneGateLeavingSafariScript:
jr .return
.leaving_early
ld a, TEXT_SAFARIZONEGATE_SAFARI_ZONE_WORKER1_LEAVING_EARLY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.return
ret
diff --git a/scripts/SaffronGym.asm b/scripts/SaffronGym.asm
index 96e453df..4bfb7b2c 100644
--- a/scripts/SaffronGym.asm
+++ b/scripts/SaffronGym.asm
@@ -1,7 +1,7 @@
SaffronGym_Script:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, .LoadNames
call EnableAutoTextBoxDrawing
ld hl, SaffronGymTrainerHeaders
@@ -45,20 +45,20 @@ SaffronGymSabrinaPostBattle:
SaffronGymSabrinaReceiveTM46Script:
ld a, TEXT_SAFFRONGYM_SABRINA_MARSH_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_SABRINA
lb bc, TM_PSYWAVE, 1
call GiveItem
jr nc, .BagFull
ld a, TEXT_SAFFRONGYM_SABRINA_RECEIVED_TM46
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM46
jr .gymVictory
.BagFull
ld a, TEXT_SAFFRONGYM_SABRINA_TM46_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gymVictory
ld hl, wObtainedBadges
@@ -120,9 +120,9 @@ SaffronGymSabrinaText:
.beforeBeat
ld hl, .Text
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .ReceivedMarshBadgeText
ld de, .ReceivedMarshBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/SeafoamIslands1F.asm b/scripts/SeafoamIslands1F.asm
index 27ddc276..a3ec3c99 100644
--- a/scripts/SeafoamIslands1F.asm
+++ b/scripts/SeafoamIslands1F.asm
@@ -1,9 +1,9 @@
SeafoamIslands1F_Script:
call EnableAutoTextBoxDrawing
SetEvent EVENT_IN_SEAFOAM_ISLANDS
- ld hl, wFlags_0xcd60
- bit 7, [hl]
- res 7, [hl]
+ ld hl, wMiscFlags
+ bit BIT_PUSHED_BOULDER, [hl]
+ res BIT_PUSHED_BOULDER, [hl]
jr z, .noBoulderWasPushed
ld hl, Seafoam1HolesCoords
call CheckBoulderCoords
diff --git a/scripts/SeafoamIslandsB1F.asm b/scripts/SeafoamIslandsB1F.asm
index 271775ed..0bc2ee18 100644
--- a/scripts/SeafoamIslandsB1F.asm
+++ b/scripts/SeafoamIslandsB1F.asm
@@ -1,8 +1,8 @@
SeafoamIslandsB1F_Script:
call EnableAutoTextBoxDrawing
- ld hl, wFlags_0xcd60
- bit 7, [hl]
- res 7, [hl]
+ ld hl, wMiscFlags
+ bit BIT_PUSHED_BOULDER, [hl]
+ res BIT_PUSHED_BOULDER, [hl]
jr z, .noBoulderWasPushed
ld hl, Seafoam2HolesCoords
call CheckBoulderCoords
diff --git a/scripts/SeafoamIslandsB2F.asm b/scripts/SeafoamIslandsB2F.asm
index 71ae2e1a..48b7979d 100644
--- a/scripts/SeafoamIslandsB2F.asm
+++ b/scripts/SeafoamIslandsB2F.asm
@@ -1,8 +1,8 @@
SeafoamIslandsB2F_Script:
call EnableAutoTextBoxDrawing
- ld hl, wFlags_0xcd60
- bit 7, [hl]
- res 7, [hl]
+ ld hl, wMiscFlags
+ bit BIT_PUSHED_BOULDER, [hl]
+ res BIT_PUSHED_BOULDER, [hl]
jr z, .noBoulderWasPushed
ld hl, Seafoam3HolesCoords
call CheckBoulderCoords
diff --git a/scripts/SeafoamIslandsB3F.asm b/scripts/SeafoamIslandsB3F.asm
index 8c225dcc..23dfd050 100644
--- a/scripts/SeafoamIslandsB3F.asm
+++ b/scripts/SeafoamIslandsB3F.asm
@@ -1,8 +1,8 @@
SeafoamIslandsB3F_Script:
call EnableAutoTextBoxDrawing
- ld hl, wFlags_0xcd60
- bit 7, [hl]
- res 7, [hl]
+ ld hl, wMiscFlags
+ bit BIT_PUSHED_BOULDER, [hl]
+ res BIT_PUSHED_BOULDER, [hl]
jr z, .noBoulderWasPushed
ld hl, Seafoam4HolesCoords
call CheckBoulderCoords
@@ -36,8 +36,8 @@ SeafoamIslandsB3F_Script:
ld [wDungeonWarpDestinationMap], a
ld hl, Seafoam4HolesCoords
call IsPlayerOnDungeonWarp
- ld a, [wd732]
- bit 4, a
+ ld a, [wStatusFlags6]
+ bit BIT_DUNGEON_WARP, a
ret nz
.runCurrentMapScript
ld hl, SeafoamIslandsB3F_ScriptPointers
@@ -72,8 +72,8 @@ SeafoamIslandsB3FDefaultScript:
dec a
ld [wSimulatedJoypadStatesIndex], a
call StartSimulatingJoypadStates
- ld hl, wFlags_D733
- set 2, [hl]
+ ld hl, wStatusFlags7
+ set BIT_FORCED_WARP, [hl]
ld a, SCRIPT_SEAFOAMISLANDSB3F_OBJECT_MOVING1
ld [wSeafoamIslandsB3FCurScript], a
ret
@@ -112,10 +112,10 @@ SeafoamIslandsB3FMoveObjectScript:
ld [wSimulatedJoypadStatesIndex], a
xor a
ld [wSpritePlayerStateData2MovementByte1], a
- ld hl, wd730
- set 7, [hl]
- ld hl, wFlags_D733
- set 2, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
+ ld hl, wStatusFlags7
+ set BIT_FORCED_WARP, [hl]
ld a, SCRIPT_SEAFOAMISLANDSB3F_OBJECT_MOVING2
.playerNotInStrongCurrent
ld [wSeafoamIslandsB3FCurScript], a
diff --git a/scripts/SeafoamIslandsB4F.asm b/scripts/SeafoamIslandsB4F.asm
index dc7be7d1..5fe805f0 100644
--- a/scripts/SeafoamIslandsB4F.asm
+++ b/scripts/SeafoamIslandsB4F.asm
@@ -49,8 +49,8 @@ SeafoamIslandsB4FDefaultScript:
ld a, D_UP
ld [wSimulatedJoypadStatesEnd], a
call StartSimulatingJoypadStates
- ld hl, wFlags_D733
- res 2, [hl]
+ ld hl, wStatusFlags7
+ res BIT_FORCED_WARP, [hl]
ld a, SCRIPT_SEAFOAMISLANDSB4F_OBJECT_MOVING1
ld [wSeafoamIslandsB4FCurScript], a
ret
diff --git a/scripts/SilphCo10F.asm b/scripts/SilphCo10F.asm
index 7cc2c58e..d9650bc8 100644
--- a/scripts/SilphCo10F.asm
+++ b/scripts/SilphCo10F.asm
@@ -10,8 +10,8 @@ SilphCo10F_Script:
SilphCo10FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo2F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo11F.asm b/scripts/SilphCo11F.asm
index be004d68..87887432 100644
--- a/scripts/SilphCo11F.asm
+++ b/scripts/SilphCo11F.asm
@@ -10,8 +10,8 @@ SilphCo11F_Script:
SilphCo11FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, SilphCo11GateCoords
call SilphCo11F_SetCardKeyDoorYScript
@@ -122,7 +122,7 @@ SilphCo11FScript_621c5:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_SILPHCO11F_GIOVANNI
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SILPHCO11F_GIOVANNI
ldh [hSpriteIndex], a
@@ -170,7 +170,7 @@ SilphCo11FGiovanniAfterBattleScript:
ld a, D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
ld a, TEXT_SILPHCO11F_GIOVANNI_YOU_RUINED_OUR_PLANS
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call GBFadeOutToBlack
farcall SilphCo11FTeamRocketLeavesScript
@@ -183,8 +183,8 @@ SilphCo11FGiovanniAfterBattleScript:
jp SilphCo11FSetCurScript
SilphCo11FGiovanniStartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, SILPHCO11F_GIOVANNI
ldh [hSpriteIndex], a
@@ -203,9 +203,9 @@ SilphCo11FGiovanniStartBattleScript:
call Delay3
xor a
ld [wJoyIgnore], a
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, SilphCo10FGiovanniILostAgainText
ld de, SilphCo10FGiovanniILostAgainText
call SaveEndBattleTextPointers
@@ -245,7 +245,7 @@ SilphCo11FScript_6229c:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_SILPHCO11F_TEXT8
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
@@ -314,7 +314,7 @@ SilphCo11FScript5:
ld de, SilphCo11FMovementData_6230b
.asm_6232d
ld a, SILPHCO11F_JAMES
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -325,8 +325,8 @@ SilphCo11FScript5:
SilphCo11FScript6:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
SilphCo11FScript7:
ld a, $2
@@ -352,7 +352,7 @@ SilphCo11FScript8:
ld de, SilphCo11FMovementData_62311
.asm_6237b
ld a, SILPHCO11F_JESSIE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -363,8 +363,8 @@ SilphCo11FScript8:
SilphCo11FScript9:
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
ld [wJoyIgnore], a
@@ -380,12 +380,12 @@ SilphCo11FScript10:
.asm_623b1
call Delay3
ld a, TEXT_SILPHCO11F_TEXT9
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SilphCo11FScript11:
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, SilphCo11FText_624c2
ld de, SilphCo11FText_624c2
call SaveEndBattleTextPointers
@@ -417,7 +417,7 @@ SilphCo11FScript12:
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
ld a, TEXT_SILPHCO11F_TEXT10
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
diff --git a/scripts/SilphCo2F.asm b/scripts/SilphCo2F.asm
index 52241b95..7ca57c45 100644
--- a/scripts/SilphCo2F.asm
+++ b/scripts/SilphCo2F.asm
@@ -10,8 +10,8 @@ SilphCo2F_Script:
SilphCo2FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo2F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo3F.asm b/scripts/SilphCo3F.asm
index df9df9e8..146cbb07 100644
--- a/scripts/SilphCo3F.asm
+++ b/scripts/SilphCo3F.asm
@@ -10,8 +10,8 @@ SilphCo3F_Script:
SilphCo3FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo2F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo4F.asm b/scripts/SilphCo4F.asm
index 91453d65..f84ef995 100644
--- a/scripts/SilphCo4F.asm
+++ b/scripts/SilphCo4F.asm
@@ -10,8 +10,8 @@ SilphCo4F_Script:
SilphCo4FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo4F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo5F.asm b/scripts/SilphCo5F.asm
index 1834bfa8..599c1743 100644
--- a/scripts/SilphCo5F.asm
+++ b/scripts/SilphCo5F.asm
@@ -10,8 +10,8 @@ SilphCo5F_Script:
SilphCo5FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo4F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo6F.asm b/scripts/SilphCo6F.asm
index 0626ffdb..ad8e83f4 100644
--- a/scripts/SilphCo6F.asm
+++ b/scripts/SilphCo6F.asm
@@ -10,8 +10,8 @@ SilphCo6F_Script:
SilphCo6F_GateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo4F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo7F.asm b/scripts/SilphCo7F.asm
index 74788bf6..e0bf102f 100644
--- a/scripts/SilphCo7F.asm
+++ b/scripts/SilphCo7F.asm
@@ -10,8 +10,8 @@ SilphCo7F_Script:
SilphCo7F_GateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo7F_SetCardKeyDoorYScript
@@ -136,7 +136,7 @@ SilphCo7FDefaultScript:
ld a, MUSIC_MEET_RIVAL
call PlayMusic
ld a, TEXT_SILPHCO7F_RIVAL
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, SILPHCO7F_RIVAL
ldh [hSpriteIndex], a
@@ -167,18 +167,18 @@ SilphCo7FDefaultScript:
db -1 ; end
SilphCo7FRivalStartBattleScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
xor a
ld [wJoyIgnore], a
ld a, TEXT_SILPHCO7F_RIVAL_WAITED_HERE
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call Delay3
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, SilphCo7FRivalDefeatedText
ld de, SilphCo7FRivalVictoryText
call SaveEndBattleTextPointers
@@ -206,7 +206,7 @@ SilphCo7FRivalAfterBattleScript:
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, TEXT_SILPHCO7F_RIVAL_GOOD_LUCK_TO_YOU
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call StopAllMusic
farcall Music_RivalAlternateStart
@@ -238,8 +238,8 @@ SilphCo7FRivalAfterBattleScript:
db -1 ; end
SilphCo7FRivalExitScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_SILPH_CO_7F_RIVAL
ld [wMissableObjectIndex], a
@@ -282,8 +282,8 @@ SilphCo7TrainerHeader3:
SilphCo7FSilphWorkerM1Text:
; lapras guy
text_asm
- ld a, [wd72e]
- bit 0, a ; got lapras?
+ ld a, [wStatusFlags4]
+ bit BIT_GOT_LAPRAS, a
jr z, .give_lapras
CheckEvent EVENT_BEAT_SILPH_CO_GIOVANNI
jr nz, .saved_silph
@@ -302,8 +302,8 @@ SilphCo7FSilphWorkerM1Text:
call EnableAutoTextBoxDrawing
ld hl, .LaprasDescriptionText
call PrintText
- ld hl, wd72e
- set 0, [hl]
+ ld hl, wStatusFlags4
+ set BIT_GOT_LAPRAS, [hl]
jr .done
.saved_silph
ld hl, .SavedText
diff --git a/scripts/SilphCo8F.asm b/scripts/SilphCo8F.asm
index cdd7f486..dcba85c0 100644
--- a/scripts/SilphCo8F.asm
+++ b/scripts/SilphCo8F.asm
@@ -10,8 +10,8 @@ SilphCo8F_Script:
SilphCo8FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo8F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCo9F.asm b/scripts/SilphCo9F.asm
index fe7f3da2..aec4dbf8 100644
--- a/scripts/SilphCo9F.asm
+++ b/scripts/SilphCo9F.asm
@@ -10,8 +10,8 @@ SilphCo9F_Script:
SilphCo9FGateCallbackScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
ld hl, .GateCoordinates
call SilphCo9F_SetCardKeyDoorYScript
diff --git a/scripts/SilphCoElevator.asm b/scripts/SilphCoElevator.asm
index a2ed009e..ffdf101e 100644
--- a/scripts/SilphCoElevator.asm
+++ b/scripts/SilphCoElevator.asm
@@ -1,12 +1,12 @@
SilphCoElevator_Script:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
push hl
call nz, SilphCoElevatorStoreWarpEntriesScript
pop hl
- bit 7, [hl]
- res 7, [hl]
+ bit BIT_CUR_MAP_USED_ELEVATOR, [hl]
+ res BIT_CUR_MAP_USED_ELEVATOR, [hl]
call nz, SilphCoElevatorShakeScript
xor a
ld [wAutoTextBoxDrawingControl], a
diff --git a/scripts/SummerBeachHouse.asm b/scripts/SummerBeachHouse.asm
index 285d1e97..e1a0ccca 100644
--- a/scripts/SummerBeachHouse.asm
+++ b/scripts/SummerBeachHouse.asm
@@ -167,14 +167,14 @@ ENDC
and a
jp z, Func_f23d0
call SaveScreenTilesToBuffer2
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
xor a
ld [wUpdateSpritesEnabled], a
callfar Printer_PrepareSurfingMinigameHighScoreTileMap
call WaitForTextScrollButtonPress
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call GBPalWhiteOutWithDelay3
call ReloadTilesetTilePatterns
call RestoreScreenTilesAndReloadTilePatterns
diff --git a/scripts/SummerBeachHouse_2.asm b/scripts/SummerBeachHouse_2.asm
index 4ac1f705..6349a479 100644
--- a/scripts/SummerBeachHouse_2.asm
+++ b/scripts/SummerBeachHouse_2.asm
@@ -2,11 +2,11 @@ Func_f23d0:
call SaveScreenTilesToBuffer2
xor a
ld [wUpdateSpritesEnabled], a
- ld hl, wd730
- set 6, [hl]
+ ld hl, wStatusFlags5
+ set BIT_NO_TEXT_DELAY, [hl]
callfar PrintSurfingMinigameHighScore
- ld hl, wd730
- res 6, [hl]
+ ld hl, wStatusFlags5
+ res BIT_NO_TEXT_DELAY, [hl]
call GBPalWhiteOutWithDelay3
call ReloadTilesetTilePatterns
call RestoreScreenTilesAndReloadTilePatterns
diff --git a/scripts/TradeCenter.asm b/scripts/TradeCenter.asm
index d7e7c54c..c716484c 100644
--- a/scripts/TradeCenter.asm
+++ b/scripts/TradeCenter.asm
@@ -10,9 +10,9 @@ TradeCenter_Script:
ld a, TRADECENTER_OPPONENT
ldh [hSpriteIndex], a
call SetSpriteFacingDirection
- ld hl, wd72d
- bit 0, [hl]
- set 0, [hl]
+ ld hl, wStatusFlags3
+ bit BIT_INIT_TRADE_CENTER_FACING, [hl]
+ set BIT_INIT_TRADE_CENTER_FACING, [hl]
ret nz
ld hl, wSprite01StateData2MapY
ld a, 8 ; y
diff --git a/scripts/VermilionCity.asm b/scripts/VermilionCity.asm
index 7056a337..647446fa 100644
--- a/scripts/VermilionCity.asm
+++ b/scripts/VermilionCity.asm
@@ -3,13 +3,13 @@ VermilionCity_Script:
ld hl, wd492
res 7, [hl]
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
push hl
call nz, VermilionCityLeftSSAnneCallbackScript
pop hl
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
call nz, .setFirstLockTrashCanIndex
ld hl, VermilionCity_ScriptPointers
ld a, [wVermilionCityCurScript]
@@ -64,7 +64,7 @@ VermilionCityDefaultScript:
ldh [hJoyHeld], a
ld [wSavedCoordIndex], a ; unnecessary
ld a, TEXT_VERMILIONCITY_SAILOR1
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
CheckEvent EVENT_SS_ANNE_LEFT
jr nz, .ship_departed
diff --git a/scripts/VermilionCity_2.asm b/scripts/VermilionCity_2.asm
index 52721a55..8b012659 100644
--- a/scripts/VermilionCity_2.asm
+++ b/scripts/VermilionCity_2.asm
@@ -16,8 +16,8 @@ VermilionCityPrintOfficerJennyText::
and a
jr nz, .asm_f1a62
ld a, SQUIRTLE
- ld [wd11e], a
- ld [wcf91], a
+ ld [wNamedObjectIndex], a
+ ld [wCurPartySpecies], a
call GetMonName
ld a, $1
ld [wDoNotWaitForButtonPressAfterDisplayingText], a
diff --git a/scripts/VermilionDock.asm b/scripts/VermilionDock.asm
index 934b8d2f..ce4e5f1e 100644
--- a/scripts/VermilionDock.asm
+++ b/scripts/VermilionDock.asm
@@ -11,8 +11,8 @@ VermilionDock_Script:
jp z, VermilionDockSSAnneLeavesScript
SetEventReuseHL EVENT_STARTED_WALKING_OUT_OF_DOCK
call Delay3
- ld hl, wd730
- set 7, [hl]
+ ld hl, wStatusFlags5
+ set BIT_SCRIPTED_MOVEMENT_STATE, [hl]
ld hl, wSimulatedJoypadStatesEnd
ld a, D_UP
ld [hli], a
diff --git a/scripts/VermilionGym.asm b/scripts/VermilionGym.asm
index a4fab952..8d3a33b6 100644
--- a/scripts/VermilionGym.asm
+++ b/scripts/VermilionGym.asm
@@ -1,12 +1,12 @@
VermilionGym_Script:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
push hl
call nz, .LoadNames
pop hl
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, VermilionGymSetDoorTile
call EnableAutoTextBoxDrawing
ld hl, VermilionGymTrainerHeaders
@@ -64,20 +64,20 @@ VermilionGymLTSurgeAfterBattleScript:
VermilionGymLTSurgeReceiveTM24Script:
ld a, TEXT_VERMILIONGYM_LT_SURGE_THUNDER_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_LT_SURGE
lb bc, TM_THUNDERBOLT, 1
call GiveItem
jr nc, .bag_full
ld a, TEXT_VERMILIONGYM_LT_SURGE_RECEIVED_TM24
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM24
jr .gym_victory
.bag_full
ld a, TEXT_VERMILIONGYM_LT_SURGE_TM24_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gym_victory
ld hl, wObtainedBadges
@@ -127,9 +127,9 @@ VermilionGymLTSurgeText:
.before_beat
ld hl, .PreBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, VermilionGymLTSurgeReceivedThunderBadgeText
ld de, VermilionGymLTSurgeReceivedThunderBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/VermilionOldRodHouse.asm b/scripts/VermilionOldRodHouse.asm
index f170bcaf..8663de69 100644
--- a/scripts/VermilionOldRodHouse.asm
+++ b/scripts/VermilionOldRodHouse.asm
@@ -7,8 +7,8 @@ VermilionOldRodHouse_TextPointers:
VermilionOldRodHouseFishingGuruText:
text_asm
- ld a, [wd728]
- bit 3, a ; got old rod?
+ ld a, [wStatusFlags1]
+ bit BIT_GOT_OLD_ROD, a
jr nz, .got_old_rod
ld hl, .DoYouLikeToFishText
call PrintText
@@ -19,8 +19,8 @@ VermilionOldRodHouseFishingGuruText:
lb bc, OLD_ROD, 1
call GiveItem
jr nc, .bag_full
- ld hl, wd728
- set 3, [hl] ; got old rod
+ ld hl, wStatusFlags1
+ set BIT_GOT_OLD_ROD, [hl]
ld hl, .TakeThisText
jr .print_text
.bag_full
diff --git a/scripts/VictoryRoad1F.asm b/scripts/VictoryRoad1F.asm
index 42852692..b7f7a56b 100644
--- a/scripts/VictoryRoad1F.asm
+++ b/scripts/VictoryRoad1F.asm
@@ -1,7 +1,7 @@
VictoryRoad1F_Script:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
call nz, .next
call EnableAutoTextBoxDrawing
ld hl, VictoryRoad1TrainerHeaders
@@ -34,7 +34,7 @@ VictoryRoad1FDefaultScript:
cp $f
jp z, CheckFightingMapTrainers
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
SetEvent EVENT_VICTORY_ROAD_1_BOULDER_ON_SWITCH
ret
diff --git a/scripts/VictoryRoad2F.asm b/scripts/VictoryRoad2F.asm
index 67244ef4..66340503 100644
--- a/scripts/VictoryRoad2F.asm
+++ b/scripts/VictoryRoad2F.asm
@@ -1,11 +1,11 @@
VictoryRoad2F_Script:
ld hl, wCurrentMapScriptFlags
- bit 6, [hl]
- res 6, [hl]
+ bit BIT_CUR_MAP_LOADED_2, [hl]
+ res BIT_CUR_MAP_LOADED_2, [hl]
call nz, VictoryRoad2FResetBoulderEventScript
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
call nz, VictoryRoad2FCheckBoulderEventScript
call EnableAutoTextBoxDrawing
ld hl, VictoryRoad2TrainerHeaders
@@ -27,7 +27,7 @@ VictoryRoad2FCheckBoulderEventScript:
call VictoryRoad2FReplaceTileBlockScript
pop af
.not_on_switch
- bit 7, a
+ CheckEventReuseA EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2
ret z
ld a, $1d
lb bc, 7, 11
@@ -46,7 +46,7 @@ VictoryRoad2FDefaultScript:
ld hl, .SwitchCoords
call CheckBoulderCoords
jp nc, CheckFightingMapTrainers
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hSpriteIndex]
cp $f
jp z, CheckFightingMapTrainers
EventFlagAddress hl, EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH1
@@ -63,7 +63,7 @@ VictoryRoad2FDefaultScript:
ret nz
.set_script_flag
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
ret
.SwitchCoords:
diff --git a/scripts/VictoryRoad3F.asm b/scripts/VictoryRoad3F.asm
index 66f5c86e..ec042e48 100644
--- a/scripts/VictoryRoad3F.asm
+++ b/scripts/VictoryRoad3F.asm
@@ -10,8 +10,8 @@ VictoryRoad3F_Script:
VictoryRoad3FCheckBoulderEventScript:
ld hl, wCurrentMapScriptFlags
- bit 5, [hl]
- res 5, [hl]
+ bit BIT_CUR_MAP_LOADED_1, [hl]
+ res BIT_CUR_MAP_LOADED_1, [hl]
ret z
CheckEventHL EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1
ret z
@@ -27,9 +27,9 @@ VictoryRoad3F_ScriptPointers:
dw_const EndTrainerBattle, SCRIPT_VICTORYROAD3F_END_BATTLE
VictoryRoad3FDefaultScript:
- ld hl, wFlags_0xcd60
- bit 7, [hl]
- res 7, [hl]
+ ld hl, wMiscFlags
+ bit BIT_PUSHED_BOULDER, [hl]
+ res BIT_PUSHED_BOULDER, [hl]
jp z, .check_switch_hole
ld hl, .SwitchOrHoleCoords
call CheckBoulderCoords
@@ -37,11 +37,11 @@ VictoryRoad3FDefaultScript:
ld a, [wCoordIndex]
cp $1
jr nz, .handle_hole
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hSpriteIndex]
cp $f ; Pikachu
jp z, .check_switch_hole
ld hl, wCurrentMapScriptFlags
- set 5, [hl]
+ set BIT_CUR_MAP_LOADED_1, [hl]
SetEvent EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1
ret
.handle_hole
@@ -67,14 +67,14 @@ VictoryRoad3FDefaultScript:
ld a, [wCoordIndex]
cp $1
jr nz, .hole
- ld hl, wd72d
- res 4, [hl]
- ld hl, wd732
- res 4, [hl]
+ ld hl, wStatusFlags3
+ res BIT_ON_DUNGEON_WARP, [hl]
+ ld hl, wStatusFlags6
+ res BIT_DUNGEON_WARP, [hl]
ret
.hole
- ld a, [wd72d]
- bit 4, a
+ ld a, [wStatusFlags3]
+ bit BIT_ON_DUNGEON_WARP, a
jp z, CheckFightingMapTrainers
ret
diff --git a/scripts/ViridianCity.asm b/scripts/ViridianCity.asm
index 0219fc91..9ffe0950 100644
--- a/scripts/ViridianCity.asm
+++ b/scripts/ViridianCity.asm
@@ -46,7 +46,7 @@ ViridianCityCheckGymOpenScript:
cp 32
ret nz
ld a, TEXT_VIRIDIANCITY_GYM_LOCKED
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
call StartSimulatingJoypadStates
ld a, $1
@@ -78,7 +78,7 @@ ViridianCityCheckSleepingOldMan:
cp 19
ret nz
ld a, TEXT_VIRIDIANCITY_OLD_MAN_SLEEPY
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ldh [hJoyHeld], a
@@ -101,7 +101,7 @@ ViridianCityOldManStartCatchTrainingScript:
ld a, BATTLE_TYPE_OLD_MAN
ld [wBattleType], a
ld a, 5
- ld [wCurEnemyLVL], a
+ ld [wCurEnemyLevel], a
ld a, RATTATA
ld [wCurOpponent], a
ret
@@ -125,7 +125,7 @@ ViridianCityOldManEndCatchTrainingScript:
xor a
ld [wJoyIgnore], a
ld a, TEXT_VIRIDIANCITY_OLD_MAN_YOU_NEED_TO_WEAKEN_THE_TARGET
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wBattleType], a
@@ -175,14 +175,14 @@ ViridianCityCheckWaitingOldMan:
cp 19
ret nz
ld a, VIRIDIANCITY_OLD_MAN2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
ld a, SPRITE_FACING_RIGHT
ldh [hSpriteFacingDirection], a
call SetSpriteFacingDirectionAndDelay
ld a, SPRITE_FACING_LEFT
ld [wSpritePlayerStateData1FacingDirection], a
ld a, TEXT_VIRIDIANCITY_OLD_MAN2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld a, D_UP | D_DOWN | D_LEFT | D_RIGHT | START | SELECT
ld [wJoyIgnore], a
@@ -206,7 +206,7 @@ ViridianCityOldManEndInitialCatchTrainingScript:
ld a, D_UP | D_DOWN | D_LEFT | D_RIGHT | START | SELECT
ld [wJoyIgnore], a
ld a, TEXT_VIRIDIANCITY_OLD_MAN2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
xor a
ld [wBattleType], a
@@ -225,7 +225,7 @@ ViridianCityPostInitialCatchTraining:
ld de, ViridianCityOldManMovementData1
.move_old_man
ld a, VIRIDIANCITY_OLD_MAN2
- ldh [hSpriteIndexOrTextID], a
+ ldh [hSpriteIndex], a
call MoveSprite
ld a, SCRIPT_VIRIDIANCITY_OLD_MAN_MOVING_DOWN
ld [wViridianCityCurScript], a
@@ -243,8 +243,8 @@ ViridianCityOldManMovementData2:
db $ff
ViridianCityOldManMovingDownScript:
- ld a, [wd730]
- bit 0, a
+ ld a, [wStatusFlags5]
+ bit BIT_SCRIPTED_NPC_MOVEMENT, a
ret nz
ld a, HS_OLD_MAN_2
ld [wMissableObjectIndex], a
diff --git a/scripts/ViridianGym.asm b/scripts/ViridianGym.asm
index 5162d3bc..55d849d2 100644
--- a/scripts/ViridianGym.asm
+++ b/scripts/ViridianGym.asm
@@ -41,8 +41,8 @@ ViridianGymDefaultScript:
cp $ff
jp z, CheckFightingMapTrainers
call StartSimulatingJoypadStates
- ld hl, wd736
- set 7, [hl]
+ ld hl, wMovementFlags
+ set BIT_SPINNING, [hl]
ld a, SFX_ARROW_TILES
call PlaySound
ld a, A_BUTTON | B_BUTTON | SELECT | START | D_RIGHT | D_LEFT | D_UP | D_DOWN
@@ -120,8 +120,8 @@ ViridianGymPlayerSpinningScript:
jr nz, .ViridianGymLoadSpinnerArrow
xor a
ld [wJoyIgnore], a
- ld hl, wd736
- res 7, [hl]
+ ld hl, wMovementFlags
+ res BIT_SPINNING, [hl]
ld a, SCRIPT_VIRIDIANGYM_DEFAULT
ld [wCurMapScript], a
ret
@@ -137,20 +137,20 @@ ViridianGymGiovanniPostBattle:
; fallthrough
ViridianGymReceiveTM27:
ld a, TEXT_VIRIDIANGYM_GIOVANNI_EARTH_BADGE_INFO
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_BEAT_VIRIDIAN_GYM_GIOVANNI
lb bc, TM_FISSURE, 1
call GiveItem
jr nc, .bag_full
ld a, TEXT_VIRIDIANGYM_GIOVANNI_RECEIVED_TM27
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
SetEvent EVENT_GOT_TM27
jr .gym_victory
.bag_full
ld a, TEXT_VIRIDIANGYM_GIOVANNI_TM27_NO_ROOM
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
.gym_victory
ld hl, wObtainedBadges
@@ -229,9 +229,9 @@ ViridianGymGiovanniText:
.beforeBeat
ld hl, .PreBattleText
call PrintText
- ld hl, wd72d
- set 6, [hl]
- set 7, [hl]
+ ld hl, wStatusFlags3
+ set BIT_TALKED_TO_TRAINER, [hl]
+ set BIT_PRINT_END_BATTLE_TEXT, [hl]
ld hl, .ReceivedEarthBadgeText
ld de, .ReceivedEarthBadgeText
call SaveEndBattleTextPointers
diff --git a/scripts/ViridianMart.asm b/scripts/ViridianMart.asm
index c180d149..d3b3eceb 100644
--- a/scripts/ViridianMart.asm
+++ b/scripts/ViridianMart.asm
@@ -29,7 +29,7 @@ ViridianMart_ScriptPointers:
ViridianMartDefaultScript:
call UpdateSprites
ld a, TEXT_VIRIDIANMART_CLERK_YOU_CAME_FROM_PALLET_TOWN
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
ld hl, wSimulatedJoypadStatesEnd
ld de, .PlayerMovement
@@ -52,7 +52,7 @@ ViridianMartOaksParcelScript:
ret nz
call Delay3
ld a, TEXT_VIRIDIANMART_CLERK_PARCEL_QUEST
- ldh [hSpriteIndexOrTextID], a
+ ldh [hTextID], a
call DisplayTextID
lb bc, OAKS_PARCEL, 1
call GiveItem
diff --git a/scripts/WardensHouse.asm b/scripts/WardensHouse.asm
index 1851e341..aa6be6ca 100644
--- a/scripts/WardensHouse.asm
+++ b/scripts/WardensHouse.asm
@@ -95,7 +95,7 @@ WardensHouseWardenText:
WardensHouseDisplayText:
text_asm
- ldh a, [hSpriteIndexOrTextID]
+ ldh a, [hTextID]
cp TEXT_WARDENSHOUSE_DISPLAY_LEFT
ld hl, .MerchandiseText
jr nz, .print_text